DPDK patches and discussions
 help / color / mirror / Atom feed
* Ubuntu 20.04 EOL
@ 2025-08-28  4:34 Stephen Hemminger
  2025-08-28  6:44 ` Morten Brørup
  2025-08-28  6:50 ` Morten Brørup
  0 siblings, 2 replies; 4+ messages in thread
From: Stephen Hemminger @ 2025-08-28  4:34 UTC (permalink / raw)
  To: dev

Looks like Ubuntu 20.04 LTS (Focal Fossa) reached the end of standard support.
Should we drop it for DTS?

Asking because the recent patch to handle shadow warnings doesn't work on
compilers like Gcc 9.4 which don't know what -Wshadow is.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: Ubuntu 20.04 EOL
  2025-08-28  4:34 Ubuntu 20.04 EOL Stephen Hemminger
@ 2025-08-28  6:44 ` Morten Brørup
  2025-08-28  6:50 ` Morten Brørup
  1 sibling, 0 replies; 4+ messages in thread
From: Morten Brørup @ 2025-08-28  6:44 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev

> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Thursday, 28 August 2025 06.35
> 
> Looks like Ubuntu 20.04 LTS (Focal Fossa) reached the end of standard support.

Paid support is available until May 2030:
https://ubuntu.com/blog/ubuntu-20-04-lts-end-of-life-standard-support-is-coming-to-an-end-heres-how-to-prepare

> Should we drop it for DTS?
> 
> Asking because the recent patch to handle shadow warnings doesn't work on
> compilers like Gcc 9.4 which don't know what -Wshadow is.

Our current minimum GCC compiler requirement is version 8.0:
https://git.dpdk.org/dpdk/tree/doc/guides/linux_gsg/sys_reqs.rst#n32

Which GCC version is required to support -Wshadow, and which GCC versions are included in relevant distros?

Maybe the -Wshadow can be added conditionally, depending on compiler version.
Shadow variables will not be caught locally, if using an old compiler version. But the CI will catch them in the tests running on recent compiler versions.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: Ubuntu 20.04 EOL
  2025-08-28  4:34 Ubuntu 20.04 EOL Stephen Hemminger
  2025-08-28  6:44 ` Morten Brørup
@ 2025-08-28  6:50 ` Morten Brørup
  2025-08-28 14:49   ` Stephen Hemminger
  1 sibling, 1 reply; 4+ messages in thread
From: Morten Brørup @ 2025-08-28  6:50 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev

> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Thursday, 28 August 2025 06.35
> 
> Looks like Ubuntu 20.04 LTS (Focal Fossa) reached the end of standard support.

Paid support is available until May 2030:
https://ubuntu.com/blog/ubuntu-20-04-lts-end-of-life-standard-support-is-coming-to-an-end-heres-how-to-prepare

> Should we drop it for DTS?

I'm in favor of removing unsupported distros from the CI.
The lack of security updates could be a reason.

> 
> Asking because the recent patch to handle shadow warnings doesn't work on
> compilers like Gcc 9.4 which don't know what -Wshadow is.

Our current minimum GCC compiler requirement is version 8.0:
https://git.dpdk.org/dpdk/tree/doc/guides/linux_gsg/sys_reqs.rst#n32

Which GCC version is required to support -Wshadow, and which GCC versions are included in relevant distros?

Maybe the -Wshadow can be added conditionally, depending on compiler version.
Shadow variables will not be caught locally, if using an old compiler version. But the CI will catch them in the tests running on recent compiler versions.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Ubuntu 20.04 EOL
  2025-08-28  6:50 ` Morten Brørup
@ 2025-08-28 14:49   ` Stephen Hemminger
  0 siblings, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2025-08-28 14:49 UTC (permalink / raw)
  To: Morten Brørup; +Cc: dev

On Thu, 28 Aug 2025 08:50:23 +0200
Morten Brørup <mb@smartsharesystems.com> wrote:

> > 
> > Asking because the recent patch to handle shadow warnings doesn't work on
> > compilers like Gcc 9.4 which don't know what -Wshadow is.  
> 
> Our current minimum GCC compiler requirement is version 8.0:
> https://git.dpdk.org/dpdk/tree/doc/guides/linux_gsg/sys_reqs.rst#n32
> 
> Which GCC version is required to support -Wshadow, and which GCC versions are included in relevant distros?
> 
> Maybe the -Wshadow can be added conditionally, depending on compiler version.
> Shadow variables will not be caught locally, if using an old compiler version. But the CI will catch them in the tests running on recent compiler versions.
> 


Meson handles that part fine. It is the Pragma logic that seems to confuse.
Working on doing it without pragma

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-08-28 14:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-28  4:34 Ubuntu 20.04 EOL Stephen Hemminger
2025-08-28  6:44 ` Morten Brørup
2025-08-28  6:50 ` Morten Brørup
2025-08-28 14:49   ` Stephen Hemminger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).