* [PATCH] examples/fips_validation: fix dangling pointer for SHA test
@ 2025-08-28 9:28 Emma Finn
2025-08-28 9:42 ` [EXTERNAL] " Gowrishankar Muthukrishnan
0 siblings, 1 reply; 2+ messages in thread
From: Emma Finn @ 2025-08-28 9:28 UTC (permalink / raw)
To: Gowrishankar Muthukrishnan; +Cc: dev, kai.ji, Emma Finn
Set vector pointer to NULL after free to avoid calling rte_free()
on the same pointer twice in some cases.
Signed-off-by: Emma Finn <emma.finn@intel.com>
---
examples/fips_validation/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c
index f21826e9d7..60ee9f8dd4 100644
--- a/examples/fips_validation/main.c
+++ b/examples/fips_validation/main.c
@@ -2612,7 +2612,7 @@ fips_mct_sha_test(void)
rte_free(md[i].val);
rte_free(vec.pt.val);
-
+ vec.pt.val = NULL;
rte_free(val.val);
return 0;
}
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [EXTERNAL] [PATCH] examples/fips_validation: fix dangling pointer for SHA test
2025-08-28 9:28 [PATCH] examples/fips_validation: fix dangling pointer for SHA test Emma Finn
@ 2025-08-28 9:42 ` Gowrishankar Muthukrishnan
0 siblings, 0 replies; 2+ messages in thread
From: Gowrishankar Muthukrishnan @ 2025-08-28 9:42 UTC (permalink / raw)
To: Emma Finn; +Cc: dev, kai.ji
> Set vector pointer to NULL after free to avoid calling rte_free() on the same
> pointer twice in some cases.
>
> Signed-off-by: Emma Finn <emma.finn@intel.com>
> ---
> examples/fips_validation/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c
> index f21826e9d7..60ee9f8dd4 100644
> --- a/examples/fips_validation/main.c
> +++ b/examples/fips_validation/main.c
> @@ -2612,7 +2612,7 @@ fips_mct_sha_test(void)
> rte_free(md[i].val);
>
> rte_free(vec.pt.val);
> -
> + vec.pt.val = NULL;
Same could be the case for fips_mct_shake_test also.
Thanks,
Gowrishankar
> rte_free(val.val);
> return 0;
> }
> --
> 2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-28 9:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-28 9:28 [PATCH] examples/fips_validation: fix dangling pointer for SHA test Emma Finn
2025-08-28 9:42 ` [EXTERNAL] " Gowrishankar Muthukrishnan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).