From: Ciara Loftus <ciara.loftus@intel.com>
To: dev@dpdk.org
Cc: Ciara Loftus <ciara.loftus@intel.com>
Subject: [PATCH v2 1/4] net/i40e: fix supported offloads for Rx vector path
Date: Tue, 2 Sep 2025 10:48:56 +0000 [thread overview]
Message-ID: <20250902104859.2100141-2-ciara.loftus@intel.com> (raw)
In-Reply-To: <20250902104859.2100141-1-ciara.loftus@intel.com>
The set of supported Rx offloads in the vector path had been defined as
those supported by the scalar path. This was incorrect so define a new
list of supported offloads for the vector path. The list is the same
as the scalar path except it excludes vlan extend and qinq strip.
Also, remove a redundant check for the VLAN Extend offload in the
driver code. This check is now performed in the common rx path
selection code.
Fixes: 052ae311091c ("net/i40e: use the common Rx path selection infrastructure")
Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
drivers/net/intel/i40e/i40e_rxtx.h | 11 ++++++++++-
drivers/net/intel/i40e/i40e_rxtx_vec_common.h | 6 ------
2 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/net/intel/i40e/i40e_rxtx.h b/drivers/net/intel/i40e/i40e_rxtx.h
index 5d5d4e08b0..1f210dfdff 100644
--- a/drivers/net/intel/i40e/i40e_rxtx.h
+++ b/drivers/net/intel/i40e/i40e_rxtx.h
@@ -80,7 +80,16 @@ enum i40e_header_split_mode {
RTE_ETH_RX_OFFLOAD_VLAN_FILTER | \
RTE_ETH_RX_OFFLOAD_RSS_HASH)
-#define I40E_RX_VECTOR_OFFLOADS I40E_RX_SCALAR_OFFLOADS
+#define I40E_RX_VECTOR_OFFLOADS ( \
+ RTE_ETH_RX_OFFLOAD_VLAN_STRIP | \
+ RTE_ETH_RX_OFFLOAD_IPV4_CKSUM | \
+ RTE_ETH_RX_OFFLOAD_UDP_CKSUM | \
+ RTE_ETH_RX_OFFLOAD_TCP_CKSUM | \
+ RTE_ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM | \
+ RTE_ETH_RX_OFFLOAD_KEEP_CRC | \
+ RTE_ETH_RX_OFFLOAD_SCATTER | \
+ RTE_ETH_RX_OFFLOAD_VLAN_FILTER | \
+ RTE_ETH_RX_OFFLOAD_RSS_HASH)
/** Offload features */
union i40e_tx_offload {
diff --git a/drivers/net/intel/i40e/i40e_rxtx_vec_common.h b/drivers/net/intel/i40e/i40e_rxtx_vec_common.h
index e118df9ce0..39c9d2ee10 100644
--- a/drivers/net/intel/i40e/i40e_rxtx_vec_common.h
+++ b/drivers/net/intel/i40e/i40e_rxtx_vec_common.h
@@ -54,12 +54,6 @@ static inline int
i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev)
{
#ifndef RTE_LIBRTE_IEEE1588
- struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;
-
- /* no QinQ support */
- if (rxmode->offloads & RTE_ETH_RX_OFFLOAD_VLAN_EXTEND)
- return -1;
-
/**
* Vector mode is allowed only when number of Rx queue
* descriptor is power of 2.
--
2.34.1
next prev parent reply other threads:[~2025-09-02 10:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 9:59 [PATCH] " Ciara Loftus
2025-09-02 8:08 ` David Marchand
2025-09-02 10:24 ` Loftus, Ciara
2025-09-02 10:48 ` [PATCH v2 0/4] Fixes for net/intel Rx Path Selection Ciara Loftus
2025-09-02 10:48 ` Ciara Loftus [this message]
2025-09-02 10:48 ` [PATCH v2 2/4] net/i40e: fix vector Rx queue set up logic Ciara Loftus
2025-09-02 10:48 ` [PATCH v2 3/4] net/i40e: remove redundant vector Rx queue setup code Ciara Loftus
2025-09-02 10:48 ` [PATCH v2 4/4] net/iavf: remove duplicate in scalar offload list Ciara Loftus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250902104859.2100141-2-ciara.loftus@intel.com \
--to=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).