DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ciara Loftus <ciara.loftus@intel.com>
To: dev@dpdk.org
Cc: Ciara Loftus <ciara.loftus@intel.com>
Subject: [PATCH v2 2/4] net/i40e: fix vector Rx queue set up logic
Date: Tue,  2 Sep 2025 10:48:57 +0000	[thread overview]
Message-ID: <20250902104859.2100141-3-ciara.loftus@intel.com> (raw)
In-Reply-To: <20250902104859.2100141-1-ciara.loftus@intel.com>

The logic to set up a vector Rx queue was present in two places, before
and after the Rx path was selected. In some cases, the rx queue would
have been set up for vector Rx twice. Another scenario could occur where
first the queue was set up for vector rx, then the scalar path selected
but the vector rx setup would still persist. This of course would be
incorrect behaviour, so it has been fixed by removing the setup logic
that was before the path select code.

Fixes: 052ae311091c ("net/i40e: use the common Rx path selection infrastructure")

Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
 drivers/net/intel/i40e/i40e_rxtx.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/net/intel/i40e/i40e_rxtx.c b/drivers/net/intel/i40e/i40e_rxtx.c
index 4c0d12c179..434959e1c0 100644
--- a/drivers/net/intel/i40e/i40e_rxtx.c
+++ b/drivers/net/intel/i40e/i40e_rxtx.c
@@ -3356,17 +3356,6 @@ i40e_set_rx_function(struct rte_eth_dev *dev)
 
 		rx_simd_width = RTE_VECT_SIMD_DISABLED;
 	}
-	if (rx_simd_width != RTE_VECT_SIMD_DISABLED) {
-		for (i = 0; i < dev->data->nb_rx_queues; i++) {
-			struct ci_rx_queue *rxq =
-				dev->data->rx_queues[i];
-
-			if (rxq && i40e_rxq_vec_setup(rxq)) {
-				rx_simd_width = RTE_VECT_SIMD_DISABLED;
-				break;
-			}
-		}
-	}
 
 	req_features.simd_width = rx_simd_width;
 	if (dev->data->scattered_rx)
-- 
2.34.1


  parent reply	other threads:[~2025-09-02 10:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-01  9:59 [PATCH] net/i40e: fix supported offloads for Rx vector path Ciara Loftus
2025-09-02  8:08 ` David Marchand
2025-09-02 10:24   ` Loftus, Ciara
2025-09-02 10:48 ` [PATCH v2 0/4] Fixes for net/intel Rx Path Selection Ciara Loftus
2025-09-02 10:48   ` [PATCH v2 1/4] net/i40e: fix supported offloads for Rx vector path Ciara Loftus
2025-09-02 10:48   ` Ciara Loftus [this message]
2025-09-02 10:48   ` [PATCH v2 3/4] net/i40e: remove redundant vector Rx queue setup code Ciara Loftus
2025-09-02 10:48   ` [PATCH v2 4/4] net/iavf: remove duplicate in scalar offload list Ciara Loftus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250902104859.2100141-3-ciara.loftus@intel.com \
    --to=ciara.loftus@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).