DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ciara Loftus <ciara.loftus@intel.com>
To: dev@dpdk.org
Cc: Ciara Loftus <ciara.loftus@intel.com>
Subject: [PATCH 1/3] net/iavf: fix Tx vector path selection logic again
Date: Thu,  4 Sep 2025 10:44:38 +0000	[thread overview]
Message-ID: <20250904104440.2167205-2-ciara.loftus@intel.com> (raw)
In-Reply-To: <20250904104440.2167205-1-ciara.loftus@intel.com>

Commit b39aeea703b8 ("net/iavf: fix Tx vector path selection logic")
fixed an issue which caused the scalar path to be chosen even when the
AVX-512 path could have been a viable candidate. The commit
be1a887b83cd ("net/iavf: use the new common vector capability function")
accidentally undid this fix, so this commit fixes this again, this time
in a new way due to the changed code landscape since the last fix.

Fixes: be1a887b83cd ("net/iavf: use the new common vector capability function")

Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
 drivers/net/intel/iavf/iavf_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/intel/iavf/iavf_rxtx.c b/drivers/net/intel/iavf/iavf_rxtx.c
index ab44558a85..ce0a12c348 100644
--- a/drivers/net/intel/iavf/iavf_rxtx.c
+++ b/drivers/net/intel/iavf/iavf_rxtx.c
@@ -4090,7 +4090,7 @@ iavf_set_tx_function(struct rte_eth_dev *dev)
 				    dev->data->port_id);
 			tx_func_type = IAVF_TX_SSE;
 		}
-		if (use_avx2) {
+		if (!use_avx512 && use_avx2) {
 			if (check_ret == IAVF_VECTOR_PATH) {
 				tx_func_type = IAVF_TX_AVX2;
 				PMD_DRV_LOG(DEBUG, "Using AVX2 Vector Tx (port %d).",
-- 
2.34.1


  reply	other threads:[~2025-09-04 10:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-04 10:44 [PATCH 0/3] Fixes for iavf Tx path selection Ciara Loftus
2025-09-04 10:44 ` Ciara Loftus [this message]
2025-09-04 16:59   ` [PATCH 1/3] net/iavf: fix Tx vector path selection logic again Bruce Richardson
2025-09-04 10:44 ` [PATCH 2/3] net/iavf: fix a log during Tx path selection Ciara Loftus
2025-09-04 17:00   ` Bruce Richardson
2025-09-04 10:44 ` [PATCH 3/3] net/iavf: fix Tx path selection for VLAN offload Ciara Loftus
2025-09-04 17:10   ` Bruce Richardson
2025-09-04 17:18 ` [PATCH 0/3] Fixes for iavf Tx path selection Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250904104440.2167205-2-ciara.loftus@intel.com \
    --to=ciara.loftus@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).