DPDK patches and discussions
 help / color / mirror / Atom feed
From: luca.boccassi@gmail.com
To: dev@dpdk.org
Subject: [PATCH v2] net/zxdh: fix building check for arm64
Date: Thu,  4 Sep 2025 15:18:36 +0100	[thread overview]
Message-ID: <20250904141854.55944-1-luca.boccassi@gmail.com> (raw)
In-Reply-To: <20250904141059.54626-1-luca.boccassi@gmail.com>

From: Luca Boccassi <luca.boccassi@gmail.com>

The comment and docs say this should be built on x86_64 and aarch64,
but RTE_ARCH_64 is not aarch64, that's RTE_ARCH_ARM64, so fix it.

Also the check makes the build skip unless RTE_ARCH_X86_64 is true,
so switch it to an 'and' instead of an 'or', to build on both arm64
and x86_64, and skip elsewhere.

Fixes: 29e89288ff14 ("net/zxdh: add driver skeleton")
Cc: stable@dpdk.org

Signed-off-by: Luca Boccassi <luca.boccassi@gmail.com>
---
v2: use dpdk_conf.has() instead of .get()

 drivers/net/zxdh/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/zxdh/meson.build b/drivers/net/zxdh/meson.build
index a48a0d43c2..5e1bc42b28 100644
--- a/drivers/net/zxdh/meson.build
+++ b/drivers/net/zxdh/meson.build
@@ -7,7 +7,7 @@ if not is_linux
     subdir_done()
 endif
 
-if not dpdk_conf.has('RTE_ARCH_X86_64') or not dpdk_conf.get('RTE_ARCH_64')
+if not dpdk_conf.has('RTE_ARCH_X86_64') and not dpdk_conf.has('RTE_ARCH_ARM64')
     build = false
     reason = 'only supported on x86_64 and aarch64'
     subdir_done()
-- 
2.47.3


  reply	other threads:[~2025-09-04 14:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-04 14:10 [PATCH] " luca.boccassi
2025-09-04 14:18 ` luca.boccassi [this message]
2025-09-04 14:54   ` [PATCH v2] " David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250904141854.55944-1-luca.boccassi@gmail.com \
    --to=luca.boccassi@gmail.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).