From: Stephen Hemminger <stephen@networkplumber.org>
To: luca.boccassi@gmail.com
Cc: dev@dpdk.org
Subject: Re: [PATCH] net/zxdh: fix building check for arm64
Date: Sat, 6 Sep 2025 10:37:06 -0700 [thread overview]
Message-ID: <20250906103706.6c68b63c@hermes.local> (raw)
In-Reply-To: <20250904141059.54626-1-luca.boccassi@gmail.com>
On Thu, 4 Sep 2025 15:10:44 +0100
luca.boccassi@gmail.com wrote:
> From: Luca Boccassi <luca.boccassi@gmail.com>
>
> The comment and docs say this should be built on x86_64 and aarch64,
> but RTE_ARCH_64 is not aarch64, that's RTE_ARCH_ARM64, so fix it.
>
> Also the check makes the build skip unless RTE_ARCH_X86_64 is true,
> so switch it to an 'and' instead of an 'or', to build on both arm64
> and x86_64, and skip elsewhere.
>
> Fixes: 29e89288ff14 ("net/zxdh: add driver skeleton")
> Cc: stable@dpdk.org
>
> Signed-off-by: Luca Boccassi <luca.boccassi@gmail.com>
There already was a patch submitted and queued in next-net.
Your version is more succinct, it would be better to have one way of doing this
for all drivers.
commit 4916569f552ee881adbd54bf5446f1c06a607289
Author: Junlong Wang <wang.junlong1@zte.com.cn>
Date: Thu Jul 10 18:56:38 2025 +0800
net/zxdh: fix meson.build issues in compilation
fix meson.build issues in compilation, which
caused the inability to compile in the arm64 environment.
Fixes: 29e89288ff14 ("net/zxdh: add driver skeleton")
Cc: stable@dpdk.org
Signed-off-by: Junlong Wang <wang.junlong1@zte.com.cn>
prev parent reply other threads:[~2025-09-06 17:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 14:10 luca.boccassi
2025-09-04 14:18 ` [PATCH v2] " luca.boccassi
2025-09-04 14:54 ` David Marchand
2025-09-06 17:37 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250906103706.6c68b63c@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=luca.boccassi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).