DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Ed Czeck <ed.czeck@atomicrules.com>
Cc: dev@dpdk.org, Shepard Siegel <shepard.siegel@atomicrules.com>,
	John Miller <john.miller@atomicrules.com>
Subject: Re: [PATCH 4/4] net/ark: improve Rx queue recovery after mbuf exhaustion
Date: Tue, 9 Sep 2025 17:33:16 -0700	[thread overview]
Message-ID: <20250909173316.4105b0d6@hermes.local> (raw)
In-Reply-To: <20250903212846.268492-4-ed.czeck@atomicrules.com>

On Wed,  3 Sep 2025 17:28:45 -0400
Ed Czeck <ed.czeck@atomicrules.com> wrote:

> @@ -185,12 +184,12 @@ eth_ark_dev_rx_queue_setup(struct rte_eth_dev *dev,
>  	queue->reserve_q =
>  		rte_zmalloc_socket("Ark_rx_queue mbuf",
>  				   nb_desc * sizeof(struct rte_mbuf *),
> -				   512,
> +				   4096,
>  				   socket_id);
>  	queue->paddress_q =
>  		rte_zmalloc_socket("Ark_rx_queue paddr",
>  				   nb_desc * sizeof(rte_iova_t),
> -				   512,
> +				   4096,
>  				   socket_id);
>  

Not all ARM systems use page size of 4096. Some are larger.
The parameter changed is the alignment value, not the size.
The allocation is taking place on huge pages where the page size
is typically 2 Megabytes or larger. Why is this doing anything useful?

  parent reply	other threads:[~2025-09-10  0:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-03 21:28 [PATCH 1/4] net/ark: add PCIe IDS for newly supported devices Ed Czeck
2025-09-03 21:28 ` [PATCH 2/4] net/ark: remove double mbuf frees Ed Czeck
2025-09-03 21:28 ` [PATCH 3/4] net/ark: improve ring handling for segmented packets Ed Czeck
2025-09-03 21:28 ` [PATCH 4/4] net/ark: improve Rx queue recovery after mbuf exhaustion Ed Czeck
2025-09-06  4:51   ` Stephen Hemminger
2025-09-10  0:33   ` Stephen Hemminger [this message]
2025-09-10  0:33   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250909173316.4105b0d6@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=ed.czeck@atomicrules.com \
    --cc=john.miller@atomicrules.com \
    --cc=shepard.siegel@atomicrules.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).