From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] app/testpmd: enable warnings for possibly invalid config
Date: Mon, 15 Sep 2025 10:53:08 -0700 [thread overview]
Message-ID: <20250915105308.46c31d44@hermes.local> (raw)
In-Reply-To: <20250912160210.388290-1-bruce.richardson@intel.com>
On Fri, 12 Sep 2025 17:02:10 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:
> When dealing with multi-segment packets, there are separate offload
> flags which should be enabled on Rx (scattered flag) and on Tx
> (multi-segment flag). Print warnings on testpmd startup if we detect a
> situation where we suspect the user is missing these flags, e.g. we
> allow scattered packets on Rx, but not on Tx.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Should also check for RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT which should require
multiple segment support.
Could testpmd also check the descriptor limits of the device?
Does it validate nb_seg_max for TSO, and nb_mtu_seg_max for all cases?
next prev parent reply other threads:[~2025-09-15 17:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 16:02 Bruce Richardson
2025-09-15 17:53 ` Stephen Hemminger [this message]
2025-09-16 7:47 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915105308.46c31d44@hermes.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).