[PATCH] build: remove deprecated kmods option

[PATCH] build: remove deprecated kmods option

[Bruce Richardson]

The "enable_kmods" meson option was deprecated back in 2023[1], so can
now be removed from DPDK.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

[1] https://doc.dpdk.org/guides-23.11/rel_notes/deprecation.html
---
 doc/guides/rel_notes/deprecation.rst | 7 -------
 meson_options.txt                    | 2 --
 2 files changed, 9 deletions(-)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 0fcdd02d3c..483030cda8 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -17,13 +17,6 @@ Other API and ABI deprecation notices are to be posted below.
 Deprecation Notices
 -------------------
 
-* build: The ``enable_kmods`` option is deprecated and will be removed in a future release.
-  Setting/clearing the option has no impact on the build.
-  Instead, kernel modules will be always built for OS's where out-of-tree kernel modules
-  are required for DPDK operation.
-  Currently, this means that modules will only be built for FreeBSD.
-  No modules are shipped with DPDK for either Linux or Windows.
-
 * kvargs: The function ``rte_kvargs_process`` will get a new parameter
   for returning key match count. It will ease handling of no-match case.
 
diff --git a/meson_options.txt b/meson_options.txt
index e49b2fc089..e28d24054c 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -24,8 +24,6 @@ option('enable_drivers', type: 'string', value: '', description:
        'Comma-separated list of drivers to build. If unspecified, build all drivers.')
 option('enable_driver_sdk', type: 'boolean', value: false, description:
        'Install headers to build drivers.')
-option('enable_kmods', type: 'boolean', value: true, description:
-       '[Deprecated - will be removed in future release] build kernel modules')
 option('enable_libs', type: 'string', value: '', description:
        'Comma-separated list of optional libraries to explicitly enable. [NOTE: mandatory libs are always enabled]')
 option('examples', type: 'string', value: '', description:
-- 
2.48.1

Re: [PATCH] build: remove deprecated kmods option

[Bruce Richardson]

On Fri, Sep 19, 2025 at 08:57:33AM +0100, Bruce Richardson wrote:
> The "enable_kmods" meson option was deprecated back in 2023[1], so can
> now be removed from DPDK.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> [1] https://doc.dpdk.org/guides-23.11/rel_notes/deprecation.html
> ---
>  doc/guides/rel_notes/deprecation.rst | 7 -------
>  meson_options.txt                    | 2 --
>  2 files changed, 9 deletions(-)
> 
Self-NAK. Missed some cleanup on this. Will do a V2.

[PATCH v2] build: remove deprecated kmods option

[Bruce Richardson]

The "enable_kmods" meson option was deprecated back in 2023[1], so can
now be removed from DPDK.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

[1] https://doc.dpdk.org/guides-23.11/rel_notes/deprecation.html

---
v2: remove missed references in DTS and in freebsd meson.build
---
 doc/guides/rel_notes/deprecation.rst | 7 -------
 dts/framework/remote_session/dpdk.py | 2 +-
 dts/framework/utils.py               | 2 +-
 kernel/freebsd/meson.build           | 4 ++--
 meson_options.txt                    | 2 --
 5 files changed, 4 insertions(+), 13 deletions(-)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 5aaeb1052a..bdcd2775b6 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -17,13 +17,6 @@ Other API and ABI deprecation notices are to be posted below.
 Deprecation Notices
 -------------------
 
-* build: The ``enable_kmods`` option is deprecated and will be removed in a future release.
-  Setting/clearing the option has no impact on the build.
-  Instead, kernel modules will be always built for OS's where out-of-tree kernel modules
-  are required for DPDK operation.
-  Currently, this means that modules will only be built for FreeBSD.
-  No modules are shipped with DPDK for either Linux or Windows.
-
 * kvargs: The function ``rte_kvargs_process`` will get a new parameter
   for returning key match count. It will ease handling of no-match case.
 
diff --git a/dts/framework/remote_session/dpdk.py b/dts/framework/remote_session/dpdk.py
index 606d6e22fe..2dc8dab642 100644
--- a/dts/framework/remote_session/dpdk.py
+++ b/dts/framework/remote_session/dpdk.py
@@ -262,7 +262,7 @@ def _build_dpdk(self) -> None:
         """
         self._session.build_dpdk(
             self._env_vars,
-            MesonArgs(default_library="static", enable_kmods=True, libdir="lib"),
+            MesonArgs(default_library="static", libdir="lib"),
             self.remote_dpdk_tree_path,
             self.remote_dpdk_build_dir,
         )
diff --git a/dts/framework/utils.py b/dts/framework/utils.py
index 0c81ab1b95..9f7201c888 100644
--- a/dts/framework/utils.py
+++ b/dts/framework/utils.py
@@ -111,7 +111,7 @@ def __init__(self, default_library: str | None = None, **dpdk_args: str | bool):
         Example:
             ::
 
-                meson_args = MesonArgs(enable_kmods=True).
+                meson_args = MesonArgs(check_includes=True).
         """
         self._default_library = f"--default-library={default_library}" if default_library else ""
         self._dpdk_args = " ".join(
diff --git a/kernel/freebsd/meson.build b/kernel/freebsd/meson.build
index 1f612711be..862e19e766 100644
--- a/kernel/freebsd/meson.build
+++ b/kernel/freebsd/meson.build
@@ -29,7 +29,7 @@ foreach k:kmods
                 'KMOD_CFLAGS=' + ' '.join(kmod_cflags),
                 'CC=clang'],
             depends: built_kmods, # make each module depend on prev
-            build_by_default: get_option('enable_kmods'),
-            install: get_option('enable_kmods'),
+            build_by_default: true,
+            install: true,
             install_dir: '/boot/modules/')
 endforeach
diff --git a/meson_options.txt b/meson_options.txt
index e49b2fc089..e28d24054c 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -24,8 +24,6 @@ option('enable_drivers', type: 'string', value: '', description:
        'Comma-separated list of drivers to build. If unspecified, build all drivers.')
 option('enable_driver_sdk', type: 'boolean', value: false, description:
        'Install headers to build drivers.')
-option('enable_kmods', type: 'boolean', value: true, description:
-       '[Deprecated - will be removed in future release] build kernel modules')
 option('enable_libs', type: 'string', value: '', description:
        'Comma-separated list of optional libraries to explicitly enable. [NOTE: mandatory libs are always enabled]')
 option('examples', type: 'string', value: '', description:
-- 
2.48.1

Re: [PATCH v2] build: remove deprecated kmods option

[David Marchand]

On Fri, 19 Sept 2025 at 10:45, Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> The "enable_kmods" meson option was deprecated back in 2023[1], so can
> now be removed from DPDK.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

We are missing a release note entry, but otherwise lgtm.
You can add:
Acked-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand

[PATCH v3] build: remove deprecated kmods option

[Bruce Richardson]

The "enable_kmods" meson option was deprecated back in 2023[1], so can
now be removed from DPDK.

[1] https://doc.dpdk.org/guides-23.11/rel_notes/deprecation.html

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: David Marchand <david.marchand@redhat.com>

---
v3: add release note update.
v2: remove missed references in DTS and in freebsd meson.build
---
 doc/guides/rel_notes/deprecation.rst   | 7 -------
 doc/guides/rel_notes/release_25_11.rst | 7 +++++++
 dts/framework/remote_session/dpdk.py   | 2 +-
 dts/framework/utils.py                 | 2 +-
 kernel/freebsd/meson.build             | 4 ++--
 meson_options.txt                      | 2 --
 6 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 5aaeb1052a..bdcd2775b6 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -17,13 +17,6 @@ Other API and ABI deprecation notices are to be posted below.
 Deprecation Notices
 -------------------
 
-* build: The ``enable_kmods`` option is deprecated and will be removed in a future release.
-  Setting/clearing the option has no impact on the build.
-  Instead, kernel modules will be always built for OS's where out-of-tree kernel modules
-  are required for DPDK operation.
-  Currently, this means that modules will only be built for FreeBSD.
-  No modules are shipped with DPDK for either Linux or Windows.
-
 * kvargs: The function ``rte_kvargs_process`` will get a new parameter
   for returning key match count. It will ease handling of no-match case.
 
diff --git a/doc/guides/rel_notes/release_25_11.rst b/doc/guides/rel_notes/release_25_11.rst
index efb88bbbb0..bce8e9f563 100644
--- a/doc/guides/rel_notes/release_25_11.rst
+++ b/doc/guides/rel_notes/release_25_11.rst
@@ -89,6 +89,13 @@ Removed Items
    Also, make sure to start the actual text at the margin.
    =======================================================
 
+* build: as previously announced in the deprecation notices,
+  the ``enable_kmods`` build option has been removed.
+  Kernel modules will now automatically be built for OS's where out-of-tree kernel modules
+  are required for DPDK operation.
+  Currently, this means that modules will only be built for FreeBSD.
+  No modules are shipped with DPDK for either Linux or Windows.
+
 
 API Changes
 -----------
diff --git a/dts/framework/remote_session/dpdk.py b/dts/framework/remote_session/dpdk.py
index 606d6e22fe..2dc8dab642 100644
--- a/dts/framework/remote_session/dpdk.py
+++ b/dts/framework/remote_session/dpdk.py
@@ -262,7 +262,7 @@ def _build_dpdk(self) -> None:
         """
         self._session.build_dpdk(
             self._env_vars,
-            MesonArgs(default_library="static", enable_kmods=True, libdir="lib"),
+            MesonArgs(default_library="static", libdir="lib"),
             self.remote_dpdk_tree_path,
             self.remote_dpdk_build_dir,
         )
diff --git a/dts/framework/utils.py b/dts/framework/utils.py
index 0c81ab1b95..9f7201c888 100644
--- a/dts/framework/utils.py
+++ b/dts/framework/utils.py
@@ -111,7 +111,7 @@ def __init__(self, default_library: str | None = None, **dpdk_args: str | bool):
         Example:
             ::
 
-                meson_args = MesonArgs(enable_kmods=True).
+                meson_args = MesonArgs(check_includes=True).
         """
         self._default_library = f"--default-library={default_library}" if default_library else ""
         self._dpdk_args = " ".join(
diff --git a/kernel/freebsd/meson.build b/kernel/freebsd/meson.build
index 1f612711be..862e19e766 100644
--- a/kernel/freebsd/meson.build
+++ b/kernel/freebsd/meson.build
@@ -29,7 +29,7 @@ foreach k:kmods
                 'KMOD_CFLAGS=' + ' '.join(kmod_cflags),
                 'CC=clang'],
             depends: built_kmods, # make each module depend on prev
-            build_by_default: get_option('enable_kmods'),
-            install: get_option('enable_kmods'),
+            build_by_default: true,
+            install: true,
             install_dir: '/boot/modules/')
 endforeach
diff --git a/meson_options.txt b/meson_options.txt
index e49b2fc089..e28d24054c 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -24,8 +24,6 @@ option('enable_drivers', type: 'string', value: '', description:
        'Comma-separated list of drivers to build. If unspecified, build all drivers.')
 option('enable_driver_sdk', type: 'boolean', value: false, description:
        'Install headers to build drivers.')
-option('enable_kmods', type: 'boolean', value: true, description:
-       '[Deprecated - will be removed in future release] build kernel modules')
 option('enable_libs', type: 'string', value: '', description:
        'Comma-separated list of optional libraries to explicitly enable. [NOTE: mandatory libs are always enabled]')
 option('examples', type: 'string', value: '', description:
-- 
2.48.1

Re: [PATCH v3] build: remove deprecated kmods option

[David Marchand]

On Tue, 23 Sept 2025 at 16:40, Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> The "enable_kmods" meson option was deprecated back in 2023[1], so can
> now be removed from DPDK.
>
> [1] https://doc.dpdk.org/guides-23.11/rel_notes/deprecation.html
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: David Marchand <david.marchand@redhat.com>

I see errors coming from Intel CI that requests enable_kmod option.
It needs to be fixed on Intel side so we can merge this series.


-- 
David Marchand

Re: [PATCH v3] build: remove deprecated kmods option

[Bruce Richardson]

On Wed, Sep 24, 2025 at 05:45:38PM +0200, David Marchand wrote:
> On Tue, 23 Sept 2025 at 16:40, Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > The "enable_kmods" meson option was deprecated back in 2023[1], so can
> > now be removed from DPDK.
> >
> > [1] https://doc.dpdk.org/guides-23.11/rel_notes/deprecation.html
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > Acked-by: David Marchand <david.marchand@redhat.com>
> 
> I see errors coming from Intel CI that requests enable_kmod option.
> It needs to be fixed on Intel side so we can merge this series.
> 
Yes. I've sent off a couple of hours ago a request to have that fixed in
our CI. I'll let you know when I hear back.

/Bruce

Re: [PATCH v3] build: remove deprecated kmods option

[Bruce Richardson]

On Wed, Sep 24, 2025 at 04:50:40PM +0100, Bruce Richardson wrote:
> On Wed, Sep 24, 2025 at 05:45:38PM +0200, David Marchand wrote:
> > On Tue, 23 Sept 2025 at 16:40, Bruce Richardson
> > <bruce.richardson@intel.com> wrote:
> > >
> > > The "enable_kmods" meson option was deprecated back in 2023[1], so can
> > > now be removed from DPDK.
> > >
> > > [1] https://doc.dpdk.org/guides-23.11/rel_notes/deprecation.html
> > >
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > > Acked-by: David Marchand <david.marchand@redhat.com>
> > 
> > I see errors coming from Intel CI that requests enable_kmod option.
> > It needs to be fixed on Intel side so we can merge this series.
> > 
> Yes. I've sent off a couple of hours ago a request to have that fixed in
> our CI. I'll let you know when I hear back.
> 
> /Bruce

This has now been done, I'm told.

https://mails.dpdk.org/archives/test-report/2025-September/911620.html

/Bruce

Re: [PATCH v3] build: remove deprecated kmods option

[David Marchand]

On Thu, 25 Sept 2025 at 10:42, Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Wed, Sep 24, 2025 at 04:50:40PM +0100, Bruce Richardson wrote:
> > On Wed, Sep 24, 2025 at 05:45:38PM +0200, David Marchand wrote:
> > > On Tue, 23 Sept 2025 at 16:40, Bruce Richardson
> > > <bruce.richardson@intel.com> wrote:
> > > >
> > > > The "enable_kmods" meson option was deprecated back in 2023[1], so can
> > > > now be removed from DPDK.
> > > >
> > > > [1] https://doc.dpdk.org/guides-23.11/rel_notes/deprecation.html
> > > >
> > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > > > Acked-by: David Marchand <david.marchand@redhat.com>
> > >
> > > I see errors coming from Intel CI that requests enable_kmod option.
> > > It needs to be fixed on Intel side so we can merge this series.
> > >
> > Yes. I've sent off a couple of hours ago a request to have that fixed in
> > our CI. I'll let you know when I hear back.
> >
> > /Bruce
>
> This has now been done, I'm told.
>
> https://mails.dpdk.org/archives/test-report/2025-September/911620.html

Then here we go.


-- 
David Marchand

Re: [PATCH v3] build: remove deprecated kmods option

[David Marchand]

On Tue, 23 Sept 2025 at 16:40, Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> The "enable_kmods" meson option was deprecated back in 2023[1], so can
> now be removed from DPDK.
>
> [1] https://doc.dpdk.org/guides-23.11/rel_notes/deprecation.html
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: David Marchand <david.marchand@redhat.com>

Applied, thanks.


-- 
David Marchand