DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com, stable@dpdk.org,
	Byron Marohn <byron.marohn@intel.com>,
	Yipeng Wang <yipeng1.wang@intel.com>,
	Keith Wiles <keith.wiles@intel.com>,
	Harry van Haaren <harry.van.haaren@intel.com>,
	Luca Boccassi <luca.boccassi@microsoft.com>,
	Sean Morrissey <sean.morrissey@intel.com>
Subject: [PATCH v3 1/2] efd: fix AVX2 support
Date: Wed, 24 Sep 2025 17:43:17 +0200	[thread overview]
Message-ID: <20250924154641.2684705-2-thomas@monjalon.net> (raw)
In-Reply-To: <20250924154641.2684705-1-thomas@monjalon.net>

When switching to Meson build, the compilation check on CC_SUPPORT_AVX2
became obsolete, thus the case EFD_LOOKUP_AVX2 became dead.
The function efd_lookup_internal_avx2() was never called,
and its header include rte_efd_x86.h has been removed later.

EFD_LOOKUP_AVX2 is chosen at runtime after checking AVX2 availability,
so the obsolete build-time check for AVX2 can be simply removed,
and the missing include added back.

Fixes: 5b9656b157d3 ("lib: build with meson")
Fixes: 30a1de105a5f ("lib: remove unneeded header includes")
Cc: stable@dpdk.org

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 lib/efd/rte_efd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c
index b0e44e5c51..ebf1e0655f 100644
--- a/lib/efd/rte_efd.c
+++ b/lib/efd/rte_efd.c
@@ -26,6 +26,7 @@
 
 #include "rte_efd.h"
 #if defined(RTE_ARCH_X86)
+#include "rte_efd_x86.h"
 #elif defined(RTE_ARCH_ARM64)
 #include "rte_efd_arm64.h"
 #endif
@@ -1279,7 +1280,7 @@ efd_lookup_internal(const struct efd_online_group_entry * const group,
 
 	switch (lookup_fn) {
 
-#if defined(RTE_ARCH_X86) && defined(CC_SUPPORT_AVX2)
+#if defined(RTE_ARCH_X86)
 	case EFD_LOOKUP_AVX2:
 		return efd_lookup_internal_avx2(group->hash_idx,
 					group->lookup_table,
-- 
2.51.0


  reply	other threads:[~2025-09-24 15:46 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-18  7:28 [PATCH 0/3] lib: fix AVX2 checks and macro exposure Thomas Monjalon
2025-09-18  7:28 ` [PATCH 1/3] efd: fix AVX2 support Thomas Monjalon
2025-09-18  7:48   ` Bruce Richardson
2025-09-18  8:16     ` Thomas Monjalon
2025-09-18  7:28 ` [PATCH 2/3] member: remove AVX2 build-time checks Thomas Monjalon
2025-09-18  7:49   ` Bruce Richardson
2025-09-18  7:28 ` [PATCH 3/3] member: hide internal macro Thomas Monjalon
2025-09-18  7:50   ` Bruce Richardson
2025-09-18  8:10 ` [PATCH 0/3] lib: fix AVX2 checks and macro exposure Thomas Monjalon
2025-09-18  8:59   ` Bruce Richardson
2025-09-18  9:08 ` [PATCH v2 0/4] " Thomas Monjalon
2025-09-18  9:08   ` [PATCH v2 1/4] efd: fix AVX2 support Thomas Monjalon
2025-09-18  9:40     ` Thomas Monjalon
2025-09-18  9:47       ` Thomas Monjalon
2025-09-18  9:08   ` [PATCH v2 2/4] efd: remove AVX2 build-time check Thomas Monjalon
2025-09-18  9:08   ` [PATCH v2 3/4] member: remove AVX2 build-time checks Thomas Monjalon
2025-09-18  9:08   ` [PATCH v2 4/4] member: hide internal macro Thomas Monjalon
2025-09-24 15:43 ` [PATCH v3 0/2] lib: fix AVX2 checks and macro exposure Thomas Monjalon
2025-09-24 15:43   ` Thomas Monjalon [this message]
2025-09-24 15:49     ` [PATCH v3 1/2] efd: fix AVX2 support Bruce Richardson
2025-09-24 15:43   ` [PATCH v3 2/2] member: hide internal macro Thomas Monjalon
2025-09-24 16:50   ` [PATCH v3 0/2] lib: fix AVX2 checks and macro exposure Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250924154641.2684705-2-thomas@monjalon.net \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=byron.marohn@intel.com \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    --cc=keith.wiles@intel.com \
    --cc=luca.boccassi@microsoft.com \
    --cc=sean.morrissey@intel.com \
    --cc=stable@dpdk.org \
    --cc=yipeng1.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).