From: Manish Kurup <manish.kurup@broadcom.com>
To: dev@dpdk.org
Cc: ajit.khaparde@broadcom.com,
Kishore Padmanabha <kishore.padmanabha@broadcom.com>,
Shuanglin Wang <shuanglin.wang@broadcom.com>
Subject: [PATCH 23/54] net/bnxt/tf_ulp: enable support for global index table
Date: Mon, 29 Sep 2025 20:35:33 -0400 [thread overview]
Message-ID: <20250930003604.87108-24-manish.kurup@broadcom.com> (raw)
In-Reply-To: <20250930003604.87108-1-manish.kurup@broadcom.com>
From: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
The multi instance applications use metadata profile tables to set the
metadata mask and this mask needs to be shared by multiple applications.
The code is extended to support global id for these metadata profiles
that these can be shared across applications. Since there are limited
number of these resources, to scale the number of applications this
resource needs to be shared as global ids.
Signed-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
Reviewed-by: Shuanglin Wang <shuanglin.wang@broadcom.com>
---
drivers/net/bnxt/tf_ulp/ulp_mapper.c | 111 +++++++++++++++++++++++
drivers/net/bnxt/tf_ulp/ulp_mapper.h | 11 +++
drivers/net/bnxt/tf_ulp/ulp_mapper_tf.c | 2 +
drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c | 77 ++++++++++++++++
4 files changed, 201 insertions(+)
diff --git a/drivers/net/bnxt/tf_ulp/ulp_mapper.c b/drivers/net/bnxt/tf_ulp/ulp_mapper.c
index 1901845499..9cda3b355b 100644
--- a/drivers/net/bnxt/tf_ulp/ulp_mapper.c
+++ b/drivers/net/bnxt/tf_ulp/ulp_mapper.c
@@ -3129,6 +3129,110 @@ ulp_mapper_global_identifier_process(struct bnxt_ulp_mapper_parms *parms,
return rc;
}
+static int32_t
+ulp_mapper_global_idx_tbl_process(struct bnxt_ulp_mapper_parms *parms,
+ struct bnxt_ulp_mapper_tbl_info *tbl)
+{
+ const struct ulp_mapper_core_ops *op = parms->mapper_data->mapper_oper;
+ struct bnxt_ulp_glb_resource_info glb_res = { 0 };
+ struct ulp_flow_db_res_params fid_parms = { 0 };
+ struct bnxt_ulp_mapper_key_info *kflds;
+ struct ulp_blob key;
+ uint32_t num_kflds = 0;
+ uint16_t tmplen = 0;
+ uint64_t idx = 0;
+ uint8_t *context;
+ int32_t rc = 0;
+ uint32_t i;
+
+ /* check the table opcode */
+ if (tbl->tbl_opcode != BNXT_ULP_GLOBAL_IDX_TBL_OPC_ALLOC) {
+ BNXT_DRV_DBG(ERR, "Invalid global idx table opcode %d",
+ tbl->tbl_opcode);
+ return -EINVAL;
+ }
+
+ /* Create the key blob */
+ if (unlikely(ulp_blob_init(&key, tbl->blob_key_bit_size,
+ BNXT_ULP_BYTE_ORDER_BE))) {
+ BNXT_DRV_DBG(ERR, "blob init failed.");
+ return -EINVAL;
+ }
+
+ kflds = ulp_mapper_key_fields_get(parms, tbl, &num_kflds);
+ for (i = 0; i < num_kflds; i++) {
+ rc = ulp_mapper_field_opc_process(parms, tbl->direction,
+ &kflds[i].field_info_spec,
+ &key, 1,
+ "Global Idx Context");
+ if (unlikely(rc)) {
+ BNXT_DRV_DBG(ERR, "Key field set failed %s",
+ kflds[i].field_info_spec.description);
+ return rc;
+ }
+ }
+
+ context = ulp_blob_data_get(&key, &tmplen);
+ tmplen = ULP_BITS_2_BYTE(tmplen);
+
+ if (unlikely(!op->ulp_mapper_core_glb_idx_tbl_alloc)) {
+ BNXT_DRV_DBG(ERR, "global idx tbl process not supported");
+ return -EINVAL;
+ }
+
+ rc = op->ulp_mapper_core_glb_idx_tbl_alloc(parms->ulp_ctx,
+ tbl->resource_type,
+ tbl->direction, context,
+ tmplen, &idx);
+ if (unlikely(rc)) {
+ BNXT_DRV_DBG(ERR, "global idx tbl process failed");
+ return rc;
+ }
+
+ /* Add the table index to the flow db */
+ memset(&fid_parms, 0, sizeof(fid_parms));
+ fid_parms.direction = tbl->direction;
+ fid_parms.resource_func = tbl->resource_func;
+ fid_parms.resource_type = tbl->resource_type;
+ fid_parms.critical_resource = tbl->critical_resource;
+ fid_parms.resource_hndl = idx;
+
+ rc = ulp_mapper_fdb_opc_process(parms, tbl, &fid_parms);
+ if (unlikely(rc)) {
+ BNXT_DRV_DBG(ERR, "Fail to link res to flow rc = %d", rc);
+ goto error;
+ }
+
+ rc = bnxt_ulp_cntxt_dev_id_get(parms->ulp_ctx, &glb_res.device_id);
+ if (unlikely(rc)) {
+ BNXT_DRV_DBG(ERR, "Failed to get device id (%d)", rc);
+ goto error;
+ }
+
+ rc = bnxt_ulp_cntxt_app_id_get(parms->ulp_ctx, &glb_res.app_id);
+ if (unlikely(rc)) {
+ BNXT_DRV_DBG(ERR, "Failed to get app id (%d)", rc);
+ goto error;
+ }
+
+ glb_res.direction = tbl->direction;
+ glb_res.resource_func = tbl->resource_func;
+ glb_res.resource_type = tbl->resource_type;
+ glb_res.glb_regfile_index = tbl->tbl_operand;
+ /* Write the table index into the regfile*/
+ if (ulp_mapper_glb_resource_write(parms->mapper_data, &glb_res,
+ tfp_cpu_to_be_64(idx), false)) {
+ BNXT_DRV_DBG(ERR, "Glb Regfile[%d] write failed.",
+ tbl->tbl_operand);
+ rc = -EINVAL;
+ goto error;
+ }
+ return rc;
+error:
+ (void)op->ulp_mapper_core_glb_idx_tbl_free(parms->ulp_ctx, &fid_parms);
+ return rc;
+}
+
/* Free the vnic resource */
static int32_t
ulp_mapper_vnic_tbl_res_free(struct bnxt_ulp_context *ulp __rte_unused,
@@ -4357,6 +4461,9 @@ ulp_mapper_tbls_process(struct bnxt_ulp_mapper_parms *parms, void *error)
case BNXT_ULP_RESOURCE_FUNC_GLOBAL_IDENTIFIER:
rc = ulp_mapper_global_identifier_process(parms, tbl);
break;
+ case BNXT_ULP_RESOURCE_FUNC_GLOBAL_IDX_TBL:
+ rc = ulp_mapper_global_idx_tbl_process(parms, tbl);
+ break;
default:
BNXT_DRV_DBG(ERR, "Unexpected mapper resource %d\n",
tbl->resource_func);
@@ -4501,6 +4608,10 @@ ulp_mapper_resource_free(struct bnxt_ulp_context *ulp,
break;
case BNXT_ULP_RESOURCE_FUNC_GLOBAL_IDENTIFIER:
rc = mapper_op->ulp_mapper_core_global_ident_free(ulp, res);
+ break;
+ case BNXT_ULP_RESOURCE_FUNC_GLOBAL_IDX_TBL:
+ rc = mapper_op->ulp_mapper_core_glb_idx_tbl_free(ulp, res);
+ break;
default:
break;
}
diff --git a/drivers/net/bnxt/tf_ulp/ulp_mapper.h b/drivers/net/bnxt/tf_ulp/ulp_mapper.h
index a4a42ab84d..732f095f01 100644
--- a/drivers/net/bnxt/tf_ulp/ulp_mapper.h
+++ b/drivers/net/bnxt/tf_ulp/ulp_mapper.h
@@ -166,6 +166,17 @@ struct ulp_mapper_core_ops {
(*ulp_mapper_core_global_ident_free)(struct bnxt_ulp_context *ulp_ctx,
struct ulp_flow_db_res_params *r);
+ int32_t
+ (*ulp_mapper_core_glb_idx_tbl_alloc)(struct bnxt_ulp_context *ctx,
+ uint16_t sub_type,
+ uint8_t direction,
+ uint8_t *context_id,
+ uint16_t context_len,
+ uint64_t *idx_id);
+
+ int32_t
+ (*ulp_mapper_core_glb_idx_tbl_free)(struct bnxt_ulp_context *ulp_ctx,
+ struct ulp_flow_db_res_params *r);
uint32_t
(*ulp_mapper_core_dyn_tbl_type_get)(struct bnxt_ulp_mapper_parms *parms,
struct bnxt_ulp_mapper_tbl_info *t,
diff --git a/drivers/net/bnxt/tf_ulp/ulp_mapper_tf.c b/drivers/net/bnxt/tf_ulp/ulp_mapper_tf.c
index 72d0f96573..3960be4e48 100644
--- a/drivers/net/bnxt/tf_ulp/ulp_mapper_tf.c
+++ b/drivers/net/bnxt/tf_ulp/ulp_mapper_tf.c
@@ -1380,6 +1380,8 @@ const struct ulp_mapper_core_ops ulp_mapper_tf_core_ops = {
.ulp_mapper_core_ident_free = ulp_mapper_tf_ident_free,
.ulp_mapper_core_global_ident_alloc = NULL,
.ulp_mapper_core_global_ident_free = NULL,
+ .ulp_mapper_core_glb_idx_tbl_alloc = NULL,
+ .ulp_mapper_core_glb_idx_tbl_free = NULL,
.ulp_mapper_core_dyn_tbl_type_get = ulp_mapper_tf_dyn_tbl_type_get,
.ulp_mapper_core_index_tbl_alloc_process =
ulp_mapper_tf_index_tbl_alloc_process,
diff --git a/drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c b/drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c
index 20b1ac09fc..0f967b838d 100644
--- a/drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c
+++ b/drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c
@@ -1911,6 +1911,81 @@ ulp_mapper_tfc_mtr_stats_hndl_del(uint32_t mtr_id)
}
return rc;
+}
+
+static int32_t
+ulp_mapper_tfc_glb_idx_tbl_alloc(struct bnxt_ulp_context *ulp_ctx,
+ uint16_t sub_type, uint8_t direction,
+ uint8_t *context_id, uint16_t context_len,
+ uint64_t *idx_id)
+{
+ struct tfc *tfcp = NULL;
+ struct tfc_global_id_req glb_req = { 0 };
+ struct tfc_global_id glb_rsp = { 0 };
+ uint16_t fw_fid = 0;
+ int32_t rc = 0;
+ bool first = false;
+
+ if (unlikely(bnxt_ulp_cntxt_fid_get(ulp_ctx, &fw_fid))) {
+ BNXT_DRV_DBG(ERR, "Failed to get func_id");
+ return -EINVAL;
+ }
+
+ tfcp = bnxt_ulp_cntxt_tfcp_get(ulp_ctx);
+ if (unlikely(tfcp == NULL)) {
+ BNXT_DRV_DBG(ERR, "Failed to get tfcp pointer");
+ return -EINVAL;
+ }
+
+ glb_req.rtype = CFA_RTYPE_IDX_TBL;
+ glb_req.dir = direction;
+ glb_req.rsubtype = sub_type;
+ glb_req.context_len = context_len;
+ glb_req.context_id = context_id;
+
+ rc = tfc_global_id_alloc(tfcp, fw_fid, &glb_req, &glb_rsp, &first);
+ if (unlikely(rc != 0)) {
+ BNXT_DRV_DBG(ERR, "alloc failed %d", rc);
+ return rc;
+ }
+ *idx_id = glb_rsp.id;
+
+ return rc;
+}
+
+static int32_t
+ulp_mapper_tfc_glb_idx_tbl_free(struct bnxt_ulp_context *ulp_ctx,
+ struct ulp_flow_db_res_params *res)
+{
+ struct tfc_global_id_req glb_req = { 0 };
+ struct tfc *tfcp = NULL;
+ int32_t rc = 0;
+ uint16_t fw_fid = 0;
+
+ if (unlikely(bnxt_ulp_cntxt_fid_get(ulp_ctx, &fw_fid))) {
+ BNXT_DRV_DBG(ERR, "Failed to get func_id");
+ return -EINVAL;
+ }
+
+ tfcp = bnxt_ulp_cntxt_tfcp_get(ulp_ctx);
+ if (unlikely(tfcp == NULL)) {
+ BNXT_DRV_DBG(ERR, "Failed to get tfcp pointer");
+ return -EINVAL;
+ }
+
+ glb_req.rtype = CFA_RTYPE_IDX_TBL;
+ glb_req.dir = (enum cfa_dir)res->direction;
+ glb_req.rsubtype = res->resource_type;
+ glb_req.resource_id = (uint16_t)res->resource_hndl;
+
+ rc = tfc_global_id_free(tfcp, fw_fid, &glb_req);
+ if (unlikely(rc != 0)) {
+ BNXT_DRV_DBG(ERR, "free failed %d", rc);
+ return rc;
+ }
+
+ return rc;
+}
static inline int32_t
ulp_mapper_tfc_tcam_prio_update(struct bnxt_ulp_mapper_parms *parms,
@@ -1963,6 +2038,8 @@ const struct ulp_mapper_core_ops ulp_mapper_tfc_core_ops = {
.ulp_mapper_core_ident_free = ulp_mapper_tfc_ident_free,
.ulp_mapper_core_global_ident_alloc = ulp_mapper_tfc_global_ident_alloc,
.ulp_mapper_core_global_ident_free = ulp_mapper_tfc_global_ident_free,
+ .ulp_mapper_core_glb_idx_tbl_alloc = ulp_mapper_tfc_glb_idx_tbl_alloc,
+ .ulp_mapper_core_glb_idx_tbl_free = ulp_mapper_tfc_glb_idx_tbl_free,
.ulp_mapper_core_dyn_tbl_type_get = ulp_mapper_tfc_dyn_tbl_type_get,
.ulp_mapper_core_index_tbl_alloc_process =
ulp_mapper_tfc_index_tbl_alloc_process,
--
2.39.5 (Apple Git-154)
next prev parent reply other threads:[~2025-09-30 7:08 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 0:35 [PATCH 00/54] bnxt patchset Manish Kurup
2025-09-30 0:35 ` [PATCH 01/54] net/bnxt/tf_ulp: add bnxt app data for 25.11 Manish Kurup
2025-09-30 0:35 ` [PATCH 02/54] net/bnxt: fix a NULL pointer dereference in bnxt_rep funcs Manish Kurup
2025-09-30 0:35 ` [PATCH 03/54] net/bnxt: enable vector mode processing Manish Kurup
2025-09-30 0:35 ` [PATCH 04/54] net/bnxt/tf_ulp: add meter stats support for Thor2 Manish Kurup
2025-09-30 0:35 ` [PATCH 05/54] net/bnxt/tf_core: dynamic UPAR support for THOR2 Manish Kurup
2025-09-30 0:35 ` [PATCH 06/54] net/bnxt/tf_core: fix the miscalculation of the lkup table pool Manish Kurup
2025-09-30 0:35 ` [PATCH 07/54] net/bnxt/tf_core: thor2 TF table scope sizing adjustments Manish Kurup
2025-09-30 0:35 ` [PATCH 08/54] net/bnxt/tf_ulp: add support for global identifiers Manish Kurup
2025-09-30 0:35 ` [PATCH 09/54] net/bnxt/tf_core: add support for multi instance Manish Kurup
2025-09-30 0:35 ` [PATCH 10/54] net/bnxt/tf_core: fix table scope free Manish Kurup
2025-09-30 0:35 ` [PATCH 11/54] net/bnxt/tf_core: fix vfr clean up and stats lockup Manish Kurup
2025-09-30 0:35 ` [PATCH 12/54] net/bnxt/tf_ulp: add support for special vxlan Manish Kurup
2025-09-30 0:35 ` [PATCH 13/54] net/bnxt/tf_ulp: increase shared pool size to 32 Manish Kurup
2025-09-30 0:35 ` [PATCH 14/54] next/bnxt/tf_ulp: truflow fixes for meter and mac_addr cache Manish Kurup
2025-09-30 0:35 ` [PATCH 15/54] net/bnxt/tf_ulp: add support for tcam priority update Manish Kurup
2025-09-30 0:35 ` [PATCH 16/54] net/bnxt/tf_ulp: hot upgrade support Manish Kurup
2025-09-30 0:35 ` [PATCH 17/54] net/bnxt/tf_core: tcam manager logical id free Manish Kurup
2025-09-30 0:35 ` [PATCH 18/54] net/bnxt/tf_ulp: fix stats counter memory initialization Manish Kurup
2025-09-30 0:35 ` [PATCH 19/54] net/bnxt: fix max VFs count for thor2 Manish Kurup
2025-09-30 0:35 ` [PATCH 20/54] net/bnxt/tf_ulp: ovs-dpdk packet drop observed with thor2 Manish Kurup
2025-09-30 0:35 ` [PATCH 21/54] net/bnxt/tf_ulp: fix seg fault when devargs argument missing Manish Kurup
2025-09-30 0:35 ` [PATCH 22/54] net/bnxt: fix default rss config Manish Kurup
2025-09-30 0:35 ` Manish Kurup [this message]
2025-09-30 0:35 ` [PATCH 24/54] net/bnxt/tf_core: fix build failure with flow scale option Manish Kurup
2025-09-30 0:35 ` [PATCH 25/54] net/bnxt: truflow remove redundant code for mpc init Manish Kurup
2025-09-30 0:35 ` [PATCH 26/54] net/bnxt/tf_ulp: optimize template enums Manish Kurup
2025-09-30 0:35 ` [PATCH 27/54] net/bnxt/tf_core: thor2 hot upgrade ungraceful quit crash Manish Kurup
2025-09-30 0:35 ` [PATCH 28/54] net/bnxt/tf_ulp: support MPLS packets Manish Kurup
2025-09-30 0:35 ` [PATCH 29/54] net/bnxt/tf_core: add backing store debug to dpdk Manish Kurup
2025-09-30 0:35 ` [PATCH 30/54] net/bnxt/tf_core: truflow global table scope Manish Kurup
2025-09-30 0:35 ` [PATCH 31/54] net/bnxt/tf_ulp: ulp parser support to handle gre key Manish Kurup
2025-09-30 0:35 ` [PATCH 32/54] net/bnxt/tf_core: handle out of order MPC completions Manish Kurup
2025-09-30 0:35 ` [PATCH 33/54] net/bnxt/tf_ulp: socket direct enable Manish Kurup
2025-09-30 0:35 ` [PATCH 34/54] net/bnxt: fix adding udp_tunnel_port Manish Kurup
2025-09-30 0:35 ` [PATCH 35/54] net/bnxt/tf_ulp: add non vfr mode capability Manish Kurup
2025-09-30 0:35 ` [PATCH 36/54] net/bnxt: avoid iova range check when external memory is used Manish Kurup
2025-09-30 0:35 ` [PATCH 37/54] net/bnxt: avoid potential segfault in VFR handling Manish Kurup
2025-09-30 0:35 ` [PATCH 38/54] net/bnxt/tf_ulp: change rte_mem_virt2iova to rte_mem_virt2phys Manish Kurup
2025-09-30 0:35 ` [PATCH 39/54] net/bnxt: thor2 truflow memory manager bug Manish Kurup
2025-09-30 0:35 ` [PATCH 40/54] net/bnxt: fix stats collection when rx queue is not set Manish Kurup
2025-09-30 0:35 ` [PATCH 41/54] net/bnxt: fix rss configuration when set to none Manish Kurup
2025-09-30 0:35 ` [PATCH 42/54] net/bnxt: packet drop after port stop and start Manish Kurup
2025-09-30 0:35 ` [PATCH 43/54] net/bnxt/tf_core: fix truflow crash on memory allocation failure Manish Kurup
2025-09-30 0:35 ` [PATCH 44/54] net/bnxt: truflow remove RTE devarg processing for mpc=1 Manish Kurup
2025-09-30 0:35 ` [PATCH 45/54] net/bnxt: add meson build options for TruFlow Manish Kurup
2025-09-30 0:35 ` [PATCH 46/54] net/bnxt: truflow HSI struct fixes Manish Kurup
2025-09-30 0:35 ` [PATCH 47/54] net/bnxt/tf_ulp: truflow add pf action handler Manish Kurup
2025-09-30 0:35 ` [PATCH 48/54] net/bnxt/tf_ulp: add support for unicast only feature Manish Kurup
2025-09-30 0:35 ` [PATCH 49/54] net/bnxt/tf_core: remove excessive debug logging Manish Kurup
2025-09-30 0:36 ` [PATCH 50/54] net/bnxt/tf_core: fix truflow PF init failure on sriov disabled Manish Kurup
2025-09-30 0:36 ` [PATCH 51/54] net/bnxt/tf_ulp: fixes to enable TF functionality Manish Kurup
2025-09-30 0:36 ` [PATCH 52/54] net/bnxt/tf_ulp: add feature bit rx miss handling Manish Kurup
2025-09-30 0:36 ` [PATCH 53/54] net/bnxt: add support for truflow promiscuous mode Manish Kurup
2025-09-30 0:36 ` [PATCH 54/54] net/bnxt/tf_ulp: remove Truflow DEBUG code Manish Kurup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250930003604.87108-24-manish.kurup@broadcom.com \
--to=manish.kurup@broadcom.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=kishore.padmanabha@broadcom.com \
--cc=shuanglin.wang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).