From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: david.marchand@redhat.com, Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH v8 13/18] eal: add internal fn for converting cpuset to string
Date: Thu, 2 Oct 2025 18:43:10 +0100 [thread overview]
Message-ID: <20251002174315.962992-14-bruce.richardson@intel.com> (raw)
In-Reply-To: <20251002174315.962992-1-bruce.richardson@intel.com>
The existing "available_cores" function in eal_common_options.c has
general code for converting a set of cores to a printable string.
Generalize this code into an "eal_cpuset_to_str" function which takes a
cpuset as parameter, and create a new "available_cores" function using
this new utility function.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
lib/eal/common/eal_common_options.c | 33 ++++++++++++++++++++++-------
lib/eal/common/eal_private.h | 10 +++++++++
2 files changed, 35 insertions(+), 8 deletions(-)
diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c
index d7a8263f08..e89ca615b8 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -1570,8 +1570,8 @@ eal_parse_base_virtaddr(const char *arg)
}
/* caller is responsible for freeing the returned string */
-static char *
-available_cores(void)
+char *
+eal_cpuset_to_str(const rte_cpuset_t *cpuset)
{
char *str = NULL;
int previous;
@@ -1579,13 +1579,13 @@ available_cores(void)
char *tmp;
int idx;
- /* find the first available cpu */
- for (idx = 0; idx < RTE_MAX_LCORE; idx++) {
- if (eal_cpu_detected(idx) == 0)
+ /* find the first set cpu */
+ for (idx = 0; idx < CPU_SETSIZE; idx++) {
+ if (!CPU_ISSET(idx, cpuset))
continue;
break;
}
- if (idx >= RTE_MAX_LCORE)
+ if (idx >= CPU_SETSIZE)
return NULL;
/* first sequence */
@@ -1594,8 +1594,8 @@ available_cores(void)
previous = idx;
sequence = 0;
- for (idx++ ; idx < RTE_MAX_LCORE; idx++) {
- if (eal_cpu_detected(idx) == 0)
+ for (idx++ ; idx < CPU_SETSIZE; idx++) {
+ if (!CPU_ISSET(idx, cpuset))
continue;
if (idx == previous + 1) {
@@ -1638,6 +1638,23 @@ available_cores(void)
return str;
}
+/* caller is responsible for freeing the returned string */
+static char *
+available_cores(void)
+{
+ rte_cpuset_t cpuset;
+ int idx;
+
+ /* build cpuset of available cores */
+ CPU_ZERO(&cpuset);
+ for (idx = 0; idx < RTE_MAX_LCORE; idx++) {
+ if (eal_cpu_detected(idx))
+ CPU_SET(idx, &cpuset);
+ }
+
+ return eal_cpuset_to_str(&cpuset);
+}
+
#define HUGE_UNLINK_NEVER "never"
static int
diff --git a/lib/eal/common/eal_private.h b/lib/eal/common/eal_private.h
index ab8b37b956..e032dd10c9 100644
--- a/lib/eal/common/eal_private.h
+++ b/lib/eal/common/eal_private.h
@@ -83,6 +83,16 @@ struct rte_config *rte_eal_get_configuration(void);
*/
int eal_collate_args(int argc, char **argv);
+/**
+ * Convert an rte_cpuset_t to string form suitable for parsing by argparse.
+ *
+ * @param cpuset
+ * The cpuset to convert to string form.
+ * @return
+ * String representation of the cpuset (caller must free), or NULL on error.
+ */
+char *eal_cpuset_to_str(const rte_cpuset_t *cpuset);
+
/**
* Initialize the memzone subsystem (private to eal).
*
--
2.48.1
next prev parent reply other threads:[~2025-10-02 17:44 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 16:40 [RFC PATCH 0/7] rework EAL argument parsing in DPDK Bruce Richardson
2025-05-20 16:40 ` [RFC PATCH 1/7] eal: add long options for each short option Bruce Richardson
2025-05-20 16:40 ` [RFC PATCH 2/7] argparse: add support for string and boolean args Bruce Richardson
2025-05-20 16:40 ` [RFC PATCH 3/7] argparse: make argparse EAL-args compatible Bruce Richardson
2025-05-22 10:44 ` Bruce Richardson
2025-05-20 16:40 ` [RFC PATCH 4/7] eal: define the EAL parameters in argparse format Bruce Richardson
2025-05-20 16:40 ` [RFC PATCH 5/7] eal: gather EAL args before processing Bruce Richardson
2025-05-20 16:40 ` [RFC PATCH 6/7] eal: combine parameter validation checks Bruce Richardson
2025-05-20 16:40 ` [RFC PATCH 7/7] eal: simplify handling of conflicting cmdline options Bruce Richardson
2025-07-08 17:20 ` [RFC PATCH v2 0/5] rework EAL argument parsing in DPDK Bruce Richardson
2025-07-08 17:20 ` [RFC PATCH v2 1/5] eal: add long options for each short option Bruce Richardson
2025-07-08 17:20 ` [RFC PATCH v2 2/5] eal: define the EAL parameters in argparse format Bruce Richardson
2025-07-08 17:20 ` [RFC PATCH v2 3/5] eal: gather EAL args before processing Bruce Richardson
2025-07-08 17:20 ` [RFC PATCH v2 4/5] eal: combine parameter validation checks Bruce Richardson
2025-07-08 17:20 ` [RFC PATCH v2 5/5] eal: simplify handling of conflicting cmdline options Bruce Richardson
2025-07-08 18:41 ` [RFC PATCH v2 0/5] rework EAL argument parsing in DPDK Stephen Hemminger
2025-07-09 7:50 ` Bruce Richardson
2025-07-09 12:30 ` David Marchand
2025-07-09 12:54 ` Bruce Richardson
2025-07-17 10:41 ` David Marchand
2025-07-17 10:54 ` Bruce Richardson
2025-07-18 14:33 ` [PATCH v3 0/9] rework EAL argument parsing Bruce Richardson
2025-07-18 14:33 ` [PATCH v3 1/9] build: add define for the OS environment name Bruce Richardson
2025-07-18 14:33 ` [PATCH v3 2/9] argparse: export function to print help text for object Bruce Richardson
2025-07-18 14:33 ` [PATCH v3 3/9] argparse: allow user-override of help printing Bruce Richardson
2025-07-21 8:43 ` David Marchand
2025-07-21 9:00 ` Bruce Richardson
2025-07-18 14:33 ` [PATCH v3 4/9] eal: add long options for each short option Bruce Richardson
2025-07-18 14:33 ` [PATCH v3 5/9] eal: define the EAL parameters in argparse format Bruce Richardson
2025-07-21 8:41 ` David Marchand
2025-07-21 9:05 ` Bruce Richardson
2025-07-21 12:53 ` Bruce Richardson
2025-07-18 14:33 ` [PATCH v3 6/9] eal: gather EAL args before processing Bruce Richardson
2025-07-18 14:33 ` [PATCH v3 7/9] eal: ensure proper cleanup on EAL init failure Bruce Richardson
2025-07-18 14:33 ` [PATCH v3 8/9] eal: combine parameter validation checks Bruce Richardson
2025-07-18 14:33 ` [PATCH v3 9/9] eal: simplify handling of conflicting cmdline options Bruce Richardson
2025-07-18 14:41 ` [PATCH v3 0/9] rework EAL argument parsing Bruce Richardson
2025-07-21 15:08 ` [PATCH v4 " Bruce Richardson
2025-07-21 15:08 ` [PATCH v4 1/9] build: add define for the OS environment name Bruce Richardson
2025-07-21 15:08 ` [PATCH v4 2/9] argparse: export function to print help text for object Bruce Richardson
2025-07-21 15:08 ` [PATCH v4 3/9] argparse: allow user-override of help printing Bruce Richardson
2025-07-21 15:08 ` [PATCH v4 4/9] eal: add long options for each short option Bruce Richardson
2025-07-21 15:08 ` [PATCH v4 5/9] eal: define the EAL parameters in argparse format Bruce Richardson
2025-07-21 15:08 ` [PATCH v4 6/9] eal: gather EAL args before processing Bruce Richardson
2025-07-21 15:08 ` [PATCH v4 7/9] eal: ensure proper cleanup on EAL init failure Bruce Richardson
2025-07-21 15:08 ` [PATCH v4 8/9] eal: combine parameter validation checks Bruce Richardson
2025-07-21 15:08 ` [PATCH v4 9/9] eal: simplify handling of conflicting cmdline options Bruce Richardson
2025-07-21 15:16 ` [PATCH v5 0/9] rework EAL argument parsing Bruce Richardson
2025-07-21 15:16 ` [PATCH v5 1/9] build: add define for the OS environment name Bruce Richardson
2025-07-21 15:16 ` [PATCH v5 2/9] argparse: export function to print help text for object Bruce Richardson
2025-07-21 15:16 ` [PATCH v5 3/9] argparse: allow user-override of help printing Bruce Richardson
2025-07-21 15:16 ` [PATCH v5 4/9] eal: add long options for each short option Bruce Richardson
2025-07-21 15:16 ` [PATCH v5 5/9] eal: define the EAL parameters in argparse format Bruce Richardson
2025-07-21 15:16 ` [PATCH v5 6/9] eal: gather EAL args before processing Bruce Richardson
2025-07-21 15:16 ` [PATCH v5 7/9] eal: ensure proper cleanup on EAL init failure Bruce Richardson
2025-07-21 15:16 ` [PATCH v5 8/9] eal: combine parameter validation checks Bruce Richardson
2025-07-21 15:16 ` [PATCH v5 9/9] eal: simplify handling of conflicting cmdline options Bruce Richardson
2025-07-22 14:03 ` [PATCH v6 0/9] rework EAL argument parsing Bruce Richardson
2025-07-22 14:03 ` [PATCH v6 1/9] build: add define for the OS environment name Bruce Richardson
2025-07-22 14:03 ` [PATCH v6 2/9] argparse: export function to print help text for object Bruce Richardson
2025-07-22 14:03 ` [PATCH v6 3/9] argparse: allow user-override of help printing Bruce Richardson
2025-07-22 14:03 ` [PATCH v6 4/9] eal: add long options for each short option Bruce Richardson
2025-07-22 14:03 ` [PATCH v6 5/9] eal: define the EAL parameters in argparse format Bruce Richardson
2025-07-22 14:03 ` [PATCH v6 6/9] eal: gather EAL args before processing Bruce Richardson
2025-07-22 14:03 ` [PATCH v6 7/9] eal: ensure proper cleanup on EAL init failure Bruce Richardson
2025-07-22 14:03 ` [PATCH v6 8/9] eal: combine parameter validation checks Bruce Richardson
2025-07-22 14:03 ` [PATCH v6 9/9] eal: simplify handling of conflicting cmdline options Bruce Richardson
2025-09-30 13:06 ` [PATCH v6 0/9] rework EAL argument parsing David Marchand
2025-09-30 13:31 ` Bruce Richardson
2025-07-23 16:19 ` [PATCH v7 00/13] Simplify running with high-numbered CPUs Bruce Richardson
2025-07-23 16:19 ` [PATCH v7 01/13] build: add define for the OS environment name Bruce Richardson
2025-07-23 16:20 ` [PATCH v7 02/13] argparse: export function to print help text for object Bruce Richardson
2025-09-30 12:20 ` David Marchand
2025-07-23 16:20 ` [PATCH v7 03/13] argparse: allow user-override of help printing Bruce Richardson
2025-07-23 16:20 ` [PATCH v7 04/13] argparse: add documentation on supported value types Bruce Richardson
2025-07-23 16:20 ` [PATCH v7 05/13] eal: add long options for each short option Bruce Richardson
2025-09-30 12:21 ` David Marchand
2025-07-23 16:20 ` [PATCH v7 06/13] eal: define the EAL parameters in argparse format Bruce Richardson
2025-09-30 12:21 ` David Marchand
2025-09-30 15:12 ` Bruce Richardson
2025-10-01 8:46 ` David Marchand
2025-10-01 10:15 ` Bruce Richardson
2025-09-30 12:45 ` David Marchand
2025-09-30 12:58 ` Bruce Richardson
2025-09-30 13:16 ` David Marchand
2025-07-23 16:20 ` [PATCH v7 07/13] eal: gather EAL args before processing Bruce Richardson
2025-07-23 16:20 ` [PATCH v7 08/13] eal: ensure proper cleanup on EAL init failure Bruce Richardson
2025-07-23 16:20 ` [PATCH v7 09/13] eal: combine parameter validation checks Bruce Richardson
2025-07-23 16:20 ` [PATCH v7 10/13] eal: simplify handling of conflicting cmdline options Bruce Richardson
2025-07-23 16:20 ` [PATCH v7 11/13] argparse: add support for parsing core lists Bruce Richardson
2025-07-23 16:20 ` [PATCH v7 12/13] eal: simplify running CPUs with ids above max lcores Bruce Richardson
2025-07-23 16:20 ` [PATCH v7 13/13] eal: add warnings about ignored options Bruce Richardson
2025-08-29 14:39 ` [PATCH v7 00/13] Simplify running with high-numbered CPUs Bruce Richardson
2025-10-02 17:42 ` [PATCH v8 00/18] " Bruce Richardson
2025-10-02 17:42 ` [PATCH v8 01/18] build: add define for the OS environment name Bruce Richardson
2025-10-02 17:42 ` [PATCH v8 02/18] argparse: export function to print help text for object Bruce Richardson
2025-10-02 17:43 ` [PATCH v8 03/18] argparse: allow user-override of help printing Bruce Richardson
2025-10-02 17:43 ` [PATCH v8 04/18] argparse: add documentation on supported value types Bruce Richardson
2025-10-02 17:43 ` [PATCH v8 05/18] argparse: add support for parsing core lists Bruce Richardson
2025-10-02 17:43 ` [PATCH v8 06/18] eal: add long options for each short option Bruce Richardson
2025-10-02 17:43 ` [PATCH v8 07/18] eal: define the EAL parameters in argparse format Bruce Richardson
2025-10-02 17:43 ` [PATCH v8 08/18] eal: gather EAL args before processing Bruce Richardson
2025-10-02 17:43 ` [PATCH v8 09/18] eal: ensure proper cleanup on EAL init failure Bruce Richardson
2025-10-02 17:43 ` [PATCH v8 10/18] eal: combine parameter validation checks Bruce Richardson
2025-10-02 17:43 ` [PATCH v8 11/18] eal: simplify handling of conflicting cmdline options Bruce Richardson
2025-10-02 17:43 ` [PATCH v8 12/18] eal: automatically init arg list options Bruce Richardson
2025-10-02 17:43 ` Bruce Richardson [this message]
2025-10-02 17:43 ` [PATCH v8 14/18] eal: use common cpuset to string function Bruce Richardson
2025-10-02 17:43 ` [PATCH v8 15/18] eal: introduce lcore remapping option for coremasks Bruce Richardson
2025-10-02 17:43 ` [PATCH v8 16/18] eal: rework internal coremask parsing to use cpu sets Bruce Richardson
2025-10-02 17:43 ` [PATCH v8 17/18] eal: allow lcore id remapping with core lists Bruce Richardson
2025-10-02 17:43 ` [PATCH v8 18/18] eal: allow lcore remapping with autodetected core affinity Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251002174315.962992-14-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).