From: Ali Alnubani <alialnu@nvidia.com>
To: <dev@dpdk.org>
Subject: [PATCH] devtools: honor -n flag regardless of stdin state
Date: Tue, 14 Oct 2025 10:43:40 +0300 [thread overview]
Message-ID: <20251014074340.2364328-1-alialnu@nvidia.com> (raw)
The checkpatches.sh script was checking if stdin is a terminal before
honoring the -n flag, causing it to incorrectly attempt to read patches
from stdin when run without a TTY (e.g., in Jenkins/CI pipelines).
Reorder the conditionals to check for the -n flag before checking stdin
state. This ensures the -n flag takes precedence and the script checks
git commits as intended.
Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
---
devtools/checkpatches.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 9fb8fd0a07..0884f24839 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -558,9 +558,7 @@ if [ -n "$1" ] ; then
for patch in "$@" ; do
check "$patch" ''
done
-elif [ ! -t 0 ] ; then # stdin
- check '' ''
-else
+elif [ $number -ne 0 ] || [ -t 0 ]; then
if [ $number -eq 0 ] ; then
commits=$(git rev-list --reverse $range)
else
@@ -569,6 +567,8 @@ else
for commit in $commits ; do
check '' $commit
done
+else # stdin
+ check '' ''
fi
pass=$(($total - $status))
$quiet || printf '\n%d/%d valid patch' $pass $total
--
2.43.0
reply other threads:[~2025-10-14 7:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251014074340.2364328-1-alialnu@nvidia.com \
--to=alialnu@nvidia.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).