* [PATCH] devtools: honor -n flag regardless of stdin state
@ 2025-10-14 7:43 Ali Alnubani
0 siblings, 0 replies; only message in thread
From: Ali Alnubani @ 2025-10-14 7:43 UTC (permalink / raw)
To: dev
The checkpatches.sh script was checking if stdin is a terminal before
honoring the -n flag, causing it to incorrectly attempt to read patches
from stdin when run without a TTY (e.g., in Jenkins/CI pipelines).
Reorder the conditionals to check for the -n flag before checking stdin
state. This ensures the -n flag takes precedence and the script checks
git commits as intended.
Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
---
devtools/checkpatches.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 9fb8fd0a07..0884f24839 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -558,9 +558,7 @@ if [ -n "$1" ] ; then
for patch in "$@" ; do
check "$patch" ''
done
-elif [ ! -t 0 ] ; then # stdin
- check '' ''
-else
+elif [ $number -ne 0 ] || [ -t 0 ]; then
if [ $number -eq 0 ] ; then
commits=$(git rev-list --reverse $range)
else
@@ -569,6 +567,8 @@ else
for commit in $commits ; do
check '' $commit
done
+else # stdin
+ check '' ''
fi
pass=$(($total - $status))
$quiet || printf '\n%d/%d valid patch' $pass $total
--
2.43.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2025-10-14 7:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-14 7:43 [PATCH] devtools: honor -n flag regardless of stdin state Ali Alnubani
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).