[PATCH 20/21] net/ena/base: change return type and improve logging

[PATCH 20/21] net/ena/base: change return type and improve logging

[Shai Brandes]

The return value was unused and carried no semantic meaning,
so the function signature has been updated to return void.
Additionally, debug log messages have been refined to
improve clarity.

Signed-off-by: Shai Brandes <shaibran@amazon.com>
Reviewed-by: Amit Bernstein <amitbern@amazon.com>
Reviewed-by: Yosef Raisman <yraisman@amazon.com>
---
 drivers/net/ena/base/ena_eth_com.h | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/net/ena/base/ena_eth_com.h b/drivers/net/ena/base/ena_eth_com.h
index 1fc92ffb55..f773699467 100644
--- a/drivers/net/ena/base/ena_eth_com.h
+++ b/drivers/net/ena/base/ena_eth_com.h
@@ -171,26 +171,24 @@ static inline bool ena_com_is_doorbell_needed(struct ena_com_io_sq *io_sq,
 	return num_entries_needed > io_sq->entries_in_tx_burst_left;
 }
 
-static inline int ena_com_write_rx_sq_doorbell(struct ena_com_io_sq *io_sq)
+static inline void ena_com_write_rx_sq_doorbell(struct ena_com_io_sq *io_sq)
 {
 	u16 tail = io_sq->tail;
 
 	ena_trc_dbg(ena_com_io_sq_to_ena_dev(io_sq),
-		    "Write submission queue doorbell for queue: %d tail: %d\n",
+		    "Write submission queue doorbell for rx queue: %d tail: %d\n",
 		    io_sq->qid, tail);
 
 	ENA_REG_WRITE32(io_sq->bus, tail, io_sq->db_addr);
-
-	return 0;
 }
 
-static inline int ena_com_write_tx_sq_doorbell(struct ena_com_io_sq *io_sq)
+static inline void ena_com_write_tx_sq_doorbell(struct ena_com_io_sq *io_sq)
 {
 	u16 max_entries_in_tx_burst = io_sq->llq_info.max_entries_in_tx_burst;
 	u16 tail = io_sq->tail;
 
 	ena_trc_dbg(ena_com_io_sq_to_ena_dev(io_sq),
-		    "Write submission queue doorbell for queue: %d tail: %d\n",
+		    "Write submission queue doorbell for tx queue: %d tail: %d\n",
 		    io_sq->qid, tail);
 
 	ENA_REG_WRITE32(io_sq->bus, tail, io_sq->db_addr);
@@ -201,8 +199,6 @@ static inline int ena_com_write_tx_sq_doorbell(struct ena_com_io_sq *io_sq)
 			    io_sq->qid, max_entries_in_tx_burst);
 		io_sq->entries_in_tx_burst_left = max_entries_in_tx_burst;
 	}
-
-	return 0;
 }
 
 static inline void ena_com_update_numa_node(struct ena_com_io_cq *io_cq,
-- 
2.17.1