From: Ciara Loftus <ciara.loftus@intel.com>
To: dev@dpdk.org
Cc: Ciara Loftus <ciara.loftus@intel.com>
Subject: [PATCH v2 7/7] net/ice: reformat the Rx path infos array
Date: Wed, 15 Oct 2025 10:07:23 +0000 [thread overview]
Message-ID: <20251015100723.1603296-8-ciara.loftus@intel.com> (raw)
In-Reply-To: <20251015100723.1603296-1-ciara.loftus@intel.com>
In order to improve readability, reformat the rx path infos array.
Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
v2:
* Newline for closing braces.
* Removed assignment of RTE_VECT_SIMD_DISABLED to simd_width, the
selection logic can work when this is set to zero for the scalar path.
* Removed unused define ICE_RX_NO_OFFLOADS
---
drivers/net/intel/ice/ice_rxtx.c | 147 ++++++++++++++++++++++++-------
drivers/net/intel/ice/ice_rxtx.h | 1 -
2 files changed, 116 insertions(+), 32 deletions(-)
diff --git a/drivers/net/intel/ice/ice_rxtx.c b/drivers/net/intel/ice/ice_rxtx.c
index 411b353417..2c87e56da4 100644
--- a/drivers/net/intel/ice/ice_rxtx.c
+++ b/drivers/net/intel/ice/ice_rxtx.c
@@ -3667,41 +3667,126 @@ ice_xmit_pkts_simple(void *tx_queue,
}
static const struct ci_rx_path_info ice_rx_path_infos[] = {
- [ICE_RX_DEFAULT] = {ice_recv_pkts, "Scalar",
- {ICE_RX_SCALAR_OFFLOADS, RTE_VECT_SIMD_DISABLED}},
- [ICE_RX_SCATTERED] = {ice_recv_scattered_pkts, "Scalar Scattered",
- {ICE_RX_SCALAR_OFFLOADS, RTE_VECT_SIMD_DISABLED, {.scattered = true}}},
- [ICE_RX_BULK_ALLOC] = {ice_recv_pkts_bulk_alloc, "Scalar Bulk Alloc",
- {ICE_RX_SCALAR_OFFLOADS, RTE_VECT_SIMD_DISABLED, {.bulk_alloc = true}}},
+ [ICE_RX_DEFAULT] = {
+ .pkt_burst = ice_recv_pkts,
+ .info = "Scalar",
+ .features = {
+ .rx_offloads = ICE_RX_SCALAR_OFFLOADS
+ }
+ },
+ [ICE_RX_SCATTERED] = {
+ .pkt_burst = ice_recv_scattered_pkts,
+ .info = "Scalar Scattered",
+ .features = {
+ .rx_offloads = ICE_RX_SCALAR_OFFLOADS,
+ .extra.scattered = true
+ }
+ },
+ [ICE_RX_BULK_ALLOC] = {
+ .pkt_burst = ice_recv_pkts_bulk_alloc,
+ .info = "Scalar Bulk Alloc",
+ .features = {
+ .rx_offloads = ICE_RX_SCALAR_OFFLOADS,
+ .extra.bulk_alloc = true
+ }
+ },
#ifdef RTE_ARCH_X86
- [ICE_RX_SSE] = {ice_recv_pkts_vec, "Vector SSE",
- {ICE_RX_VECTOR_OFFLOAD_OFFLOADS, RTE_VECT_SIMD_128, {.bulk_alloc = true}}},
- [ICE_RX_SSE_SCATTERED] = {ice_recv_scattered_pkts_vec, "Vector SSE Scattered",
- {ICE_RX_VECTOR_OFFLOAD_OFFLOADS, RTE_VECT_SIMD_128,
- {.scattered = true, .bulk_alloc = true}}},
- [ICE_RX_AVX2] = {ice_recv_pkts_vec_avx2, "Vector AVX2",
- {ICE_RX_VECTOR_OFFLOADS, RTE_VECT_SIMD_256, {.bulk_alloc = true}}},
- [ICE_RX_AVX2_SCATTERED] = {ice_recv_scattered_pkts_vec_avx2, "Vector AVX2 Scattered",
- {ICE_RX_VECTOR_OFFLOADS, RTE_VECT_SIMD_256,
- {.scattered = true, .bulk_alloc = true}}},
- [ICE_RX_AVX2_OFFLOAD] = {ice_recv_pkts_vec_avx2_offload, "Offload Vector AVX2",
- {ICE_RX_VECTOR_OFFLOAD_OFFLOADS, RTE_VECT_SIMD_256, {.bulk_alloc = true}}},
+ [ICE_RX_SSE] = {
+ .pkt_burst = ice_recv_pkts_vec,
+ .info = "Vector SSE",
+ .features = {
+ .rx_offloads = ICE_RX_VECTOR_OFFLOAD_OFFLOADS,
+ .simd_width = RTE_VECT_SIMD_128,
+ .extra.bulk_alloc = true
+ }
+ },
+ [ICE_RX_SSE_SCATTERED] = {
+ .pkt_burst = ice_recv_scattered_pkts_vec,
+ .info = "Vector SSE Scattered",
+ .features = {
+ .rx_offloads = ICE_RX_VECTOR_OFFLOAD_OFFLOADS,
+ .simd_width = RTE_VECT_SIMD_128,
+ .extra.scattered = true,
+ .extra.bulk_alloc = true
+ }
+ },
+ [ICE_RX_AVX2] = {
+ .pkt_burst = ice_recv_pkts_vec_avx2,
+ .info = "Vector AVX2",
+ .features = {
+ .rx_offloads = ICE_RX_VECTOR_OFFLOADS,
+ .simd_width = RTE_VECT_SIMD_256,
+ .extra.bulk_alloc = true
+ }
+ },
+ [ICE_RX_AVX2_SCATTERED] = {
+ .pkt_burst = ice_recv_scattered_pkts_vec_avx2,
+ .info = "Vector AVX2 Scattered",
+ .features = {
+ .rx_offloads = ICE_RX_VECTOR_OFFLOADS,
+ .simd_width = RTE_VECT_SIMD_256,
+ .extra.scattered = true,
+ .extra.bulk_alloc = true
+ }
+ },
+ [ICE_RX_AVX2_OFFLOAD] = {
+ .pkt_burst = ice_recv_pkts_vec_avx2_offload,
+ .info = "Offload Vector AVX2",
+ .features = {
+ .rx_offloads = ICE_RX_VECTOR_OFFLOAD_OFFLOADS,
+ .simd_width = RTE_VECT_SIMD_256,
+ .extra.bulk_alloc = true
+ }
+ },
[ICE_RX_AVX2_SCATTERED_OFFLOAD] = {
- ice_recv_scattered_pkts_vec_avx2_offload, "Offload Vector AVX2 Scattered",
- {ICE_RX_VECTOR_OFFLOAD_OFFLOADS, RTE_VECT_SIMD_256,
- {.scattered = true, .bulk_alloc = true}}},
+ .pkt_burst = ice_recv_scattered_pkts_vec_avx2_offload,
+ .info = "Offload Vector AVX2 Scattered",
+ .features = {
+ .rx_offloads = ICE_RX_VECTOR_OFFLOAD_OFFLOADS,
+ .simd_width = RTE_VECT_SIMD_256,
+ .extra.scattered = true,
+ .extra.bulk_alloc = true
+ }
+ },
#ifdef CC_AVX512_SUPPORT
- [ICE_RX_AVX512] = {ice_recv_pkts_vec_avx512, "Vector AVX512",
- {ICE_RX_VECTOR_OFFLOADS, RTE_VECT_SIMD_512, {.bulk_alloc = true}}},
- [ICE_RX_AVX512_SCATTERED] = {ice_recv_scattered_pkts_vec_avx512, "Vector AVX512 Scattered",
- {ICE_RX_VECTOR_OFFLOADS, RTE_VECT_SIMD_512,
- {.scattered = true, .bulk_alloc = true}}},
- [ICE_RX_AVX512_OFFLOAD] = {ice_recv_pkts_vec_avx512_offload, "Offload Vector AVX512",
- {ICE_RX_VECTOR_OFFLOAD_OFFLOADS, RTE_VECT_SIMD_512, {.bulk_alloc = true}}},
+ [ICE_RX_AVX512] = {
+ .pkt_burst = ice_recv_pkts_vec_avx512,
+ .info = "Vector AVX512",
+ .features = {
+ .rx_offloads = ICE_RX_VECTOR_OFFLOADS,
+ .simd_width = RTE_VECT_SIMD_512,
+ .extra.bulk_alloc = true
+ }
+ },
+ [ICE_RX_AVX512_SCATTERED] = {
+ .pkt_burst = ice_recv_scattered_pkts_vec_avx512,
+ .info = "Vector AVX512 Scattered",
+ .features = {
+ .rx_offloads = ICE_RX_VECTOR_OFFLOADS,
+ .simd_width = RTE_VECT_SIMD_512,
+ .extra.scattered = true,
+ .extra.bulk_alloc = true
+ }
+ },
+ [ICE_RX_AVX512_OFFLOAD] = {
+ .pkt_burst = ice_recv_pkts_vec_avx512_offload,
+ .info = "Offload Vector AVX512",
+ .features = {
+ .rx_offloads = ICE_RX_VECTOR_OFFLOAD_OFFLOADS,
+ .simd_width = RTE_VECT_SIMD_512,
+ .extra.bulk_alloc = true
+ }
+ },
[ICE_RX_AVX512_SCATTERED_OFFLOAD] = {
- ice_recv_scattered_pkts_vec_avx512_offload, "Offload Vector AVX512 Scattered",
- {ICE_RX_VECTOR_OFFLOAD_OFFLOADS, RTE_VECT_SIMD_512,
- {.scattered = true, .bulk_alloc = true}}},
+ .pkt_burst = ice_recv_scattered_pkts_vec_avx512_offload,
+ .info = "Offload Vector AVX512 Scattered",
+ .features = {
+ .rx_offloads = ICE_RX_VECTOR_OFFLOAD_OFFLOADS,
+ .simd_width = RTE_VECT_SIMD_512,
+ .extra.scattered = true,
+ .extra.bulk_alloc = true
+ }
+ },
#endif
#endif
};
diff --git a/drivers/net/intel/ice/ice_rxtx.h b/drivers/net/intel/ice/ice_rxtx.h
index 6dac592eb4..141a62a7da 100644
--- a/drivers/net/intel/ice/ice_rxtx.h
+++ b/drivers/net/intel/ice/ice_rxtx.h
@@ -80,7 +80,6 @@
#define ICE_TX_OFFLOAD_NOTSUP_MASK \
(RTE_MBUF_F_TX_OFFLOAD_MASK ^ ICE_TX_OFFLOAD_MASK)
-#define ICE_RX_NO_OFFLOADS 0
/* basic scalar path */
#define ICE_RX_SCALAR_OFFLOADS ( \
RTE_ETH_RX_OFFLOAD_VLAN_STRIP | \
--
2.34.1
prev parent reply other threads:[~2025-10-15 10:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 8:45 [PATCH 0/6] net/intel: fixes and improvements to rx path selection Ciara Loftus
2025-10-14 8:45 ` [PATCH 1/6] net/intel: fix Rx vector capability detection Ciara Loftus
2025-10-14 14:16 ` Bruce Richardson
2025-10-14 14:59 ` Loftus, Ciara
2025-10-14 8:45 ` [PATCH 2/6] net/iavf: fix Rx paths feature definitions Ciara Loftus
2025-10-14 14:26 ` Bruce Richardson
2025-10-14 8:45 ` [PATCH 3/6] net/iavf: fix Rx path selection for scalar flex bulk alloc Ciara Loftus
2025-10-14 14:33 ` Bruce Richardson
2025-10-14 8:45 ` [PATCH 4/6] net/iavf: reformat the Rx path infos array Ciara Loftus
2025-10-14 14:38 ` Bruce Richardson
2025-10-14 8:45 ` [PATCH 5/6] net/i40e: " Ciara Loftus
2025-10-14 14:38 ` Bruce Richardson
2025-10-14 8:45 ` [PATCH 6/6] net/ice: " Ciara Loftus
2025-10-14 14:39 ` Bruce Richardson
2025-10-15 10:07 ` [PATCH v2 0/7] net/intel: fixes and improvements to rx path selection Ciara Loftus
2025-10-15 10:07 ` [PATCH v2 1/7] net/intel: fix Rx vector capability detection Ciara Loftus
2025-10-15 10:07 ` [PATCH v2 2/7] net/intel: remove redundant Rx offload check Ciara Loftus
2025-10-15 10:07 ` [PATCH v2 3/7] net/iavf: fix Rx paths feature definitions Ciara Loftus
2025-10-15 10:07 ` [PATCH v2 4/7] net/iavf: fix Rx path selection for scalar flex bulk alloc Ciara Loftus
2025-10-15 10:07 ` [PATCH v2 5/7] net/iavf: reformat the Rx path infos array Ciara Loftus
2025-10-15 10:07 ` [PATCH v2 6/7] net/i40e: " Ciara Loftus
2025-10-15 10:07 ` Ciara Loftus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251015100723.1603296-8-ciara.loftus@intel.com \
--to=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).