DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Vamsi Krishna <vattunuru@marvell.com>
Cc: <dev@dpdk.org>, <fengchengwen@huawei.com>, <thomas@monjalon.net>,
	<bruce.richardson@intel.com>, <anatoly.burakov@intel.com>,
	<kevin.laatz@intel.com>, <jerinj@marvell.com>
Subject: Re: [PATCH v3 1/1] lib/dma: introduce inter-process and inter-OS DMA
Date: Wed, 15 Oct 2025 10:27:46 -0700	[thread overview]
Message-ID: <20251015102746.41daeb3b@hermes.local> (raw)
In-Reply-To: <20251013042136.1727540-1-vattunuru@marvell.com>

On Mon, 13 Oct 2025 09:51:36 +0530
Vamsi Krishna <vattunuru@marvell.com> wrote:

> +	if (conf->domain.type != RTE_DMA_INTER_DOMAIN_NONE &&
> +	    conf->direction != RTE_DMA_DIR_MEM_TO_MEM) {
> +		RTE_DMA_LOG(ERR, "Device %d inter domain only support mem-to-mem transfer", dev_id);
> +		return -EINVAL;
> +	}
> +	if (conf->domain.type == RTE_DMA_INTER_OS_DOMAIN &&
> +	    !(dev_info.dev_capa & RTE_DMA_CAPA_INTER_OS_DOMAIN)) {
> +		RTE_DMA_LOG(ERR, "Device %d does not support inter os domain", dev_id);
> +		return -EINVAL;
> +	}
> +	if (conf->domain.type == RTE_DMA_INTER_PROCESS_DOMAIN &&
> +	    !(dev_info.dev_capa & RTE_DMA_CAPA_INTER_PROCESS_DOMAIN)) {
> +		RTE_DMA_LOG(ERR, "Device %d does not support inter process domain", dev_id);
> +		return -EINVAL;
> +	}

Why is dev_id of type int16_t, seems like a limiting and poor choice.
Would expect it to be unsigned and 32 bits?

      parent reply	other threads:[~2025-10-15 18:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <--in-reply-to=20251010144631.713063-1-vattunuru@marvell.com>
2025-10-13  4:21 ` Vamsi Krishna
2025-10-13  7:52   ` fengchengwen
2025-10-13 18:31     ` [EXTERNAL] " Vamsi Krishna Attunuru
2025-10-15  7:09       ` fengchengwen
2025-10-15 17:26   ` Stephen Hemminger
2025-10-15 17:27   ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251015102746.41daeb3b@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=jerinj@marvell.com \
    --cc=kevin.laatz@intel.com \
    --cc=thomas@monjalon.net \
    --cc=vattunuru@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).