From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E30948946; Thu, 16 Oct 2025 00:17:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B95940ED3; Thu, 16 Oct 2025 00:17:11 +0200 (CEST) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id F27E040E03 for ; Thu, 16 Oct 2025 00:17:09 +0200 (CEST) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-28e7cd6dbc0so1168865ad.0 for ; Wed, 15 Oct 2025 15:17:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1760566629; x=1761171429; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=sAcS8bMA7foTEqO5XDKKSk3VNXRL6yUMpsLwyffDeY0=; b=qsL85A3IRDteJ0YVI7fkM5ZZeYwGOR6Xu4aRlsIg780JeTob8zo/y393RMaaSj5v38 H1vdmk7Rohdv0maaH62ygsViRDjkrTPX8T3wY4+fXz2qb+xWY1WsgT9nidb79BPDXIFn lg0ithhIHmXDpC+kr11i0aXlvHkbGZkGRfQFFhuYRJRlE4XxiXdgy8fjynnx78hkaq0i C9tp0qUPEvLquT4YmH+uykFjyxuh1EmKALATzVrpt1c/1xKwlkISGqBMC+d9vTf7PlfX BTk705onJ4nel2f/k/dAjtEw2nkgjLxjZfNyQgBDLxOZYjuKKkVhwZqfFEpwvkJY1FUZ DTmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760566629; x=1761171429; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sAcS8bMA7foTEqO5XDKKSk3VNXRL6yUMpsLwyffDeY0=; b=wnQ0s2G5pZ+etA1g0xvFHoH1MiTuEcJx9Lmop2aB+TIorMbf6EuzQ8zviiQUFn1dxF pBF1tLKUa5zLa/snuKsQX85I4blHQ40+1xLi+kLuG8rH3w3l/HyPWRwlISpKHCpZoxyF C9ZhqZxBtXmrGtzk9YY0WZ0stOvyRER/yG5FnbtgEg31CDCD52Qx4/sJutr2iLg2EgWQ oNE5TEPAtqQqbC2n4gL45FJ/gN750QlITV+GAeosLH3qGcOb48r0zLMntbJ21CA1WqHv WmvYxJBRvC8wQUT9euK51DxSf4/5X0AJY+64YlIBi8AzmNbDRVaKjHMIkOhhncUbAqCx L5kg== X-Gm-Message-State: AOJu0Yz+q9xg1eNu73IigC2tHSGK7sDQ9kK+CCWRKaAIaGspT5KV9eoe WKYRe+TgYG1AcbdqifcJIyX8XlBVMSgAx4tWV4CQlDBfTXsWLJzbqFm8b2xaVAVrRlQ0lF0c58m 3Wb/Ql5Q= X-Gm-Gg: ASbGnct8bqA+lV6G4EBi7x9PzO0Lb1VB6IEu2S/ZVRDWOoGXszZX9xQSKGu6XtiA2hm n3GiLsEpwFuZErcYIvQoRTZo8MCbtOUIG9vTHcXRG9B+vhlQPvHdf7pu3srlNrTPg7gJpI6ZuWi 66rE3c2LjYDZnz5qnD3aeajsp9luUywBTviE4srtUt8EekEVSZMpozUYl9ZqFkr9/xq4P10evbv sZ6kw050bKmM2TxRIp1+WDz86kWf9goBv7L4dfUVUvVANpufzGFCRUnEmN54bRkvdh8Z89Yb62U IASNsPDE+3xNMpXHvMHfPDrqrO2XBJ2AV8qS8G4m3gdeaATr/lgiqIYQlJt9oV/1jmZfYYpiVyb ozWIqBC7CC0A0MER7ai0BAUHTGVSKwIs7+Gekb2qixo6DGe6EBLISZ/ebh9qNqGV3hMQhKpLR/t JPNfkoZScu3E4mrUY85qwmv4fIGdSZVbQ2+V/q22gHAz86cd9kU4D4 X-Google-Smtp-Source: AGHT+IERdD1gnlE/+N25NZEPoxJE1f4Zzzvc3C7mpVwo7GjmMWwFjZ6LWPgmQKmEgUwLi7AFuCsVvA== X-Received: by 2002:a17:903:1547:b0:26d:f589:9cd7 with SMTP id d9443c01a7336-29027373c2bmr400563255ad.15.1760566628898; Wed, 15 Oct 2025 15:17:08 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29099afbdb5sm6674555ad.104.2025.10.15.15.17.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Oct 2025 15:17:08 -0700 (PDT) Date: Wed, 15 Oct 2025 15:17:00 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: dev@dpdk.org, thomas@monjalon.net Subject: Re: [PATCH v3 0/7] remove deprecated queue stats Message-ID: <20251015151700.09304190@hermes.local> In-Reply-To: <20251003110201.1541183-1-bruce.richardson@intel.com> References: <20250923141207.10403-1-bruce.richardson@intel.com> <20251003110201.1541183-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 3 Oct 2025 12:01:54 +0100 Bruce Richardson wrote: > NOTE: as called out below, on apply patches 3-6 should be squashed. They > are separated out here for easier review! > > Since DPDK 20.11 release, the use of queue stats inside the rte_eth_stats > structure has been deprecated with the intention to remove them. Sadly, > despite 5 years passing that has still not been done. This patchset > finally attempts to fix that situation and remove the queue stats fields. > > The biggest complication here is the fact that, as part of the deprecation, > a new driver flag was added which caused ethdev to automatically add the > queue stats into xstats. While this was good, in that it allowed quick use > of xstats for getting queue statistics, it now causes lots of problems > because we have 35 drivers (by a rough count using grep) which rely on this > functionality to export their queue stats via xstats. This means that if we > drop the queue stats fields from the regular stats structure, then 35 > drivers will lose *all* queue stats reporting functionality! This is not an > acceptable situation IMHO. [And in one patchset trying to change all 35 > drivers to directly export via xstats is not feasible either, since adding > extra xstats can be very complicated at times.] > > Therefore, we need to make changes that a) removes the queue fields from > the regular stats structure, while also b) continuing to allow the > individual driver stats_get functions return those stats to ethdev for > filling in. I tried a number of approaches here to find one that was most > feasible to implement for large numbers of drivers, so that either scripts > or AI assistants could automate a lot of the changes. The most feasible > approach I found was to define a DPDK-internal queue-stats-only structure, > which would be passed as a 3rd parameter to the drivers' stats_get > functions. When calling stats_get from ethdev, this third parameter would > be NULL, but for gathering xstats, it would be non-NULL for drivers which > have the RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS flag set. > > For this set, I've separated out the driver changes from the ethdev changes > and the app changes, since the driver changes are so numerous, making the > rest hard to review. In order to ensure clean compilation and git history, > patches 3 through 6 should be squashed into a single one on apply. > > Beyond these patches, more cleanup should/could be done: > * ensure that any drivers which don't set the AUTOFILL flag have the qstats > parameter set as __rte_unused. > * For those that do use the AUTOFILL flag, we should ensure that they > actually do fill in the stats, and not just set them to zero. (First two > patches here fix that for a couple of Intel drivers) > * then work to reduce the number of drivers which use the flag to set the > xstats, with a view to completely removing the queue stats from regular > stats functions. > > --- > > V3: > * added deprecation of the queue stats mapping functions at as final > patch at the end. > > Bruce Richardson (7): > net/ice: don't report empty queue xstats > net/ipn3ke: drop unsupported per-queue xstats > ethdev: remove queue stats from ethdev stats structure > drivers/net: update to remove queue stats from eth stats > app: remove queue stats from eth stats > doc: update docs for ethdev changes > ethdev: deprecate queue stats mapping functions > > app/proc-info/main.c | 16 --- > app/test-pmd/cmdline.c | 57 -------- > app/test-pmd/config.c | 36 ----- > app/test/virtual_pmd.c | 3 +- > config/rte_config.h | 1 - > doc/guides/rel_notes/deprecation.rst | 13 +- > doc/guides/rel_notes/release_25_11.rst | 6 + > drivers/net/af_packet/rte_eth_af_packet.c | 13 +- > drivers/net/af_xdp/rte_eth_af_xdp.c | 35 +++-- > drivers/net/ark/ark_ethdev.c | 36 +++-- > drivers/net/ark/ark_ethdev_rx.c | 14 +- > drivers/net/ark/ark_ethdev_rx.h | 3 +- > drivers/net/ark/ark_ethdev_tx.c | 12 +- > drivers/net/ark/ark_ethdev_tx.h | 3 +- > drivers/net/atlantic/atl_ethdev.c | 19 +-- > drivers/net/atlantic/atl_types.h | 1 + > drivers/net/avp/avp_ethdev.c | 20 ++- > drivers/net/axgbe/axgbe_ethdev.c | 22 +-- > drivers/net/axgbe/axgbe_ethdev.h | 1 + > drivers/net/bnx2x/bnx2x_ethdev.c | 3 +- > drivers/net/bnxt/bnxt_reps.c | 14 +- > drivers/net/bnxt/bnxt_reps.h | 2 +- > drivers/net/bnxt/bnxt_stats.c | 133 ++++++++++-------- > drivers/net/bnxt/bnxt_stats.h | 2 +- > drivers/net/bonding/rte_eth_bond_pmd.c | 14 +- > drivers/net/cnxk/cnxk_ethdev.h | 3 +- > drivers/net/cnxk/cnxk_rep.h | 3 +- > drivers/net/cnxk/cnxk_rep_ops.c | 15 +- > drivers/net/cnxk/cnxk_stats.c | 49 ++++--- > drivers/net/cxgbe/cxgbe_ethdev.c | 3 +- > drivers/net/cxgbe/cxgbevf_ethdev.c | 3 +- > drivers/net/dpaa/dpaa_ethdev.c | 3 +- > drivers/net/dpaa2/dpaa2_ethdev.c | 28 ++-- > drivers/net/ena/ena_ethdev.c | 46 +++--- > drivers/net/enetc/enetc_ethdev.c | 4 +- > drivers/net/enetfec/enet_ethdev.c | 3 +- > drivers/net/enic/enic.h | 3 +- > drivers/net/enic/enic_ethdev.c | 4 +- > drivers/net/enic/enic_main.c | 3 +- > drivers/net/enic/enic_vf_representor.c | 3 +- > drivers/net/failsafe/failsafe_ether.c | 9 -- > drivers/net/failsafe/failsafe_ops.c | 3 +- > drivers/net/gve/gve_ethdev.c | 4 +- > drivers/net/hinic/hinic_pmd_ethdev.c | 64 ++++++--- > drivers/net/hns3/hns3_stats.c | 4 +- > drivers/net/hns3/hns3_stats.h | 3 +- > drivers/net/intel/cpfl/cpfl_ethdev.c | 3 +- > drivers/net/intel/e1000/em_ethdev.c | 7 +- > drivers/net/intel/e1000/igb_ethdev.c | 14 +- > drivers/net/intel/e1000/igc_ethdev.c | 33 +++-- > drivers/net/intel/fm10k/fm10k_ethdev.c | 27 ++-- > drivers/net/intel/i40e/i40e_ethdev.c | 5 +- > drivers/net/intel/i40e/i40e_vf_representor.c | 2 +- > drivers/net/intel/iavf/iavf_ethdev.c | 5 +- > drivers/net/intel/ice/ice_dcf_ethdev.c | 3 +- > drivers/net/intel/ice/ice_ethdev.c | 7 +- > drivers/net/intel/idpf/idpf_ethdev.c | 3 +- > drivers/net/intel/ipn3ke/ipn3ke_representor.c | 14 +- > drivers/net/intel/ixgbe/ixgbe_ethdev.c | 29 ++-- > drivers/net/ionic/ionic_ethdev.c | 6 +- > drivers/net/ionic/ionic_lif.c | 35 +++-- > drivers/net/ionic/ionic_lif.h | 3 +- > drivers/net/mana/mana.c | 15 +- > drivers/net/memif/rte_eth_memif.c | 15 +- > drivers/net/mlx4/mlx4.h | 3 +- > drivers/net/mlx4/mlx4_ethdev.c | 17 +-- > drivers/net/mlx5/mlx5.h | 3 +- > drivers/net/mlx5/mlx5_stats.c | 17 +-- > drivers/net/mvneta/mvneta_ethdev.c | 5 +- > drivers/net/mvpp2/mrvl_ethdev.c | 23 +-- > drivers/net/netvsc/hn_ethdev.c | 17 +-- > drivers/net/netvsc/hn_var.h | 3 +- > drivers/net/netvsc/hn_vf.c | 3 +- > drivers/net/nfp/flower/nfp_flower.c | 8 +- > .../net/nfp/flower/nfp_flower_representor.c | 19 +-- > .../net/nfp/flower/nfp_flower_representor.h | 3 + > drivers/net/nfp/nfp_net_common.c | 46 +++--- > drivers/net/nfp/nfp_net_common.h | 4 +- > drivers/net/ngbe/ngbe_ethdev.c | 53 +++---- > drivers/net/ngbe/ngbe_ethdev_vf.c | 5 +- > drivers/net/ntnic/ntnic_ethdev.c | 22 +-- > drivers/net/null/rte_eth_null.c | 15 +- > drivers/net/octeon_ep/otx_ep_ethdev.c | 17 ++- > drivers/net/octeontx/octeontx_ethdev.c | 3 +- > drivers/net/pcap/pcap_ethdev.c | 23 +-- > drivers/net/pfe/pfe_ethdev.c | 3 +- > drivers/net/qede/qede_ethdev.c | 23 ++- > drivers/net/r8169/r8169_ethdev.c | 6 +- > drivers/net/ring/rte_eth_ring.c | 13 +- > drivers/net/rnp/rnp_ethdev.c | 15 +- > drivers/net/sfc/sfc_ethdev.c | 3 +- > drivers/net/sfc/sfc_repr.c | 3 +- > drivers/net/tap/rte_eth_tap.c | 23 +-- > drivers/net/thunderx/nicvf_ethdev.c | 27 ++-- > drivers/net/txgbe/txgbe_ethdev.c | 53 +++---- > drivers/net/txgbe/txgbe_ethdev_vf.c | 5 +- > drivers/net/vhost/rte_eth_vhost.c | 26 ++-- > drivers/net/virtio/virtio_ethdev.c | 23 +-- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 20 +-- > drivers/net/xsc/xsc_ethdev.c | 19 +-- > drivers/net/zxdh/zxdh_ethdev_ops.c | 39 ++--- > drivers/net/zxdh/zxdh_ethdev_ops.h | 3 +- > lib/ethdev/ethdev_driver.h | 35 ++++- > lib/ethdev/ethdev_private.c | 27 ++++ > lib/ethdev/ethdev_private.h | 5 + > lib/ethdev/rte_ethdev.c | 37 ++--- > lib/ethdev/rte_ethdev.h | 13 +- > lib/ethdev/rte_ethdev_telemetry.c | 20 +-- > 108 files changed, 921 insertions(+), 794 deletions(-) > > -- > 2.48.1 > LGTM Do you want me to fix the checkpatch stuff or do you want to send a new version.