DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	Sachin Saxena <sachin.saxena@nxp.com>
Subject: [RFT 1/3] net/dpaa2: remove unused frame array
Date: Wed, 15 Oct 2025 16:07:37 -0700	[thread overview]
Message-ID: <20251015230933.875860-2-stephen@networkplumber.org> (raw)
In-Reply-To: <20251015230933.875860-1-stephen@networkplumber.org>

The frame attribute variables were global but never used.
Tried making them local, but then compiler flags as unused
so remove them.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/dpaa2/dpaa2_sparser.c | 117 ------------------------------
 1 file changed, 117 deletions(-)

diff --git a/drivers/net/dpaa2/dpaa2_sparser.c b/drivers/net/dpaa2/dpaa2_sparser.c
index 265c9b5c57..0b3e9f1920 100644
--- a/drivers/net/dpaa2/dpaa2_sparser.c
+++ b/drivers/net/dpaa2/dpaa2_sparser.c
@@ -28,123 +28,6 @@ uint8_t wriop_bytecode[] = {
 	0x18, 0x00, 0x87, 0x3c, 0x00, 0x02, 0x18, 0x00, 0x00, 0x00
 };
 
-struct frame_attr frame_attr_arr[] = {
-	/* Frame Attribute Flags 1 */
-	/* 000 */ {"Routing header present in IPv6 header 2 ", 0, 0x80000000},
-	/* 001 */ {"GTP Primed was detected                 ", 0, 0x40000000},
-	/* 002 */ {"VLAN with VID = 0 was detected          ", 0, 0x20000000},
-	/* 003 */ {"A PTP frame was detected                ", 0, 0x10000000},
-	/* 004 */ {"VXLAN was parsed                        ", 0, 0x08000000},
-	/* 005 */ {"A VXLAN HXS parsing error was detected  ", 0, 0x04000000},
-	/* 006 */ {"Ethernet control protocol was detected  ", 0, 0x02000000},
-	/* 007 */ {"IKE was detected at UDP port 4500       ", 0, 0x01000000},
-	/* 008 */ {"Shim Shell Soft Parsing Error           ", 0, 0x00800000},
-	/* 009 */ {"Parsing Error                           ", 0, 0x00400000},
-	/* 010 */ {"Ethernet MAC Present                    ", 0, 0x00200000},
-	/* 011 */ {"Ethernet Unicast                        ", 0, 0x00100000},
-	/* 012 */ {"Ethernet Multicast                      ", 0, 0x00080000},
-	/* 013 */ {"Ethernet Broadcast                      ", 0, 0x00040000},
-	/* 014 */ {"BPDU frame (MAC DA is 01:80:C2:00:00:00)", 0, 0x00020000},
-	/* 015 */ {"FCoE detected (Ether type is 0x8906)    ", 0, 0x00010000},
-	/* 016 */ {"FIP detected (Ether type is 0x8914)     ", 0, 0x00008000},
-	/* 017 */ {"Ethernet Parsing Error                  ", 0, 0x00004000},
-	/* 018 */ {"LLC+SNAP Present                        ", 0, 0x00002000},
-	/* 019 */ {"Unknown LLC/OUI                         ", 0, 0x00001000},
-	/* 020 */ {"LLC+SNAP Error                          ", 0, 0x00000800},
-	/* 021 */ {"VLAN 1 Present                          ", 0, 0x00000400},
-	/* 022 */ {"VLAN n Present                          ", 0, 0x00000200},
-	/* 023 */ {"CFI bit in a \"8100\" VLAN tag is set   ", 0, 0x00000100},
-	/* 024 */ {"VLAN Parsing Error                      ", 0, 0x00000080},
-	/* 025 */ {"PPPoE+PPP Present                       ", 0, 0x00000040},
-	/* 026 */ {"PPPoE+PPP Parsing Error                 ", 0, 0x00000020},
-	/* 027 */ {"MPLS 1 Present                          ", 0, 0x00000010},
-	/* 028 */ {"MPLS n Present                          ", 0, 0x00000008},
-	/* 029 */ {"MPLS Parsing Error                      ", 0, 0x00000004},
-	/* 030 */ {"ARP frame Present (Ethertype 0x0806)    ", 0, 0x00000002},
-	/* 031 */ {"ARP Parsing Error                       ", 0, 0x00000001},
-	/* Frame Attribute Flags 2 */
-	/* 032 */ {"L2 Unknown Protocol                     ", 1, 0x80000000},
-	/* 033 */ {"L2 Soft Parsing Error                   ", 1, 0x40000000},
-	/* 034 */ {"IPv4 1 Present                          ", 1, 0x20000000},
-	/* 035 */ {"IPv4 1 Unicast                          ", 1, 0x10000000},
-	/* 036 */ {"IPv4 1 Multicast                        ", 1, 0x08000000},
-	/* 037 */ {"IPv4 1 Broadcast                        ", 1, 0x04000000},
-	/* 038 */ {"IPv4 n Present                          ", 1, 0x02000000},
-	/* 039 */ {"IPv4 n Unicast                          ", 1, 0x01000000},
-	/* 040 */ {"IPv4 n Multicast                        ", 1, 0x00800000},
-	/* 041 */ {"IPv4 n Broadcast                        ", 1, 0x00400000},
-	/* 042 */ {"IPv6 1 Present                          ", 1, 0x00200000},
-	/* 043 */ {"IPv6 1 Unicast                          ", 1, 0x00100000},
-	/* 044 */ {"IPv6 1 Multicast                        ", 1, 0x00080000},
-	/* 045 */ {"IPv6 n Present                          ", 1, 0x00040000},
-	/* 046 */ {"IPv6 n Unicast                          ", 1, 0x00020000},
-	/* 047 */ {"IPv6 n Multicast                        ", 1, 0x00010000},
-	/* 048 */ {"IP 1 option present                     ", 1, 0x00008000},
-	/* 049 */ {"IP 1 Unknown Protocol                   ", 1, 0x00004000},
-	/* 050 */ {"IP 1 Packet is a fragment               ", 1, 0x00002000},
-	/* 051 */ {"IP 1 Packet is an initial fragment      ", 1, 0x00001000},
-	/* 052 */ {"IP 1 Parsing Error                      ", 1, 0x00000800},
-	/* 053 */ {"IP n option present                     ", 1, 0x00000400},
-	/* 054 */ {"IP n Unknown Protocol                   ", 1, 0x00000200},
-	/* 055 */ {"IP n Packet is a fragment               ", 1, 0x00000100},
-	/* 056 */ {"IP n Packet is an initial fragment      ", 1, 0x00000080},
-	/* 057 */ {"ICMP detected (IP proto is 1)           ", 1, 0x00000040},
-	/* 058 */ {"IGMP detected (IP proto is 2)           ", 1, 0x00000020},
-	/* 059 */ {"ICMPv6 detected (IP proto is 3a)        ", 1, 0x00000010},
-	/* 060 */ {"UDP Light detected (IP proto is 136)    ", 1, 0x00000008},
-	/* 061 */ {"IP n Parsing Error                      ", 1, 0x00000004},
-	/* 062 */ {"Min. Encap Present                      ", 1, 0x00000002},
-	/* 063 */ {"Min. Encap S flag set                   ", 1, 0x00000001},
-	/* Frame Attribute Flags 3 */
-	/* 064 */ {"Min. Encap Parsing Error                ", 2, 0x80000000},
-	/* 065 */ {"GRE Present                             ", 2, 0x40000000},
-	/* 066 */ {"GRE R bit set                           ", 2, 0x20000000},
-	/* 067 */ {"GRE Parsing Error                       ", 2, 0x10000000},
-	/* 068 */ {"L3 Unknown Protocol                     ", 2, 0x08000000},
-	/* 069 */ {"L3 Soft Parsing Error                   ", 2, 0x04000000},
-	/* 070 */ {"UDP Present                             ", 2, 0x02000000},
-	/* 071 */ {"UDP Parsing Error                       ", 2, 0x01000000},
-	/* 072 */ {"TCP Present                             ", 2, 0x00800000},
-	/* 073 */ {"TCP options present                     ", 2, 0x00400000},
-	/* 074 */ {"TCP Control bits 6-11 set               ", 2, 0x00200000},
-	/* 075 */ {"TCP Control bits 3-5 set                ", 2, 0x00100000},
-	/* 076 */ {"TCP Parsing Error                       ", 2, 0x00080000},
-	/* 077 */ {"IPSec Present                           ", 2, 0x00040000},
-	/* 078 */ {"IPSec ESP found                         ", 2, 0x00020000},
-	/* 079 */ {"IPSec AH found                          ", 2, 0x00010000},
-	/* 080 */ {"IPSec Parsing Error                     ", 2, 0x00008000},
-	/* 081 */ {"SCTP Present                            ", 2, 0x00004000},
-	/* 082 */ {"SCTP Parsing Error                      ", 2, 0x00002000},
-	/* 083 */ {"DCCP Present                            ", 2, 0x00001000},
-	/* 084 */ {"DCCP Parsing Error                      ", 2, 0x00000800},
-	/* 085 */ {"L4 Unknown Protocol                     ", 2, 0x00000400},
-	/* 086 */ {"L4 Soft Parsing Error                   ", 2, 0x00000200},
-	/* 087 */ {"GTP Present                             ", 2, 0x00000100},
-	/* 088 */ {"GTP Parsing Error                       ", 2, 0x00000080},
-	/* 089 */ {"ESP Present                             ", 2, 0x00000040},
-	/* 090 */ {"ESP Parsing Error                       ", 2, 0x00000020},
-	/* 091 */ {"iSCSI detected (Port# 860)              ", 2, 0x00000010},
-	/* 092 */ {"Capwap-control detected (Port# 5246)    ", 2, 0x00000008},
-	/* 093 */ {"Capwap-data detected (Port# 5247)       ", 2, 0x00000004},
-	/* 094 */ {"L5 Soft Parsing Error                   ", 2, 0x00000002},
-	/* 095 */ {"IPv6 Route hdr1 present                 ", 2, 0x00000001},
-	/* 096 */ {NULL,                                       0, 0x00000000}
-};
-
-struct frame_attr_ext frame_attr_ext_arr[] = {
-	/* Frame Attribute Flags Extension */
-	/* 096 */ {"User defined soft parser bit #0         ", 0, 0x8000},
-	/* 096 */ {"User defined soft parser bit #1         ", 0, 0x4000},
-	/* 096 */ {"User defined soft parser bit #2         ", 0, 0x2000},
-	/* 096 */ {"User defined soft parser bit #3         ", 0, 0x1000},
-	/* 096 */ {"User defined soft parser bit #4         ", 0, 0x0800},
-	/* 096 */ {"User defined soft parser bit #5         ", 0, 0x0400},
-	/* 096 */ {"User defined soft parser bit #6         ", 0, 0x0200},
-	/* 096 */ {"User defined soft parser bit #7         ", 0, 0x0100},
-	/* 097 */ {"Reserved                                ", 0, 0x00ff},
-	/* 112 */ {NULL,                                       0, 0x0000}
-};
-
 int dpaa2_eth_load_wriop_soft_parser(struct dpaa2_dev_priv *priv,
 				     enum dpni_soft_sequence_dest dest)
 {
-- 
2.47.3


  reply	other threads:[~2025-10-15 23:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15 23:07 [RFT 0/3] net/dpaa2: global symbol fixes Stephen Hemminger
2025-10-15 23:07 ` Stephen Hemminger [this message]
2025-10-15 23:07 ` [RFT 2/3] net/dpaa2: make local array static Stephen Hemminger
2025-10-15 23:07 ` [RFT 3/3] net/dpaa2: make total rx descriptors per device Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251015230933.875860-2-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=sachin.saxena@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).