From: Manish Kurup <manish.kurup@broadcom.com>
To: dev@dpdk.org
Cc: ajit.khaparde@broadcom.com,
Kishore Padmanabha <kishore.padmanabha@broadcom.com>
Subject: [PATCH v4 44/57] net/bnxt: fix rss configuration when set to none
Date: Tue, 21 Oct 2025 14:56:48 -0400 [thread overview]
Message-ID: <20251021185701.71881-13-manish.kurup@broadcom.com> (raw)
In-Reply-To: <20251021185701.71881-1-manish.kurup@broadcom.com>
From: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
If the rss hash type is set to none and the ports are stopped and
started again, the check for rss hash type was not allowing the
bnxt driver to populate the correct rx rings in the vnic rss list.
This causes the subsequent calls to rss configuration fail since
the rss list is not configured and have stale data causing the
firmware to reject the rss configuration.
The rss hash type of none should not be ignored during configuration,
it is a valid configuration and should be applied. When rss hash
type is none, the rss context is disabled and there should be no
rss algorithm applied to the incoming traffic.
Signed-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/bnxt_hwrm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 00b02821c9..939f35e3da 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -6331,7 +6331,7 @@ int bnxt_vnic_rss_configure(struct bnxt *bp, struct bnxt_vnic_info *vnic)
if (vnic->fw_vnic_id == INVALID_HW_RING_ID)
return 0;
- if (!(vnic->rss_table && vnic->hash_type))
+ if (vnic->rss_table == NULL)
return 0;
if (BNXT_CHIP_P5_P7(bp))
--
2.39.5 (Apple Git-154)
next prev parent reply other threads:[~2025-10-21 18:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 18:56 [PATCH v4 32/57] net/bnxt/tf_core: add backing store debug to dpdk Manish Kurup
2025-10-21 18:56 ` [PATCH v4 33/57] net/bnxt/tf_core: truflow global table scope Manish Kurup
2025-10-21 18:56 ` [PATCH v4 34/57] net/bnxt/tf_ulp: ulp parser support to handle gre key Manish Kurup
2025-10-21 18:56 ` [PATCH v4 35/57] net/bnxt/tf_core: handle out of order MPC completions Manish Kurup
2025-10-21 18:56 ` [PATCH v4 36/57] net/bnxt/tf_ulp: socket direct enable Manish Kurup
2025-10-21 18:56 ` [PATCH v4 37/57] net/bnxt: fix adding udp_tunnel_port Manish Kurup
2025-10-21 18:56 ` [PATCH v4 38/57] net/bnxt/tf_ulp: add non vfr mode capability Manish Kurup
2025-10-21 18:56 ` [PATCH v4 39/57] net/bnxt: avoid iova range check when external memory is used Manish Kurup
2025-10-21 18:56 ` [PATCH v4 40/57] net/bnxt: avoid potential segfault in VFR handling Manish Kurup
2025-10-21 18:56 ` [PATCH v4 41/57] net/bnxt/tf_ulp: change rte_mem_virt2iova to rte_mem_virt2phys Manish Kurup
2025-10-21 18:56 ` [PATCH v4 42/57] net/bnxt: thor2 truflow memory manager bug Manish Kurup
2025-10-21 18:56 ` [PATCH v4 43/57] net/bnxt: fix stats collection when rx queue is not set Manish Kurup
2025-10-21 18:56 ` Manish Kurup [this message]
2025-10-21 18:56 ` [PATCH v4 45/57] net/bnxt: packet drop after port stop and start Manish Kurup
2025-10-21 18:56 ` [PATCH v4 46/57] net/bnxt/tf_core: fix truflow crash on memory allocation failure Manish Kurup
2025-10-21 18:56 ` [PATCH v4 47/57] net/bnxt: truflow remove RTE devarg processing for mpc=1 Manish Kurup
2025-10-21 18:56 ` [PATCH v4 48/57] net/bnxt: add meson build options for TruFlow Manish Kurup
2025-10-21 18:56 ` [PATCH v4 49/57] net/bnxt: truflow HSI struct fixes Manish Kurup
2025-10-21 18:56 ` [PATCH v4 50/57] net/bnxt/tf_ulp: truflow add pf action handler Manish Kurup
2025-10-21 18:56 ` [PATCH v4 51/57] net/bnxt/tf_ulp: add support for unicast only feature Manish Kurup
2025-10-21 18:56 ` [PATCH v4 52/57] net/bnxt/tf_core: remove excessive debug logging Manish Kurup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021185701.71881-13-manish.kurup@broadcom.com \
--to=manish.kurup@broadcom.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=kishore.padmanabha@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).