From: Manish Kurup <manish.kurup@broadcom.com>
To: dev@dpdk.org
Cc: ajit.khaparde@broadcom.com,
Farah Smith <farah.smith@broadcom.com>,
Kishore Padmanabha <kishore.padmanabha@broadcom.com>
Subject: [PATCH v4 36/57] net/bnxt/tf_ulp: socket direct enable
Date: Tue, 21 Oct 2025 14:56:40 -0400 [thread overview]
Message-ID: <20251021185701.71881-5-manish.kurup@broadcom.com> (raw)
In-Reply-To: <20251021185701.71881-1-manish.kurup@broadcom.com>
From: Farah Smith <farah.smith@broadcom.com>
1. Remove code which requires multi-root to be configured in order for
the socket direct feature be enabled. This is not required and was
a customer specific implementation.
2. Always enable the global table scope for Thor2 when the socket
direct feature is enabled.
3. Remove global table scope feature bit.
Signed-off-by: Farah Smith <farah.smith@broadcom.com>
Reviewed-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
---
drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c | 12 +++---------
drivers/net/bnxt/tf_ulp/bnxt_ulp_tfc.c | 16 ++++------------
drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h | 5 +++--
3 files changed, 10 insertions(+), 23 deletions(-)
diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c
index e3eb9107ab..de87ce0349 100644
--- a/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c
+++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c
@@ -420,15 +420,9 @@ ulp_tf_cntxt_app_caps_init(struct bnxt *bp,
if (info[i].flags & BNXT_ULP_APP_CAP_BC_MC_SUPPORT)
ulp_ctx->cfg_data->ulp_flags |=
BNXT_ULP_APP_BC_MC_SUPPORT;
- if (info[i].flags & BNXT_ULP_APP_CAP_SOCKET_DIRECT) {
- /* Enable socket direction only if MR is enabled in fw*/
- if (BNXT_MULTIROOT_EN(bp)) {
- ulp_ctx->cfg_data->ulp_flags |=
- BNXT_ULP_APP_SOCKET_DIRECT;
- BNXT_DRV_DBG(INFO,
- "Socket Direct feature is enabled\n");
- }
- }
+ if (info[i].flags & BNXT_ULP_APP_CAP_SOCKET_DIRECT)
+ ulp_ctx->cfg_data->ulp_flags |=
+ BNXT_ULP_APP_SOCKET_DIRECT;
if (info[i].flags & BNXT_ULP_APP_CAP_HA_DYNAMIC) {
/* Read the environment variable to determine hot up */
if (!bnxt_pmd_get_hot_up_config()) {
diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp_tfc.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp_tfc.c
index 65df4ecd79..772dd69035 100644
--- a/drivers/net/bnxt/tf_ulp/bnxt_ulp_tfc.c
+++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp_tfc.c
@@ -553,18 +553,10 @@ ulp_tfc_cntxt_app_caps_init(struct bnxt *bp, uint8_t app_id, uint32_t dev_id)
if (info[i].flags & BNXT_ULP_APP_CAP_BC_MC_SUPPORT)
ulp_ctx->cfg_data->ulp_flags |=
BNXT_ULP_APP_BC_MC_SUPPORT;
- if (info[i].flags & BNXT_ULP_APP_CAP_SOCKET_DIRECT) {
- /* Enable socket direction only if MR is enabled in fw*/
- if (BNXT_MULTIROOT_EN(bp)) {
- ulp_ctx->cfg_data->ulp_flags |=
- BNXT_ULP_APP_SOCKET_DIRECT;
- BNXT_DRV_DBG(DEBUG,
- "Socket Direct feature is enabled");
- } else {
- BNXT_DRV_DBG(DEBUG,
- "No Socket Direct feature - must enable multiroot");
- }
- }
+ if (info[i].flags & BNXT_ULP_APP_CAP_SOCKET_DIRECT)
+ ulp_ctx->cfg_data->ulp_flags |=
+ BNXT_ULP_APP_SOCKET_DIRECT;
+
/* Update the capability feature bits*/
if (bnxt_ulp_cap_feat_process(info[i].feature_bits,
&ulp_ctx->cfg_data->feature_bits))
diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h b/drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h
index c3f3bcd59d..c46340b1a4 100644
--- a/drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h
+++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h
@@ -1061,8 +1061,9 @@ bnxt_ulp_cap_feat_process(uint64_t feat_bits, uint64_t *out_bits)
if (bit & BNXT_ULP_FEATURE_BIT_SPECIAL_VXLAN)
BNXT_DRV_DBG(ERR, "Special VXLAN Feature is enabled\n");
if (bit & BNXT_ULP_FEATURE_BIT_HOT_UPGRADE)
- BNXT_DRV_DBG(ERR, "Hot Upgrade Feature is enabled\n");
-
+ BNXT_DRV_DBG(ERR, "Hot Upgrade Feature is enabled");
+ if (bit & BNXT_ULP_FEATURE_BIT_SOCKET_DIRECT)
+ BNXT_DRV_DBG(ERR, "Socket Direct Feature is enabled");
*out_bits = bit;
return 0;
}
--
2.39.5 (Apple Git-154)
next prev parent reply other threads:[~2025-10-21 18:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 18:56 [PATCH v4 32/57] net/bnxt/tf_core: add backing store debug to dpdk Manish Kurup
2025-10-21 18:56 ` [PATCH v4 33/57] net/bnxt/tf_core: truflow global table scope Manish Kurup
2025-10-21 18:56 ` [PATCH v4 34/57] net/bnxt/tf_ulp: ulp parser support to handle gre key Manish Kurup
2025-10-21 18:56 ` [PATCH v4 35/57] net/bnxt/tf_core: handle out of order MPC completions Manish Kurup
2025-10-21 18:56 ` Manish Kurup [this message]
2025-10-21 18:56 ` [PATCH v4 37/57] net/bnxt: fix adding udp_tunnel_port Manish Kurup
2025-10-21 18:56 ` [PATCH v4 38/57] net/bnxt/tf_ulp: add non vfr mode capability Manish Kurup
2025-10-21 18:56 ` [PATCH v4 39/57] net/bnxt: avoid iova range check when external memory is used Manish Kurup
2025-10-21 18:56 ` [PATCH v4 40/57] net/bnxt: avoid potential segfault in VFR handling Manish Kurup
2025-10-21 18:56 ` [PATCH v4 41/57] net/bnxt/tf_ulp: change rte_mem_virt2iova to rte_mem_virt2phys Manish Kurup
2025-10-21 18:56 ` [PATCH v4 42/57] net/bnxt: thor2 truflow memory manager bug Manish Kurup
2025-10-21 18:56 ` [PATCH v4 43/57] net/bnxt: fix stats collection when rx queue is not set Manish Kurup
2025-10-21 18:56 ` [PATCH v4 44/57] net/bnxt: fix rss configuration when set to none Manish Kurup
2025-10-21 18:56 ` [PATCH v4 45/57] net/bnxt: packet drop after port stop and start Manish Kurup
2025-10-21 18:56 ` [PATCH v4 46/57] net/bnxt/tf_core: fix truflow crash on memory allocation failure Manish Kurup
2025-10-21 18:56 ` [PATCH v4 47/57] net/bnxt: truflow remove RTE devarg processing for mpc=1 Manish Kurup
2025-10-21 18:56 ` [PATCH v4 48/57] net/bnxt: add meson build options for TruFlow Manish Kurup
2025-10-21 18:56 ` [PATCH v4 49/57] net/bnxt: truflow HSI struct fixes Manish Kurup
2025-10-21 18:56 ` [PATCH v4 50/57] net/bnxt/tf_ulp: truflow add pf action handler Manish Kurup
2025-10-21 18:56 ` [PATCH v4 51/57] net/bnxt/tf_ulp: add support for unicast only feature Manish Kurup
2025-10-21 18:56 ` [PATCH v4 52/57] net/bnxt/tf_core: remove excessive debug logging Manish Kurup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021185701.71881-5-manish.kurup@broadcom.com \
--to=manish.kurup@broadcom.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=farah.smith@broadcom.com \
--cc=kishore.padmanabha@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).