DPDK patches and discussions
 help / color / mirror / Atom feed
From: Manish Kurup <manish.kurup@broadcom.com>
To: dev@dpdk.org
Cc: ajit.khaparde@broadcom.com,
	Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
	Andy Gospodarek <andrew.gospodarek@broadcom.com>,
	Ning Wang <ning-nw.wang@broadcom.com>,
	Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,
	Somnath Kotur <somnath.kotur@broadcom.com>
Subject: [PATCH v4 39/57] net/bnxt: avoid iova range check when external memory is used
Date: Tue, 21 Oct 2025 14:56:43 -0400	[thread overview]
Message-ID: <20251021185701.71881-8-manish.kurup@broadcom.com> (raw)
In-Reply-To: <20251021185701.71881-1-manish.kurup@broadcom.com>

From: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>

The function checks if the iova is in the valid range. But this check
is not relevant to external memory; avoid it when external memory is
in use.

Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Reviewed-by: Andy Gospodarek <andrew.gospodarek@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Ning Wang <ning-nw.wang@broadcom.com>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
 drivers/net/bnxt/bnxt_txr.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c
index f88e214790..27758898b0 100644
--- a/drivers/net/bnxt/bnxt_txr.c
+++ b/drivers/net/bnxt/bnxt_txr.c
@@ -221,8 +221,9 @@ static int bnxt_invalid_mbuf(struct rte_mbuf *mbuf)
 	if (unlikely(rte_mbuf_check(mbuf, 1, &reason)))
 		return -EINVAL;
 
-	if (unlikely(mbuf->buf_iova < mbuf_size ||
-		     (mbuf->buf_iova != rte_mempool_virt2iova(mbuf) + mbuf_size)))
+	if (unlikely(!(mbuf->ol_flags & RTE_MBUF_F_EXTERNAL) &&
+		     (mbuf->buf_iova < mbuf_size ||
+		      (mbuf->buf_iova != rte_mempool_virt2iova(mbuf) + mbuf_size))))
 		return -EINVAL;
 
 	return 0;
-- 
2.39.5 (Apple Git-154)


  parent reply	other threads:[~2025-10-21 18:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-21 18:56 [PATCH v4 32/57] net/bnxt/tf_core: add backing store debug to dpdk Manish Kurup
2025-10-21 18:56 ` [PATCH v4 33/57] net/bnxt/tf_core: truflow global table scope Manish Kurup
2025-10-21 18:56 ` [PATCH v4 34/57] net/bnxt/tf_ulp: ulp parser support to handle gre key Manish Kurup
2025-10-21 18:56 ` [PATCH v4 35/57] net/bnxt/tf_core: handle out of order MPC completions Manish Kurup
2025-10-21 18:56 ` [PATCH v4 36/57] net/bnxt/tf_ulp: socket direct enable Manish Kurup
2025-10-21 18:56 ` [PATCH v4 37/57] net/bnxt: fix adding udp_tunnel_port Manish Kurup
2025-10-21 18:56 ` [PATCH v4 38/57] net/bnxt/tf_ulp: add non vfr mode capability Manish Kurup
2025-10-21 18:56 ` Manish Kurup [this message]
2025-10-21 18:56 ` [PATCH v4 40/57] net/bnxt: avoid potential segfault in VFR handling Manish Kurup
2025-10-21 18:56 ` [PATCH v4 41/57] net/bnxt/tf_ulp: change rte_mem_virt2iova to rte_mem_virt2phys Manish Kurup
2025-10-21 18:56 ` [PATCH v4 42/57] net/bnxt: thor2 truflow memory manager bug Manish Kurup
2025-10-21 18:56 ` [PATCH v4 43/57] net/bnxt: fix stats collection when rx queue is not set Manish Kurup
2025-10-21 18:56 ` [PATCH v4 44/57] net/bnxt: fix rss configuration when set to none Manish Kurup
2025-10-21 18:56 ` [PATCH v4 45/57] net/bnxt: packet drop after port stop and start Manish Kurup
2025-10-21 18:56 ` [PATCH v4 46/57] net/bnxt/tf_core: fix truflow crash on memory allocation failure Manish Kurup
2025-10-21 18:56 ` [PATCH v4 47/57] net/bnxt: truflow remove RTE devarg processing for mpc=1 Manish Kurup
2025-10-21 18:56 ` [PATCH v4 48/57] net/bnxt: add meson build options for TruFlow Manish Kurup
2025-10-21 18:56 ` [PATCH v4 49/57] net/bnxt: truflow HSI struct fixes Manish Kurup
2025-10-21 18:56 ` [PATCH v4 50/57] net/bnxt/tf_ulp: truflow add pf action handler Manish Kurup
2025-10-21 18:56 ` [PATCH v4 51/57] net/bnxt/tf_ulp: add support for unicast only feature Manish Kurup
2025-10-21 18:56 ` [PATCH v4 52/57] net/bnxt/tf_core: remove excessive debug logging Manish Kurup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251021185701.71881-8-manish.kurup@broadcom.com \
    --to=manish.kurup@broadcom.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=andrew.gospodarek@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=kalesh-anakkur.purayil@broadcom.com \
    --cc=ning-nw.wang@broadcom.com \
    --cc=somnath.kotur@broadcom.com \
    --cc=sriharsha.basavapatna@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).