DPDK patches and discussions
 help / color / mirror / Atom feed
From: Andrew Bailey <abailey@iol.unh.edu>
To: luca.vizzarro@arm.com
Cc: abailey@iol.unh.edu, dev@dpdk.org, dmarx@iol.unh.edu, probb@iol.unh.edu
Subject: [PATCH v9 3/3] dts: add Rx Tx offload test suite
Date: Thu, 23 Oct 2025 08:32:23 -0400	[thread overview]
Message-ID: <20251023123223.56924-4-abailey@iol.unh.edu> (raw)
In-Reply-To: <20251023123223.56924-1-abailey@iol.unh.edu>

Add mbuf_fast_free portion of rxtx offload testsuite from legacy dts
to next dts. The testsuite expects mbuf fast free to be enabled by
default and verifies configuration of this Tx offload capability.

Signed-off-by: Andrew Bailey <abailey@iol.unh.edu>
---
 doc/api/dts/tests.TestSuite_rx_tx_offload.rst |  8 +++++
 dts/tests/TestSuite_rx_tx_offload.py          | 35 +++++++++++--------
 2 files changed, 28 insertions(+), 15 deletions(-)
 create mode 100644 doc/api/dts/tests.TestSuite_rx_tx_offload.rst

diff --git a/doc/api/dts/tests.TestSuite_rx_tx_offload.rst b/doc/api/dts/tests.TestSuite_rx_tx_offload.rst
new file mode 100644
index 0000000000..27834a74da
--- /dev/null
+++ b/doc/api/dts/tests.TestSuite_rx_tx_offload.rst
@@ -0,0 +1,8 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+
+rx_tx_offload Test Suite
+========================
+
+.. automodule:: tests.TestSuite_rx_tx_offload
+   :members:
+   :show-inheritance:
diff --git a/dts/tests/TestSuite_rx_tx_offload.py b/dts/tests/TestSuite_rx_tx_offload.py
index 16e1b8cf93..0d0043122d 100644
--- a/dts/tests/TestSuite_rx_tx_offload.py
+++ b/dts/tests/TestSuite_rx_tx_offload.py
@@ -27,9 +27,8 @@ def _check_config(
         rxtx: RxTxLiteralSwitch,
         /,
         queue_offload: list[str | None] | None = None,
-        verify: bool = True,
     ) -> bool:
-        config: OffloadConfiguration = testpmd.get_offload_config(port_id, rxtx, verify)
+        config: OffloadConfiguration = testpmd.get_offload_config(port_id, rxtx)
         if config.port.name != port_offload:
             return False
 
@@ -40,7 +39,11 @@ def _check_config(
         return True
 
     def _set_all_queues_mbuf_fast_free(
-        self, testpmd: TestPmd, port_id: int, on: bool, num_queues: int, /, verify: bool = True
+        self,
+        testpmd: TestPmd,
+        port_id: int,
+        on: bool,
+        num_queues: int,
     ) -> None:
         for i in range(num_queues):
             testpmd.set_queue_mbuf_fast_free(on, port_id, i, verify)
@@ -61,25 +64,24 @@ def test_mbuf_fast_free_configuration_per_port(self) -> None:
             * Mbuf_fast_free can be configured on per port.
         """
         with TestPmd() as testpmd:
-            to_verify = True
             port_id = 0
             testpmd.start_all_ports()
 
             # Ensure MBUF_FAST_FREE is enabled by default and verify
             verify(
-                self._check_config(testpmd, port_id, "MBUF_FAST_FREE", "tx", verify=to_verify),
+                self._check_config(testpmd, port_id, "MBUF_FAST_FREE", "tx"),
                 "MBUF_FAST_FREE disabled on port start.",
             )
             # disable MBUF_FAST_FREE per port and verify
-            testpmd.set_port_mbuf_fast_free(port_id, False, to_verify)
+            testpmd.set_port_mbuf_fast_free(port_id, False)
             verify(
-                self._check_config(testpmd, port_id, None, "tx", verify=to_verify),
+                self._check_config(testpmd, port_id, None, "tx"),
                 "Failed to enable MBUF_FAST_FREE on port.",
             )
             # Enable MBUF_FAST_FREE per port and verify
-            testpmd.set_port_mbuf_fast_free(port_id, True, to_verify)
+            testpmd.set_port_mbuf_fast_free(port_id, True)
             verify(
-                self._check_config(testpmd, port_id, "MBUF_FAST_FREE", "tx", verify=to_verify),
+                self._check_config(testpmd, port_id, "MBUF_FAST_FREE", "tx"),
                 "Failed to disable MBUF_FAST_FREE on port.",
             )
 
@@ -99,7 +101,6 @@ def test_mbuf_fast_free_configuration_per_queue(self) -> None:
             * Mbuf_fast_free can be configured on per queue.
         """
         with TestPmd() as testpmd:
-            to_verify = True
             port_id = 0
             num_queues = 4
             queue_off: list[str | None] | None = [None] * num_queues
@@ -111,19 +112,23 @@ def test_mbuf_fast_free_configuration_per_queue(self) -> None:
             # Ensure mbuf_fast_free is enabled by default on port and queues
             verify(
                 self._check_config(
-                    testpmd, port_id, "MBUF_FAST_FREE", "tx", queue_on, verify=to_verify
+                    testpmd,
+                    port_id,
+                    "MBUF_FAST_FREE",
+                    "tx",
+                    queue_on,
                 ),
                 "MBUF_FAST_FREE disabled on queue start.",
             )
             # Disable mbuf_fast_free per queue and verify
-            self._set_all_queues_mbuf_fast_free(testpmd, port_id, False, num_queues, to_verify)
+            self._set_all_queues_mbuf_fast_free(testpmd, port_id, False, num_queues)
             verify(
-                self._check_config(testpmd, port_id, "MBUF_FAST_FREE", "tx", queue_off, to_verify),
+                self._check_config(testpmd, port_id, "MBUF_FAST_FREE", "tx", queue_off),
                 "Failed to disable MBUF_FAST_FREE on all queues.",
             )
             # Disable mbuf_fast_free per queue and verify
-            self._set_all_queues_mbuf_fast_free(testpmd, port_id, True, num_queues, to_verify)
+            self._set_all_queues_mbuf_fast_free(testpmd, port_id, True, num_queues)
             verify(
-                self._check_config(testpmd, port_id, "MBUF_FAST_FREE", "tx", queue_on, to_verify),
+                self._check_config(testpmd, port_id, "MBUF_FAST_FREE", "tx", queue_on),
                 "Failed to enable MBUF_FAST_FREE on all queues.",
             )
-- 
2.50.1


  parent reply	other threads:[~2025-10-23 12:33 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-02 11:43 [PATCH v1 0/3] dts: add tx_offload support in dts Andrew Bailey
2025-09-02 11:43 ` [PATCH v1 1/3] dts: fix docstring typo in checksum suite Andrew Bailey
2025-09-02 11:43 ` [PATCH v1 2/3] dts: add reception check to checksum offload suite Andrew Bailey
2025-09-02 11:43 ` [PATCH v1 3/3] dts: all are one Andrew Bailey
2025-09-02 11:48 ` [PATCH v1 0/3] dts: add tx_offload support in dts Andrew Bailey
2025-09-24 16:47 ` [PATCH v4 0/3] dts:add " Andrew Bailey
2025-09-24 16:47   ` [PATCH v4 1/3] dts: allow mbuf_fast_free to be set with testpmd shell Andrew Bailey
2025-09-24 20:51     ` Patrick Robb
2025-09-25 16:01     ` Luca Vizzarro
2025-09-24 16:47   ` [PATCH v4 2/3] dts: add TX offload capabilities to NIC capabilities Andrew Bailey
2025-09-24 20:51     ` Patrick Robb
2025-09-25 16:05     ` Luca Vizzarro
2025-09-24 16:47   ` [PATCH v4 3/3] dts: update tx_offload test from old dts Andrew Bailey
2025-09-24 20:53     ` Patrick Robb
2025-09-29 17:06 ` [PATCH v5 0/3] dts: add tx_offload support in dts Andrew Bailey
2025-09-29 17:06   ` [PATCH v5 1/3] dts: allow mbuf_fast_free to be set with testpmd shell Andrew Bailey
2025-09-29 17:06   ` [PATCH v5 3/3] dts: update tx_offload test from old dts Andrew Bailey
2025-10-15 15:34     ` Patrick Robb
2025-09-29 17:27 ` [PATCH v6 0/3] dts: add tx_offload support in dts Andrew Bailey
2025-09-29 17:27   ` [PATCH v6 1/3] dts: allow mbuf_fast_free to be set with testpmd shell Andrew Bailey
2025-09-30 12:51     ` Luca Vizzarro
2025-10-09 15:53     ` Dean Marx
2025-09-29 17:27   ` [PATCH v6 2/3] dts: add TX offload capabilities to NIC capabilities Andrew Bailey
2025-09-30 12:55     ` Luca Vizzarro
2025-10-09 15:55     ` Dean Marx
2025-09-29 17:27   ` [PATCH v6 3/3] dts: update tx_offload test from old dts Andrew Bailey
2025-09-30 12:57     ` Luca Vizzarro
2025-10-09 15:56     ` Dean Marx
2025-10-16 13:24 ` [PATCH v7 0/3] add tx_offload support in dts Andrew Bailey
2025-10-16 13:24   ` [PATCH v7 1/3] dts: allow mbuf_fast_free to be set with testpmd shell Andrew Bailey
2025-10-21 13:28     ` Luca Vizzarro
2025-10-16 13:24   ` [PATCH v7 2/3] dts: add TX offload capabilities to NIC capabilities Andrew Bailey
2025-10-21 13:50     ` Luca Vizzarro
2025-10-16 13:24   ` [PATCH v7 3/3] dts: update tx_offload test from legacy dts to next dts Andrew Bailey
2025-10-21 13:51     ` Luca Vizzarro
2025-10-21 14:45 ` [PATCH v8 0/3] dts: add tx_offload support in dts Andrew Bailey
2025-10-21 14:45   ` [PATCH v8 1/3] dts: allow mbuf_fast_free to be set with testpmd shell Andrew Bailey
2025-10-21 15:15     ` Luca Vizzarro
2025-10-21 15:27     ` Luca Vizzarro
2025-10-21 14:45   ` [PATCH v8 2/3] dts: add TX offload capabilities to NIC capabilities Andrew Bailey
2025-10-21 15:19     ` Luca Vizzarro
2025-10-21 15:29     ` Luca Vizzarro
2025-10-21 14:45   ` [PATCH v8 3/3] dts: update tx_offload test from legacy dts to next dts Andrew Bailey
2025-10-21 15:31     ` Luca Vizzarro
     [not found] ` <20251023123223.56924-1-abailey@iol.unh.edu>
2025-10-23 12:32   ` [PATCH v9 1/3] dts: allow mbuf fast free to be set with testpmd shell Andrew Bailey
2025-10-24 19:20     ` Patrick Robb
2025-10-23 12:32   ` [PATCH v9 2/3] dts: add Tx offload capabilities to NIC capabilities Andrew Bailey
2025-10-23 12:32   ` Andrew Bailey [this message]
2025-10-24 19:21     ` [PATCH v9 3/3] dts: add Rx Tx offload test suite Patrick Robb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251023123223.56924-4-abailey@iol.unh.edu \
    --to=abailey@iol.unh.edu \
    --cc=dev@dpdk.org \
    --cc=dmarx@iol.unh.edu \
    --cc=luca.vizzarro@arm.com \
    --cc=probb@iol.unh.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).