DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	stable@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
	Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk>,
	Reshma Pattan <reshma.pattan@intel.com>,
	Suanming Mou <suanmingm@nvidia.com>,
	Anatoly Burakov <anatoly.burakov@intel.com>
Subject: [PATCH v5 2/8] pdump: handle primary process exit
Date: Fri, 24 Oct 2025 14:53:57 -0700	[thread overview]
Message-ID: <20251024215456.282171-3-stephen@networkplumber.org> (raw)
In-Reply-To: <20251024215456.282171-1-stephen@networkplumber.org>

If primary process exits, then it is not possible (or needed)
to cleanup resources. Instead just exit after closing the
capture file.

Bugzilla ID: 1760
Fixes: a99a311ba101 ("app/pdump: exit with primary process")
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk>
---
 app/pdump/main.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/app/pdump/main.c b/app/pdump/main.c
index fa85859703..1741d7e709 100644
--- a/app/pdump/main.c
+++ b/app/pdump/main.c
@@ -1028,13 +1028,15 @@ main(int argc, char **argv)
 	dump_packets();
 
 	disable_primary_monitor();
-	cleanup_pdump_resources();
+
 	/* dump debug stats */
 	print_pdump_stats();
 
-	ret = rte_eal_cleanup();
-	if (ret)
-		printf("Error from rte_eal_cleanup(), %d\n", ret);
+	/* If primary has exited, do not try and communicate with it */
+	if (!rte_eal_primary_proc_alive(NULL))
+		return 0;
 
-	return 0;
+	cleanup_pdump_resources();
+
+	return rte_eal_cleanup() ? EXIT_FAILURE : 0;
 }
-- 
2.51.0


  parent reply	other threads:[~2025-10-24 21:55 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <250811213632.16023-1-stephen@networkplumber.org>
2025-10-19 16:56 ` [PATCH v3 0/8] packet capture bugfix and improvements Stephen Hemminger
2025-10-19 16:56   ` [PATCH v3 1/8] dumpcap: handle primary process exit Stephen Hemminger
2025-10-19 16:56   ` [PATCH v3 2/8] pdump: " Stephen Hemminger
2025-10-19 16:56   ` [PATCH v3 3/8] pdump: fix races in callbacks Stephen Hemminger
2025-10-19 16:56   ` [PATCH v3 4/8] dumpcap: handle pdump requests from primary Stephen Hemminger
2025-10-19 16:56   ` [PATCH v3 5/8] pdump: " Stephen Hemminger
2025-10-19 16:56   ` [PATCH v3 6/8] pdump: forward callback enable to secondary Stephen Hemminger
2025-10-19 16:56   ` [PATCH v3 7/8] pdump: remove use of VLA Stephen Hemminger
2025-10-19 16:56   ` [PATCH v3 8/8] doc: update documentation on pdump library Stephen Hemminger
2025-10-21 15:11     ` Stephen Hemminger
2025-10-22 17:29   ` [PATCH v3 0/8] packet capture bugfix and improvements Patrick Robb
2025-10-23 15:46 ` [PATCH v4 0/8] packet capture bugfix and secondary support Stephen Hemminger
2025-10-23 15:46   ` [PATCH v4 1/8] dumpcap: handle primary process exit Stephen Hemminger
2025-10-23 16:13     ` Bruce Richardson
2025-10-23 15:46   ` [PATCH v4 2/8] pdump: " Stephen Hemminger
2025-10-23 16:14     ` Bruce Richardson
2025-10-23 15:46   ` [PATCH v4 3/8] pdump: fix races in callbacks Stephen Hemminger
2025-10-23 15:46   ` [PATCH v4 4/8] dumpcap: handle pdump requests from primary Stephen Hemminger
2025-10-23 16:18     ` Bruce Richardson
2025-10-23 15:46   ` [PATCH v4 5/8] pdump: " Stephen Hemminger
2025-10-23 16:21     ` Bruce Richardson
2025-10-23 15:46   ` [PATCH v4 6/8] pdump: forward callback enable to secondary Stephen Hemminger
2025-10-23 15:46   ` [PATCH v4 7/8] pdump: remove use of VLA Stephen Hemminger
2025-10-23 15:46   ` [PATCH v4 8/8] doc: update documentation on pdump library Stephen Hemminger
2025-10-23 16:22   ` [PATCH v4 0/8] packet capture bugfix and secondary support Bruce Richardson
2025-10-23 16:39   ` Khadem Ullah
2025-10-24 21:53 ` [PATCH v5 0/8] packet capture bugfixes and secondary process Stephen Hemminger
2025-10-24 21:53   ` [PATCH v5 1/8] dumpcap: handle primary process exit Stephen Hemminger
2025-10-24 21:53   ` Stephen Hemminger [this message]
2025-10-24 21:53   ` [PATCH v5 3/8] pdump: fix races in callbacks Stephen Hemminger
2025-10-24 21:53   ` [PATCH v5 4/8] dumpcap: handle pdump requests from primary Stephen Hemminger
2025-10-24 21:54   ` [PATCH v5 5/8] pdump: " Stephen Hemminger
2025-10-24 21:54   ` [PATCH v5 6/8] pdump: forward callback enable to secondary Stephen Hemminger
2025-10-24 21:54   ` [PATCH v5 7/8] pdump: remove use of VLA Stephen Hemminger
2025-10-24 21:54   ` [PATCH v5 8/8] doc: update documentation on pdump library Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251024215456.282171-3-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=14pwcse1224@uetpeshawar.edu.pk \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=reshma.pattan@intel.com \
    --cc=stable@dpdk.org \
    --cc=suanmingm@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).