From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: "Stephen Hemminger" <stephen@networkplumber.org>,
shperetz@nvidia.com, "Morten Brørup" <mb@smartsharesystems.com>,
"Thomas Monjalon" <thomas@monjalon.net>
Subject: [PATCH] mbuf: fix build failure if MBUF_HISTORY_DEBUG enabled
Date: Fri, 24 Oct 2025 15:29:46 -0700 [thread overview]
Message-ID: <20251024222946.323662-1-stephen@networkplumber.org> (raw)
Message had extra newline which causes build failure.
../lib/mbuf/mbuf_history.c: In function ‘rte_mbuf_history_init’:
../lib/log/rte_log.h:364:9: error: static assertion failed: "This log format string contains a \\n"
364 | static_assert(!__builtin_strchr(fmt, '\n'), \
| ^~~~~~~~~~~~~
../lib/log/rte_log.h:387:9: note: in expansion of macro ‘RTE_LOG_CHECK_NO_NEWLINE’
387 | RTE_LOG_CHECK_NO_NEWLINE(RTE_FMT_HEAD(__VA_ARGS__ ,)); \
| ^~~~~~~~~~~~~~~~~~~~~~~~
../lib/mbuf/mbuf_log.h:8:9: note: in expansion of macro ‘RTE_LOG_LINE’
8 | RTE_LOG_LINE(level, MBUF, "" __VA_ARGS__)
| ^~~~~~~~~~~~
../lib/mbuf/mbuf_history.c:219:17: note: in expansion of macro ‘MBUF_LOG’
219 | MBUF_LOG(ERR, "Failed to register mbuf history dynamic field: %s\n",
|
Fixes: d265a24a32a4 ("mbuf: record mbuf operations history")
Cc: shperetz@nvidia.com
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/mbuf/mbuf_history.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/mbuf/mbuf_history.c b/lib/mbuf/mbuf_history.c
index 3bc4b916b6..b025d12fc8 100644
--- a/lib/mbuf/mbuf_history.c
+++ b/lib/mbuf/mbuf_history.c
@@ -216,7 +216,7 @@ void rte_mbuf_history_init(void)
rte_mbuf_history_field_offset = rte_mbuf_dynfield_register(&mbuf_dynfield_history);
if (rte_mbuf_history_field_offset < 0) {
- MBUF_LOG(ERR, "Failed to register mbuf history dynamic field: %s\n",
+ MBUF_LOG(ERR, "Failed to register mbuf history dynamic field: %s",
rte_strerror(rte_errno));
}
#endif
--
2.51.0
next reply other threads:[~2025-10-24 22:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 22:29 Stephen Hemminger [this message]
2025-10-25 6:59 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251024222946.323662-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=shperetz@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).