From: Stephen Hemminger <stephen@networkplumber.org>
To: Gregory Etelson <getelson@nvidia.com>
Cc: <dev@dpdk.org>, <mkashani@nvidia.com>, <rasland@nvidia.com>,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
"Aman Singh" <aman.deep.singh@intel.com>,
Shani Peretz <shperetz@nvidia.com>
Subject: Re: [PATCH v2] app/testpmd: fix devargs format in port attach
Date: Thu, 30 Oct 2025 10:47:54 -0700 [thread overview]
Message-ID: <20251030104754.2a6bd66e@phoenix> (raw)
In-Reply-To: <20251030171734.320367-1-getelson@nvidia.com>
On Thu, 30 Oct 2025 19:17:34 +0200
Gregory Etelson <getelson@nvidia.com> wrote:
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index 2360da3a48..a2280d38d3 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -3431,6 +3431,7 @@ convert_pci_address_format(const char *identifier, char *pci_buffer, size_t buf_
> return NULL;
>
> rte_pci_device_name(&pci_addr, pci_buffer, buf_size);
> + sprintf(pci_buffer + strlen(pci_buffer), ",%s", da.args);
> return pci_buffer;
> }
>
To avoid any possiblity of overflow, please us snprintf and adjust.
Something like:
rte_pci_device_name(&pci_addr, pci_buffer, buf_size);
size_t pci_len = strlen(pci_buffer);
snprintf(pci_buffer + pci_len, buf_size - pci_len, "%,%s", da.args);
next prev parent reply other threads:[~2025-10-30 17:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 9:20 [PATCH] " Gregory Etelson
2025-10-30 15:53 ` Stephen Hemminger
2025-10-30 17:17 ` [PATCH v2] " Gregory Etelson
2025-10-30 17:47 ` Stephen Hemminger [this message]
2025-10-31 6:18 ` [PATCH v3] " Gregory Etelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251030104754.2a6bd66e@phoenix \
--to=stephen@networkplumber.org \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=getelson@nvidia.com \
--cc=mkashani@nvidia.com \
--cc=rasland@nvidia.com \
--cc=shperetz@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).