From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63C4648A14; Thu, 30 Oct 2025 18:37:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AAFDB40653; Thu, 30 Oct 2025 18:37:43 +0100 (CET) Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) by mails.dpdk.org (Postfix) with ESMTP id 6C8E240150 for ; Thu, 30 Oct 2025 18:37:41 +0100 (CET) Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-3d5bb138b2cso535393fac.1 for ; Thu, 30 Oct 2025 10:37:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1761845861; x=1762450661; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kCldQ6otAaynRwfO4ZgZo4pBcu8QHJ8kMjludO8VMNQ=; b=uYiolkBkAFX7Ed2Csj7jBBjC0wad9S2hfk5Guxj2PxYK9KV2+BINsC4IYrc9KveOVG MY9H85MH3IdDODiTMYWFD98YAG+yateS1JkzPA/rzqfvlAlPwNvDyySyBxO3Gdl0JgDH ANVa08c3Nr4EydMNzgMbF0UrPfIPe3IHognC3QB5ZNvf9riV9LQQNkZHBPTD7X7zmR4P 2dmIFIYOTkJ1kZAtuPFNh+HAlu6PgIoIDnSRpPkf7zhAU2JpwefaciWcDH7sj2o+AHiR oBWPY4qXd1TBqpfmvtgyF6dSmZ/HXJZTJldPZDbnw3TGnFLExGuvq+esWMFe+mdo02KY KFWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761845861; x=1762450661; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kCldQ6otAaynRwfO4ZgZo4pBcu8QHJ8kMjludO8VMNQ=; b=M5d8QK5Ydt7GLpQIqKKNulP4WydyzTaQnmStyXRJ/8LyF+mxjcxh5MHz41Qu49pq6Q 2HFAa5s4TwPnHX2b0+FLWH8D9YgCSE5uWOGe8IIdoSmIfaYVitpNH/z36L7Zkxue9qsu es50LzaKTE2nc1+ZSGfrpAwZSJK8hOEinOANKXXB0Ezr8Pj5erhdtY55zFDV3XCFjPbJ XJIe0MJr7RBM9EKGLmymulz0qJAXX3CylDV6j/+PSHgHJHTi1GBwSWsxzyZJKP5aRX3Z ZA2aRPj4vuQG7JUtMVBIKkv1xYAzSOTWoJAD5/ObdtWukeizmtDDBjI7Ugzh1fh3hCu3 f+vw== X-Gm-Message-State: AOJu0YzBb+AJgFrcqslOyigetiWtkJKtGMdlytHd6Y8DKrVUg2VycRxk VM7LA7xeFPSgg/56yTtL+TBHRVx5cDVDZm+uK6FdFRUyl/u23Ac7gOl5W9MVePthRJhhD8vGr3V W5W1p X-Gm-Gg: ASbGncvPFbLk8FkAyYYzFwstD9pU+JXaofZxDLqFA8rtF+e304eZVSpzQjzVCPfOMXB SgMXaLWzLYy3OpZXgvIGzKch0qABfkXsOistvM/tBAltQwNh0sZF+KSYO+eB/fod/RIhCxpSpFg YvIDa5Wg9ywiyCVJaRoMsnHXu5bwE9tJBqN7nCHtG2xcyx19WEiyLUL6JIgGN+lWI2E50uMRFLp imjwNwTG1PGMYe4za9AmeEQZiify2PyyvT+ubLJ/WbtiU48VemH+pEK58M7Z8Bp9T7R7MN05l2P +fZfqfqv9fzmXO1oiTAvKmsytKN8Xdv8tgT8nnCXFaL0/I276orwGzWryDv0yNDYQUKq6QblcrN 2Fi7LMclMJaZG7OQaEX8gEvCGIhNpPnqp6mG8FIyhzP8to15/DpQW7peqsKNiBeoY/rhWeNlfy5 jOYf02RzvvaXkbgn+4h2672XgswBXYDIlzPfLCCEY= X-Google-Smtp-Source: AGHT+IFkEPVSL8Kf3gxxHtYe5v8igizyHB2Rbhp0EoRaBcl4fcUVmqfdfp0K59jyU60OL/oh1kVF7Q== X-Received: by 2002:a05:6870:f296:b0:3d3:64d7:cfe5 with SMTP id 586e51a60fabf-3dacd42e046mr222830fac.49.1761845860608; Thu, 30 Oct 2025 10:37:40 -0700 (PDT) Received: from phoenix.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-3d1e20f1396sm6057278fac.3.2025.10.30.10.37.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Oct 2025 10:37:39 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Konstantin Ananyev Subject: [PATCH 3/5] bpf: add a test for BPF ELF load Date: Thu, 30 Oct 2025 10:34:11 -0700 Message-ID: <20251030173732.246435-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251030173732.246435-1-stephen@networkplumber.org> References: <20251030173732.246435-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Create an ELF file to load using clang. Repackage the object into an array using xdd. Write a test to see load and run the BPF. If tools are not present, then the step is skipped. Draft version made with Claude AI, but it didn't work. Signed-off-by: Stephen Hemminger --- app/test/bpf/meson.build | 52 +++++++++++++ app/test/bpf/test_bpf_load.c | 60 ++++++++++++++ app/test/meson.build | 2 + app/test/test_bpf.c | 146 +++++++++++++++++++++++++++++++++++ 4 files changed, 260 insertions(+) create mode 100644 app/test/bpf/meson.build create mode 100644 app/test/bpf/test_bpf_load.c diff --git a/app/test/bpf/meson.build b/app/test/bpf/meson.build new file mode 100644 index 0000000000..2b944f5ea9 --- /dev/null +++ b/app/test/bpf/meson.build @@ -0,0 +1,52 @@ +# SPDX-License-Identifier: BSD-3-Clause +# Copyright 2025 Stephen Hemminger + +bpf_test_hdrs = [ ] + +# use clang to compile to bpf +clang_supports_bpf = false +clang = find_program('clang', required: false) +if clang.found() + clang_supports_bpf = run_command(clang, '-target', 'bpf', '--print-supported-cpus', + check: false).returncode() == 0 +endif + +if not clang_supports_bpf + message('app/test_bpf: no BPF load tests missing clang BPF support') + subdir_done() + +endif + +xxd = find_program('xxd', required: false) +if not xxd.found() + message('app/test_bpf: missing xxd required to convert object to array') + subdir_done() +endif + +# BPF compiler flags +bpf_cflags = [ '-O2', '-target', 'bpf', '-g', '-c'] + +# Enable test in test_bpf.c +cflags += '-DTEST_BPF_ELF_LOAD' + +# BPF sources to compile +test_bpf_progs = [ + 'test_bpf_load' +] + +foreach test_name : test_bpf_progs + # Compile BPF C source to object file + bpf_obj = custom_target(test_name + '_o', + input: test_name + '.c', + output: test_name + '.o', + command: [ clang, bpf_cflags, '@INPUT@', '-o', '@OUTPUT@']) + + # Convert object file to C header using xxd + bpf_test_h = custom_target(test_name + '_h', + input: bpf_obj, + output: test_name + '.h', + command: [ xxd, '-i', '-n', test_name + '_data','@INPUT@', '@OUTPUT@']) + + resources += bpf_test_h + +endforeach diff --git a/app/test/bpf/test_bpf_load.c b/app/test/bpf/test_bpf_load.c new file mode 100644 index 0000000000..42111f85ce --- /dev/null +++ b/app/test/bpf/test_bpf_load.c @@ -0,0 +1,60 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * BPF program for testing rte_bpf_elf_load + */ + +#include +#include + +/* Match the structures from test_bpf.c */ +struct dummy_offset { + uint64_t u64; + uint32_t u32; + uint16_t u16; + uint8_t u8; +} __attribute__((packed)); + +struct dummy_vect8 { + struct dummy_offset in[8]; + struct dummy_offset out[8]; +}; + +/* External function declaration - provided by test via xsym */ +extern void dummy_func1(const void *p, uint32_t *v32, uint64_t *v64); + +/* + * Test BPF function that will be loaded from ELF + * This function: + * 1. Reads values from input structure + * 2. Performs some computations + * 3. Writes results to output structure + * 4. Returns sum of values + */ +__attribute__((section("func"), used)) +uint64_t +test_func(struct dummy_vect8 *arg) +{ + uint64_t sum = 0; + uint32_t v32; + uint64_t v64; + + /* Load input values */ + v32 = arg->in[0].u32; + v64 = arg->in[0].u64; + + /* Call external function */ + dummy_func1(arg, &v32, &v64); + + /* Store results */ + arg->out[0].u32 = v32; + arg->out[0].u64 = v64; + + /* Calculate sum */ + sum = arg->in[0].u64; + sum += arg->in[0].u32; + sum += arg->in[0].u16; + sum += arg->in[0].u8; + sum += v32; + sum += v64; + + return sum; +} diff --git a/app/test/meson.build b/app/test/meson.build index 8df8d3edd1..efec42a6bf 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -281,6 +281,8 @@ if not is_windows install: false) endif +subdir('bpf') + subdir('test_cfgfiles') resources += test_cfgfile_h diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c index 90e10d7d2c..855fdc8ad1 100644 --- a/app/test/test_bpf.c +++ b/app/test/test_bpf.c @@ -6,6 +6,7 @@ #include #include #include +#include #include #include @@ -14,6 +15,8 @@ #include #include #include +#include + #include "test.h" #if !defined(RTE_LIB_BPF) @@ -3278,6 +3281,149 @@ test_bpf(void) REGISTER_FAST_TEST(bpf_autotest, true, true, test_bpf); +#ifdef TEST_BPF_ELF_LOAD + +/* + * Helper function to write BPF object data to temporary file. + * Returns temp file path on success, NULL on failure. + * Caller must free the returned path and unlink the file. + */ +static char * +create_temp_bpf_file(const uint8_t *data, size_t size, const char *suffix) +{ + char *tmpfile = NULL; + int fd; + ssize_t written; + + if (asprintf(&tmpfile, "/tmp/dpdk_bpf_%s_XXXXXX", suffix) < 0) { + printf("%s@%d: asprintf failed: %s\n", + __func__, __LINE__, strerror(errno)); + return NULL; + } + + /* Create and open temp file */ + fd = mkstemp(tmpfile); + if (fd < 0) { + printf("%s@%d: mkstemp(%s) failed: %s\n", + __func__, __LINE__, tmpfile, strerror(errno)); + free(tmpfile); + return NULL; + } + + /* Write BPF object data */ + written = write(fd, data, size); + close(fd); + + if (written != (ssize_t)size) { + printf("%s@%d: write failed: %s\n", + __func__, __LINE__, strerror(errno)); + unlink(tmpfile); + free(tmpfile); + return NULL; + } + + return tmpfile; +} + +#include "test_bpf_load.h" + +static int +test_bpf_elf_load(void) +{ + uint8_t tbuf[sizeof(struct dummy_vect8)]; + const struct rte_bpf_xsym xsym[] = { + { + .name = RTE_STR(dummy_func1), + .type = RTE_BPF_XTYPE_FUNC, + .func = { + .val = (void *)dummy_func1, + .nb_args = 3, + .args = { + [0] = { + .type = RTE_BPF_ARG_PTR, + .size = sizeof(struct dummy_offset), + }, + [1] = { + .type = RTE_BPF_ARG_PTR, + .size = sizeof(uint32_t), + }, + [2] = { + .type = RTE_BPF_ARG_PTR, + .size = sizeof(uint64_t), + }, + }, + }, + }, + }; + int ret; + + /* Create temp file from embedded BPF object */ + char *tmpfile = create_temp_bpf_file(test_bpf_load_data, + test_bpf_load_data_len, "load"); + if (tmpfile == NULL) + return -1; + + /* Try to load BPF program from temp file */ + const struct rte_bpf_prm prm = { + .xsym = xsym, + .nb_xsym = RTE_DIM(xsym), + .prog_arg = { + .type = RTE_BPF_ARG_PTR, + .size = sizeof(tbuf), + }, + }; + struct rte_bpf *bpf = rte_bpf_elf_load(&prm, tmpfile, "func"); + TEST_ASSERT(bpf != NULL, "failed to load BPF from %s %d:%s", + tmpfile, rte_errno, strerror(rte_errno)); + + /* Prepare test data */ + struct dummy_vect8 *dv = (struct dummy_vect8 *)tbuf; + memset(dv, 0, sizeof(*dv)); + dv->in[0].u64 = (int32_t)TEST_FILL_1; + dv->in[0].u32 = dv->in[0].u64; + dv->in[0].u16 = dv->in[0].u64; + dv->in[0].u8 = dv->in[0].u64; + + /* Execute loaded BPF program */ + uint64_t sum = rte_bpf_exec(bpf, tbuf); + TEST_ASSERT(sum != 0, "BPF execution returned: %" PRIu64, sum); + + /* Test JIT if available */ + struct rte_bpf_jit jit; + ret = rte_bpf_get_jit(bpf, &jit); + TEST_ASSERT(ret == 0, "rte_bpf_get_jit failed: %d", ret); + + if (jit.func != NULL) { + memset(dv, 0, sizeof(*dv)); + dv->in[0].u64 = (int32_t)TEST_FILL_1; + dv->in[0].u32 = dv->in[0].u64; + dv->in[0].u16 = dv->in[0].u64; + dv->in[0].u8 = dv->in[0].u64; + + uint64_t jsum = jit.func(tbuf); + TEST_ASSERT_EQUAL(sum, jsum, "BPF JIT execution difference"); + } + + rte_bpf_destroy(bpf); + unlink(tmpfile); + free(tmpfile); + + printf("%s: ELF load test passed\n", __func__); + return TEST_SUCCESS; +} +#else + +static int +test_bpf_elf_load(void) +{ + printf("BPF compile not supported, skipping test\n"); + return TEST_SKIPPED; +} + +#endif /* !TEST_BPF_ELF_LOAD */ + +REGISTER_FAST_TEST(bpf_elf_load_autotest, true, true, test_bpf_elf_load); + #ifndef RTE_HAS_LIBPCAP static int -- 2.51.0