From: Rongwei Liu <rongweil@nvidia.com>
To: <dev@dpdk.org>, <matan@nvidia.com>, <viacheslavo@nvidia.com>,
<orika@nvidia.com>, <suanmingm@nvidia.com>, <thomas@monjalon.net>
Cc: <rongweil@nvidia.com>, Dariusz Sosnowski <dsosnowski@nvidia.com>,
"Bing Zhao" <bingz@nvidia.com>
Subject: [PATCH v2] net/mlx5: remove counter alignment
Date: Fri, 31 Oct 2025 04:50:38 +0200 [thread overview]
Message-ID: <20251031025038.62100-1-rongweil@nvidia.com> (raw)
In-Reply-To: <20251028101427.7swzqvc5o3ofzdxg@ds-vm-debian.local>
The memory footprint was increased due to the alignment.
Fixes: 820ca7361bb7fa4 ("net/mlx5: fix flow aging race condition")
Cc: rongweil@nvidia.com
Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
---
drivers/net/mlx5/mlx5_hws_cnt.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_hws_cnt.h b/drivers/net/mlx5/mlx5_hws_cnt.h
index f5b7e8f643..8d7a9d34df 100644
--- a/drivers/net/mlx5/mlx5_hws_cnt.h
+++ b/drivers/net/mlx5/mlx5_hws_cnt.h
@@ -43,7 +43,7 @@ struct mlx5_hws_cnt_dcs_mng {
};
union mlx5_hws_cnt_state {
- alignas(RTE_CACHE_LINE_SIZE) RTE_ATOMIC(uint32_t)data;
+ RTE_ATOMIC(uint32_t) data;
struct {
uint32_t in_used:1;
/* Indicator whether this counter in used or in pool. */
@@ -64,7 +64,7 @@ struct mlx5_hws_cnt {
struct flow_counter_stats reset;
union mlx5_hws_cnt_state cnt_state;
/* This struct is only meaningful when user own this counter. */
- alignas(RTE_CACHE_LINE_SIZE) RTE_ATOMIC(uint32_t)query_gen_when_free;
+ RTE_ATOMIC(uint32_t) query_gen_when_free;
/*
* When PMD own this counter (user put back counter to PMD
* counter pool, i.e), this field recorded value of counter
--
2.27.0
next prev parent reply other threads:[~2025-10-31 2:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 9:26 [PATCH v1] " Rongwei Liu
2025-10-28 10:14 ` Dariusz Sosnowski
2025-10-31 2:50 ` Rongwei Liu [this message]
2025-10-31 9:50 ` [PATCH v2] " Dariusz Sosnowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251031025038.62100-1-rongweil@nvidia.com \
--to=rongweil@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).