From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: hemant.agrawal@nxp.com, maxime@leroys.fr,
Sachin Saxena <sachin.saxena@nxp.com>,
Jun Yang <jun.yang@nxp.com>
Subject: [PATCH 3/5] net/dpaa2: remove dead code in loopback mode
Date: Sat, 8 Nov 2025 16:32:04 +0100 [thread overview]
Message-ID: <20251108153207.1512863-4-david.marchand@redhat.com> (raw)
In-Reply-To: <20251108153207.1512863-1-david.marchand@redhat.com>
This code was never used.
Fixes: f023d059769f ("net/dpaa2: support recycle loopback port")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/dpaa2/dpaa2_ethdev.h | 6 ----
drivers/net/dpaa2/dpaa2_recycle.c | 50 -------------------------------
2 files changed, 56 deletions(-)
diff --git a/drivers/net/dpaa2/dpaa2_ethdev.h b/drivers/net/dpaa2/dpaa2_ethdev.h
index 87a94bc15b..86b3022ddb 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.h
+++ b/drivers/net/dpaa2/dpaa2_ethdev.h
@@ -531,12 +531,6 @@ int dpaa2_dev_recycle_config(struct rte_eth_dev *eth_dev);
int dpaa2_dev_recycle_deconfig(struct rte_eth_dev *eth_dev);
int dpaa2_soft_parser_loaded(void);
-int dpaa2_dev_recycle_qp_setup(struct rte_dpaa2_device *dpaa2_dev,
- uint16_t qidx, uint64_t cntx,
- eth_rx_burst_t tx_lpbk, eth_tx_burst_t rx_lpbk,
- struct dpaa2_queue **txq,
- struct dpaa2_queue **rxq);
-
void
dpaa2_dev_mac_setup_stats(struct rte_eth_dev *dev);
diff --git a/drivers/net/dpaa2/dpaa2_recycle.c b/drivers/net/dpaa2/dpaa2_recycle.c
index 94a7e2a020..d1e21dd4d1 100644
--- a/drivers/net/dpaa2/dpaa2_recycle.c
+++ b/drivers/net/dpaa2/dpaa2_recycle.c
@@ -730,53 +730,3 @@ dpaa2_dev_recycle_deconfig(struct rte_eth_dev *eth_dev)
return ret;
}
-
-int
-dpaa2_dev_recycle_qp_setup(struct rte_dpaa2_device *dpaa2_dev,
- uint16_t qidx, uint64_t cntx,
- eth_rx_burst_t tx_lpbk, eth_tx_burst_t rx_lpbk,
- struct dpaa2_queue **txq,
- struct dpaa2_queue **rxq)
-{
- struct rte_eth_dev *dev;
- struct rte_eth_dev_data *data;
- struct dpaa2_queue *txq_tmp;
- struct dpaa2_queue *rxq_tmp;
- struct dpaa2_dev_priv *priv;
-
- dev = dpaa2_dev->eth_dev;
- data = dev->data;
- priv = data->dev_private;
-
- if (!(priv->flags & DPAA2_TX_LOOPBACK_MODE) &&
- (tx_lpbk || rx_lpbk)) {
- DPAA2_PMD_ERR("%s is NOT recycle device!", data->name);
-
- return -EINVAL;
- }
-
- if (qidx >= data->nb_rx_queues || qidx >= data->nb_tx_queues)
- return -EINVAL;
-
- rte_spinlock_lock(&priv->lpbk_qp_lock);
-
- if (tx_lpbk)
- dev->tx_pkt_burst = tx_lpbk;
-
- if (rx_lpbk)
- dev->rx_pkt_burst = rx_lpbk;
-
- txq_tmp = data->tx_queues[qidx];
- txq_tmp->lpbk_cntx = cntx;
- rxq_tmp = data->rx_queues[qidx];
- rxq_tmp->lpbk_cntx = cntx;
-
- if (txq)
- *txq = txq_tmp;
- if (rxq)
- *rxq = rxq_tmp;
-
- rte_spinlock_unlock(&priv->lpbk_qp_lock);
-
- return 0;
-}
--
2.51.0
next prev parent reply other threads:[~2025-11-08 15:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-08 15:32 [PATCH 0/5] Cleanup rte_dpaa2_device David Marchand
2025-11-08 15:32 ` [PATCH 1/5] crypto/dpaa2_sec: remove crypto device in bus device David Marchand
2025-11-08 15:32 ` [PATCH 2/5] dma/dpaa2: remove DMA " David Marchand
2025-11-08 15:32 ` David Marchand [this message]
2025-11-08 15:32 ` [PATCH 4/5] net/dpaa2: remove ethdev " David Marchand
2025-11-08 15:32 ` [PATCH 5/5] bus/fslmc: remove raw " David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251108153207.1512863-4-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jun.yang@nxp.com \
--cc=maxime@leroys.fr \
--cc=sachin.saxena@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).