From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FAFB48B0B; Fri, 14 Nov 2025 17:40:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D909740F35; Fri, 14 Nov 2025 17:40:09 +0100 (CET) Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) by mails.dpdk.org (Postfix) with ESMTP id DD0DA40151 for ; Fri, 14 Nov 2025 17:40:06 +0100 (CET) Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-8b0f54370ecso208336285a.2 for ; Fri, 14 Nov 2025 08:40:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1763138406; x=1763743206; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bXluqCbpPR8po6jBWaH6QgoPf3udhbnPqDucBgJwzjs=; b=fXRwhWo8gmLdDZifyZZUI5gJOfuzYtbbFZuuUVKa1celn8WqwQnhj4Fl7Hb4SrmP0/ V08leia3648V22EfsihqW4GDh7rYFYq0p/5IUTd+vx4iBL9WH77mXzF82wHKAGIRO419 KPetj+9JyjZidVt1/XUljoNz3MtkMsoT+J1bQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763138406; x=1763743206; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bXluqCbpPR8po6jBWaH6QgoPf3udhbnPqDucBgJwzjs=; b=Jn5NhDJAbbljPuL3Z35h3PDPIhtbeZYUzWpZe85HU71oWtwkhkydMz+MxJA555GX6O zngElz9OYVeJ/d/aFQYy2QsxuyiZFhyeUcjXAIRoCtGtrZL9f5YOQHXKPu76PLMhzBKQ LivE/8s/JqcX5qEUhHfG8eSH4+02HlJotgZbGV01IpKCL3hogMIHjEWTkN1mRLQ09wUa I8tw/OabGbUsHdk10uCLeqB7GnmKvQbaYFCIdk/7a75mP5aPn4CLXg2ywr4d504ASi84 eIp1mqZwwW3R41RoE9lPPInMSVRhDq3sQllz+eJUafIdH1lgHlLBTE73yhFV+DlF61s6 5T6A== X-Gm-Message-State: AOJu0Yzj29w7hUDUHdSuAaT41iqTmVgjgFyzicKjVP4V/+JUOUJDNFzQ gD6d1Iuk5pQhCT33ru9Ov9bItSjKsi7dgM71kQ9t8sn4ZMbMumkIsWlQTc/zf2a4VdQ= X-Gm-Gg: ASbGncvT557Xag9VWVLynlfoHeBTFx4avh2EaRbxdKeT1H94OupFbkmSXFgf+JswbKh A7/pu8l2y1DBqiCM0Um+d4+vhhzGCZdIz6aGenpgdHBr9nhQBq+PT0hdehg6ltLYxMaa/JYPf1F AU182kYav0zwE3OkBlWgZ34KQVvBytFIfVEq24Vuh34dBVqdlgjW5pg9XAvLOuSYtc8Ex1M+G/D 1qCdFyI/uClJSelRyLYRXqe45DQq6cmR1HlyOw6NudjBPB757VvMFIshqOkFiF5ggIxj2/Rkb0F 7OM1cygdaHliomKFG3l7rW4wU492FfkQJerSAV6vSENIzhCCVcicfn51A9Z4qNMM0ccpPq1y5ur UrSmJ7Y7Os7ZMSCMnQJWmyyXVZXDqre4OX30WlzoZ5RL+TaFjJ9ibH1Q03tExMTkLXV+orHWZdG qvTj0= X-Google-Smtp-Source: AGHT+IE4Rj7wctiz6vTfvEj4wI1/ZS2h3zw6J86DHryst2Mjab+PhWl2aDdcQCNkZRnSzpn9HI6Saw== X-Received: by 2002:a05:620a:2915:b0:8a3:e51d:63c9 with SMTP id af79cd13be357-8b2c3161822mr467916385a.25.1763138406102; Fri, 14 Nov 2025 08:40:06 -0800 (PST) Received: from d121016.iol.unh.edu ([2606:4100:3880:1210::202]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b2aee9e9f0sm365867585a.3.2025.11.14.08.40.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 08:40:05 -0800 (PST) From: Dean Marx To: probb@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com Cc: dev@dpdk.org, Dean Marx Subject: [PATCH v5 2/2] dts: add QinQ test suite Date: Fri, 14 Nov 2025 11:40:03 -0500 Message-ID: <20251114164003.327455-2-dmarx@iol.unh.edu> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251114164003.327455-1-dmarx@iol.unh.edu> References: <20251113190309.310821-2-dmarx@iol.unh.edu> <20251114164003.327455-1-dmarx@iol.unh.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add QinQ test suite, which verifies PMD behavior when sending QinQ (IEEE 802.1ad) packets. Signed-off-by: Dean Marx Reviewed-by: Patrick Robb --- dts/tests/TestSuite_qinq.py | 206 ++++++++++++++++++++++++++++++++++++ 1 file changed, 206 insertions(+) create mode 100644 dts/tests/TestSuite_qinq.py diff --git a/dts/tests/TestSuite_qinq.py b/dts/tests/TestSuite_qinq.py new file mode 100644 index 0000000000..bb385a0d91 --- /dev/null +++ b/dts/tests/TestSuite_qinq.py @@ -0,0 +1,206 @@ +# SPDX-License-Identifier: BSD-3-Clause +# Copyright(c) 2025 University of New Hampshire + +"""QinQ (802.1ad) Test Suite. + +This test suite verifies the correctness and capability of DPDK Poll Mode Drivers (PMDs) +in handling QinQ-tagged Ethernet frames, which contain a pair of stacked VLAN headers +(outer S-VLAN and inner C-VLAN). These tests ensure that both software and hardware offloads +related to QinQ behave as expected across different NIC vendors and PMD implementations. +""" + +from typing import Optional + +from scapy.layers.inet import IP, UDP +from scapy.layers.l2 import Dot1AD, Dot1Q, Ether +from scapy.packet import Packet, Raw + +from api.capabilities import NicCapability, requires_nic_capability +from api.packet import send_packet_and_capture +from api.test import log, verify +from api.testpmd import TestPmd +from framework.test_suite import TestSuite, func_test + + +class TestQinq(TestSuite): + """QinQ test suite. + + This suite consists of 2 test cases: + 1. QinQ Forwarding: Send a QinQ packet and verify the received packet contains + both QinQ/VLAN layers. + 2. QinQ Strip: Enable VLAN/QinQ stripping and verify sent packets are received with the + expected VLAN/QinQ layers. + """ + + def _send_packet_and_verify( + self, packet: Packet, testpmd: TestPmd, should_receive: bool + ) -> None: + """Send packet and verify reception. + + Args: + packet: The packet to send to testpmd. + testpmd: The testpmd session to send commands to. + should_receive: If :data:`True`, verifies packet was received. + """ + testpmd.start() + packets = send_packet_and_capture(packet=packet) + test_packet = self._get_relevant_packet(packets) + if should_receive: + verify(test_packet is not None, "Packet was dropped when it should have been received.") + else: + verify(test_packet is None, "Packet was received when it should have been dropped.") + + def _strip_verify(self, packet: Optional[Packet], expects_tag: bool, context: str) -> bool: + """Helper method for verifying packet stripping functionality. + + Returns: :data:`True` if tags are stripped or not stripped accordingly, + otherwise :data:`False` + """ + if packet is None: + log(f"{context} packet was dropped when it should have been received.") + return False + + if not expects_tag: + if packet.haslayer(Dot1Q) or packet.haslayer(Dot1AD): + log( + f"VLAN tags found in packet when should have been stripped: " + f"{packet.summary()}\tsent packet: {context}", + ) + return False + + if expects_tag: + if vlan_layer := packet.getlayer(Dot1Q): + if vlan_layer.vlan != 200: + log( + f"Expected VLAN ID 200 but found ID {vlan_layer.vlan}: " + f"{packet.summary()}\tsent packet: {context}", + ) + return False + else: + log( + f"Expected 0x8100 VLAN tag but none found: {packet.summary()}" + f"\tsent packet: {context}" + ) + return False + + return True + + def _get_relevant_packet(self, packet_list: list[Packet]) -> Optional[Packet]: + """Helper method for checking received packet list for sent packet.""" + for packet in packet_list: + if hasattr(packet, "load") and b"xxxxx" in packet.load: + return packet + return None + + @func_test + def test_qinq_forwarding(self) -> None: + """QinQ Rx filter test case. + + Steps: + Launch testpmd with mac forwarding mode. + Disable VLAN filter mode on port 0. + Send test packet and capture verbose output. + + Verify: + Check that the received packet has two separate VLAN layers in proper QinQ fashion. + Check that the received packet outer and inner VLAN layer has the appropriate ID. + """ + test_packet = ( + Ether(dst="ff:ff:ff:ff:ff:ff") + / Dot1AD(vlan=100) + / Dot1Q(vlan=200) + / IP(dst="1.2.3.4") + / UDP(dport=1234, sport=4321) + / Raw(load="xxxxx") + ) + with TestPmd() as testpmd: + testpmd.set_vlan_filter(0, False) + testpmd.start() + received_packets = send_packet_and_capture(test_packet) + packet = self._get_relevant_packet(received_packets) + + verify(packet is not None, "Packet was dropped when it should have been received.") + + if packet is not None: + verify( + bool(packet.haslayer(Dot1AD)) and bool(packet.haslayer(Dot1Q)), + "QinQ/VLAN layers not found in packet", + ) + + if outer_vlan := packet.getlayer(Dot1AD): + outer_vlan_id = outer_vlan.vlan + verify( + outer_vlan_id == 100, + f"Outer VLAN ID was {outer_vlan_id} when it should have been 100.", + ) + else: + verify(False, "VLAN layer not found in received packet.") + + if outer_vlan and (inner_vlan := outer_vlan.getlayer(Dot1Q)): + inner_vlan_id = inner_vlan.vlan + verify( + inner_vlan_id == 200, + f"Inner VLAN ID was {inner_vlan_id} when it should have been 200", + ) + + @requires_nic_capability(NicCapability.PORT_RX_OFFLOAD_QINQ_STRIP) + @func_test + def test_qinq_strip(self) -> None: + """Test combinations of VLAN/QinQ strip settings with various QinQ packets. + + Steps: + Launch testpmd with QinQ and VLAN strip enabled. + Send four VLAN/QinQ related test packets. + + Verify: + Check received packets have the expected VLAN/QinQ layers/tags. + """ + test_packets = [ + Ether() / Dot1Q() / IP() / UDP(dport=1234, sport=4321) / Raw(load="xxxxx"), + Ether() + / Dot1Q(vlan=100) + / Dot1Q(vlan=200) + / IP() + / UDP(dport=1234, sport=4321) + / Raw(load="xxxxx"), + Ether() / Dot1AD() / IP() / UDP(dport=1234, sport=4321) / Raw(load="xxxxx"), + Ether() / Dot1AD() / Dot1Q() / IP() / UDP(dport=1234, sport=4321) / Raw(load="xxxxx"), + ] + with TestPmd() as testpmd: + testpmd.set_qinq_strip(0, True) + testpmd.set_vlan_strip(0, True) + testpmd.start() + + received_packets1 = send_packet_and_capture(test_packets[0]) + vlan_packet = self._get_relevant_packet(received_packets1) + received_packets2 = send_packet_and_capture(test_packets[1]) + double_vlan_packet = self._get_relevant_packet(received_packets2) + received_packets3 = send_packet_and_capture(test_packets[2]) + single_88a8_packet = self._get_relevant_packet(received_packets3) + received_packets4 = send_packet_and_capture(test_packets[3]) + qinq_packet = self._get_relevant_packet(received_packets4) + + testpmd.stop() + + tests = [ + ("Single 8100 tag", self._strip_verify(vlan_packet, False, "Single 8100 tag")), + ( + "Double 8100 tag", + self._strip_verify(double_vlan_packet, True, "Double 8100 tag"), + ), + ( + "Single 88a8 tag", + self._strip_verify(single_88a8_packet, False, "Single 88a8 tag"), + ), + ( + "QinQ (88a8 and 8100 tags)", + self._strip_verify(qinq_packet, False, "QinQ (88a8 and 8100 tags)"), + ), + ] + + failed = [ctx for ctx, result in tests if not result] + + verify( + not failed, + f"The following packets were not stripped correctly: {', '.join(failed)}", + ) -- 2.51.0