From: Stephen Hemminger <stephen@networkplumber.org>
To: Maayan Kashani <mkashani@nvidia.com>
Cc: <dev@dpdk.org>, <dsosnowski@nvidia.com>, <rasland@nvidia.com>,
<stable@dpdk.org>, Aman Singh <aman.deep.singh@intel.com>,
"Viacheslav Ovsiienko" <viacheslavo@nvidia.com>,
Gregory Etelson <getelson@nvidia.com>
Subject: Re: [PATCH v2] app/testpmd: fix flex item link parsing
Date: Mon, 17 Nov 2025 10:20:04 -0800 [thread overview]
Message-ID: <20251117102004.713f1622@phoenix> (raw)
In-Reply-To: <20251116121437.159702-1-mkashani@nvidia.com>
On Sun, 16 Nov 2025 14:14:37 +0200
Maayan Kashani <mkashani@nvidia.com> wrote:
> The flex_link_item_parse function was using FLEX_MAX_FLOW_PATTERN_LENGTH
> for all memcpy operations regardless of the actual flow item type. This
> could lead to copying incorrect amounts of data.
>
> This patch adds a switch statement to determine the correct size based
> on the actual flow item type (IPv4, IPv6, UDP, TCP) and uses that size
> for the memcpy operations on spec, mask, and last fields.
>
> Also adds validation to reject unsupported item types.
>
> Fixes: 59f3a8acbcdb ("app/testpmd: add flex item commands")
> Cc: stable@dpdk.org
>
> Signed-off-by: Maayan Kashani <mkashani@nvidia.com>
Queued to next-net
prev parent reply other threads:[~2025-11-17 18:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 20:17 [PATCH] " Maayan Kashani
2025-11-13 22:38 ` Stephen Hemminger
2025-11-16 8:11 ` Maayan Kashani
2025-11-16 12:14 ` [PATCH v2] " Maayan Kashani
2025-11-17 18:20 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117102004.713f1622@phoenix \
--to=stephen@networkplumber.org \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=getelson@nvidia.com \
--cc=mkashani@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).