From: Yang Xu <xu.yang3@zte.com.cn>
To: thomas@monjalon.net, dsosnowski@nvidia.com,
viacheslavo@nvidia.com, bingz@nvidia.com, orika@nvidia.com,
suanmingm@nvidia.com, matan@nvidia.com, xu.yang3@zte.com.cn,
yao.chenghu@zte.com.cn
Cc: dev@dpdk.org, stable@dpdk.org
Subject: [PATCH v3 1/1] net/mlx5: fix port down in link detection error branch
Date: Wed, 19 Nov 2025 14:02:22 +0800 [thread overview]
Message-ID: <20251119060222.2814478-1-xu.yang3@zte.com.cn> (raw)
[-- Attachment #1.1.1: Type: text/plain, Size: 1446 bytes --]
The port down state was not initialized in the error branch of link
detection when MLX NIC link status update failed (ret < 0).
This resulted in incorrect link state reporting, as the device
retained stale link status instead of reflecting the actual down
state under error conditions.
Fixes: 1256805dd54 ("net/mlx5: move Linux-specific functions")
Cc: stable@dpdk.org
Signed-off-by: Yang Xu <xu.yang3@zte.com.cn>
---
.mailmap | 1 +
drivers/net/mlx5/linux/mlx5_ethdev_os.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/.mailmap b/.mailmap
index 34a99f93a1..14d6ee93dd 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1891,3 +1891,4 @@ Zoltan Kiss <zoltan.kiss@schaman.hu> <zoltan.kiss@linaro.org>
Zorik Machulsky <zorik@amazon.com>
Zyta Szpak <zyta@marvell.com> <zr@semihalf.com>
Zyta Szpak <zyta@marvell.com> <zyta.szpak@semihalf.com>
+Yang Xu <xu.yang3@zte.com.cn>
diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
index 9daeda5435..49b88dfebb 100644
--- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c
+++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
@@ -504,6 +504,7 @@ mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete)
return -rte_errno;
}
} else if (ret < 0) {
+ memset(&dev->data->dev_link, 0, sizeof(dev->data->dev_link));
return ret;
}
} while (wait_to_complete || retry-- > 0);
--
2.27.0
[-- Attachment #1.1.2: Type: text/html , Size: 2918 bytes --]
reply other threads:[~2025-11-19 6:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251119060222.2814478-1-xu.yang3@zte.com.cn \
--to=xu.yang3@zte.com.cn \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
--cc=yao.chenghu@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).