DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH v4 3/8] test: avoid overflowing huge directory path
Date: Thu, 20 Nov 2025 08:55:31 -0800	[thread overview]
Message-ID: <20251120165713.120238-4-stephen@networkplumber.org> (raw)
In-Reply-To: <20251120165713.120238-1-stephen@networkplumber.org>

Since the tests construct a mulit-part path in huge pages directory,
avoid overflowing the string buffer by limiting the possible
huge page directory.  Can never happen in real life, but compiler
gives warnings about string overflow that it could.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 app/test/test_eal_flags.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index c2e6c00edb..e21029255e 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -172,7 +172,7 @@ process_hugefiles(const char * prefix, enum hugepage_action action)
 	struct dirent *dirent = NULL;
 
 	char hugefile_prefix[PATH_MAX] = {0};
-	char hugedir[PATH_MAX] = {0};
+	char hugedir[PATH_MAX - NAME_MAX] = {0};
 	char line[PATH_MAX] = {0};
 
 	int fd, lck_result, result = 0;
@@ -873,7 +873,7 @@ test_no_huge_flag(void)
 static int
 test_misc_flags(void)
 {
-	char hugepath[PATH_MAX] = {0};
+	char hugepath[PATH_MAX - NAME_MAX] = {0};
 	char hugepath_dir[PATH_MAX] = {0};
 	char hugepath_dir2[PATH_MAX] = {0};
 	char hugepath_dir3[PATH_MAX] = {0};
-- 
2.51.0


  parent reply	other threads:[~2025-11-20 16:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0251115193409.99740-1-stephen@networkplumber.org>
2025-11-20 16:55 ` [PATCH v4 0/8] tests: enable format truncation checks Stephen Hemminger
2025-11-20 16:55   ` [PATCH v4 1/8] test: increase size of memzone name Stephen Hemminger
2025-11-20 16:55   ` [PATCH v4 2/8] test: refactor file prefix arg handling Stephen Hemminger
2025-11-20 16:55   ` Stephen Hemminger [this message]
2025-11-21 12:04     ` [PATCH v4 3/8] test: avoid overflowing huge directory path Burakov, Anatoly
2025-11-20 16:55   ` [PATCH v4 4/8] test: use unit test runner for eal flags Stephen Hemminger
2025-11-21 12:06     ` Burakov, Anatoly
2025-11-20 16:55   ` [PATCH v4 5/8] test: fix format overflow warning in ACL test Stephen Hemminger
2025-11-21 12:06     ` Burakov, Anatoly
2025-11-20 16:55   ` [PATCH v4 6/8] test: fix impossible format-truncation in cfgfiles Stephen Hemminger
2025-11-21 12:09     ` Burakov, Anatoly
2025-11-20 16:55   ` [PATCH v4 7/8] test: fix format overflow in cryptodev test Stephen Hemminger
2025-11-21 12:08     ` Burakov, Anatoly
2025-11-20 16:55   ` [PATCH v4 8/8] test: re-enable format-truncation warnings Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251120165713.120238-4-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).