From: Stephen Hemminger <stephen@networkplumber.org>
To: a.schollmeyer@syseleven.de
Cc: Aman Singh <aman.deep.singh@intel.com>, dev@dpdk.org
Subject: Re: [PATCH] app/testpmd: warn on shared rxq switch mismatch
Date: Tue, 25 Nov 2025 06:30:51 -0800 [thread overview]
Message-ID: <20251125063051.0563732d@phoenix.local> (raw)
In-Reply-To: <20251125102207.428661-1-a.schollmeyer@syseleven.de>
On Tue, 25 Nov 2025 11:22:07 +0100
a.schollmeyer@syseleven.de wrote:
> + if (o_dom_id != dom_id) {
> + fprintf(stderr, "Bad shared rxq config: "
> + "switch domain mismatch in share group/qid %u/%u: "
> + "%u (port %u) vs. %u (port %u)\n",
> + (unsigned int)rxq->conf.share_group,
> + (unsigned int)rxq->conf.share_qid,
> + (unsigned int)dom_id,
> + (unsigned int)port_id,
> + (unsigned int)o_dom_id,
> + (unsigned int)pid);
> + } else if (o_rx_dom != rx_dom) {
> + fprintf(stderr, "Bad shared rxq config: "
> + "switch rx domain mismatch in share group/qid %u/%u: "
> + "%u (port %u) vs. %u (port %u)\n",
> + (unsigned int)rxq->conf.share_group,
> + (unsigned int)rxq->conf.share_qid,
> + (unsigned int)rx_dom,
> + (unsigned int)port_id,
> + (unsigned int)o_rx_dom,
> + (unsigned int)pid);
> + }
Same message repeated twice, change the if logic.
Also, why so many casts? Those should all be unsigned.
prev parent reply other threads:[~2025-11-25 14:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 10:22 a.schollmeyer
2025-11-25 14:30 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251125063051.0563732d@phoenix.local \
--to=stephen@networkplumber.org \
--cc=a.schollmeyer@syseleven.de \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).