[PATCH] app/testpmd: warn on shared rxq switch mismatch

[PATCH] app/testpmd: warn on shared rxq switch mismatch

[a.schollmeyer]

From: Adrian Schollmeyer <a.schollmeyer@syseleven.de>

Shared Rx queues do not work with every combination of ports. Besides
requiring the corresponding device capability, shared Rx queues also
require all ports of one share group and queue ID have the same switch
domain and Rx domain. When these fields do not match, shared Rx queues
are not properly set up and queue sharing may fail silently. This can
happen even in some less intuitive cases like multiple VFs of one
physical NIC.

To make debugging issues with shared Rx queue configuration easier, this
commit introduces simple checks and warning messages for all members of
a share_group and share_qid to warn whenever there is a mismatch in the
switch and Rx domain.

Signed-off-by: Adrian Schollmeyer <a.schollmeyer@syseleven.de>
---
 app/test-pmd/testpmd.c | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 1fe41d852a..6e42930730 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2675,6 +2675,48 @@ rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,
 	uint32_t prev_hdrs = 0;
 	int ret;
 
+	if (rx_conf->share_group > 0) {
+		/* Additional warnings for bad Rx queue sharing */
+
+		const uint16_t dom_id = ports[port_id].dev_info.switch_info.domain_id;
+		const uint16_t rx_dom = ports[port_id].dev_info.switch_info.rx_domain;
+
+		uint16_t pid;
+		RTE_ETH_FOREACH_DEV(pid) {
+			struct rte_port *o_port = &ports[pid];
+			for (uint16_t q = 0; q < nb_rxq; ++q) {
+				struct port_rxqueue *rxq = &o_port->rxq[q];
+				if (rxq->conf.share_group != rx_conf->share_group ||
+						rxq->conf.share_qid != rx_conf->share_qid)
+					continue;
+
+				const uint16_t o_dom_id = o_port->dev_info.switch_info.domain_id;
+				const uint16_t o_rx_dom = o_port->dev_info.switch_info.rx_domain;
+
+				if (o_dom_id != dom_id) {
+					fprintf(stderr, "Bad shared rxq config: "
+						"switch domain mismatch in share group/qid %u/%u: "
+						"%u (port %u) vs. %u (port %u)\n",
+						(unsigned int)rxq->conf.share_group,
+						(unsigned int)rxq->conf.share_qid,
+						(unsigned int)dom_id,
+						(unsigned int)port_id,
+						(unsigned int)o_dom_id,
+						(unsigned int)pid);
+				} else if (o_rx_dom != rx_dom) {
+					fprintf(stderr, "Bad shared rxq config: "
+						"switch rx domain mismatch in share group/qid %u/%u: "
+						"%u (port %u) vs. %u (port %u)\n",
+						(unsigned int)rxq->conf.share_group,
+						(unsigned int)rxq->conf.share_qid,
+						(unsigned int)rx_dom,
+						(unsigned int)port_id,
+						(unsigned int)o_rx_dom,
+						(unsigned int)pid);
+				}
+			}
+		}
+	}
 
 	if ((rx_pkt_nb_segs > 1) &&
 	    (rx_conf->offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT)) {
-- 
2.34.1