From: Anurag Mandal <anurag.mandal@intel.com>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com, aman.deep.singh@intel.com,
stephen@networkplumber.org,
Anurag Mandal <anurag.mandal@intel.com>,
stable@dpdk.org
Subject: [PATCH] app/testpmd: fix incorrect function names in logs
Date: Mon, 1 Dec 2025 10:08:36 +0000 [thread overview]
Message-ID: <20251201100837.422764-1-anurag.mandal@intel.com> (raw)
VLAN extend and tpid setting functions have wrong function names
mentioned in the error logs causing confusion as functions are
not found in code using those names.
Replaced static names with dynamic "__func__" predefined identifier.
Fixes: 61a3b0e5e79f ("app/testpmd: send failure logs to stderr")
Cc: stable@dpdk.org
Signed-off-by: Anurag Mandal <anurag.mandal@intel.com>
---
app/test-pmd/config.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 6ea506254b..afaf9194ba 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -6502,8 +6502,8 @@ vlan_extend_set(portid_t port_id, int on)
diag = rte_eth_dev_set_vlan_offload(port_id, vlan_offload);
if (diag < 0) {
fprintf(stderr,
- "rx_vlan_extend_set(port_pi=%d, on=%d) failed diag=%d\n",
- port_id, on, diag);
+ "%s(port_pi=%d, on=%d) failed diag=%d\n",
+ __func__, port_id, on, diag);
return;
}
ports[port_id].dev_conf.rxmode.offloads = port_rx_offloads;
@@ -6729,8 +6729,8 @@ vlan_tpid_set(portid_t port_id, enum rte_vlan_type vlan_type, uint16_t tp_id)
return;
fprintf(stderr,
- "tx_vlan_tpid_set(port_pi=%d, vlan_type=%d, tpid=%d) failed diag=%d\n",
- port_id, vlan_type, tp_id, diag);
+ "%s(port_pi=%d, vlan_type=%d, tpid=%d) failed diag=%d\n",
+ __func__, port_id, vlan_type, tp_id, diag);
}
void
--
2.43.0
next reply other threads:[~2025-12-01 10:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 10:08 Anurag Mandal [this message]
2025-12-01 15:58 ` Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251201100837.422764-1-anurag.mandal@intel.com \
--to=anurag.mandal@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).