From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
stable@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH v3 08/31] power: rename variable to eliminate shadowing
Date: Mon, 1 Dec 2025 11:44:25 +0000 [thread overview]
Message-ID: <20251201114448.1441377-9-bruce.richardson@intel.com> (raw)
In-Reply-To: <20251201114448.1441377-1-bruce.richardson@intel.com>
The "pause_duration" variable is a global and then shadowed as a local
var in clb_pause. Rename the local variable to allow building with
"-Wshadow".
Fixes: 4a8fbc28e431 ("power: add get/set pause duration API")
Cc: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/power/rte_power_pmd_mgmt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/power/rte_power_pmd_mgmt.c b/lib/power/rte_power_pmd_mgmt.c
index 6cacc562c2..a4d53aac2a 100644
--- a/lib/power/rte_power_pmd_mgmt.c
+++ b/lib/power/rte_power_pmd_mgmt.c
@@ -337,7 +337,7 @@ clb_pause(uint16_t port_id __rte_unused, uint16_t qidx __rte_unused,
struct queue_list_entry *queue_conf = arg;
struct pmd_core_cfg *lcore_conf;
const bool empty = nb_rx == 0;
- uint32_t pause_duration = rte_power_pmd_mgmt_get_pause_duration();
+ const uint32_t duration = rte_power_pmd_mgmt_get_pause_duration();
lcore_conf = RTE_LCORE_VAR(lcore_cfgs);
@@ -357,11 +357,11 @@ clb_pause(uint16_t port_id __rte_unused, uint16_t qidx __rte_unused,
if (global_data.intrinsics_support.power_pause) {
const uint64_t cur = rte_rdtsc();
const uint64_t wait_tsc =
- cur + global_data.tsc_per_us * pause_duration;
+ cur + global_data.tsc_per_us * duration;
rte_power_pause(wait_tsc);
} else {
uint64_t i;
- for (i = 0; i < global_data.pause_per_us * pause_duration; i++)
+ for (i = 0; i < global_data.pause_per_us * duration; i++)
rte_pause();
}
}
--
2.51.0
next prev parent reply other threads:[~2025-12-01 11:46 UTC|newest]
Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 14:09 [RFC PATCH 00/19] Fix building much of DPDK with -Wshadow Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 01/19] eal: fix variable shadowing Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 02/19] ethdev: fix variable shadowing issues Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 03/19] eventdev: " Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 04/19] net: remove shadowed variable Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 05/19] graph: fix variable shadowing errors Bruce Richardson
2025-11-06 15:50 ` Stephen Hemminger
2025-11-06 16:33 ` Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 06/19] pipeline: fix variable shadowing Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 07/19] table: fix issues with " Bruce Richardson
2025-11-06 19:37 ` Stephen Hemminger
2025-11-06 19:58 ` Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 08/19] power: rename variable to eliminate shadowing Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 09/19] pcapng: rename variable to fix shadowing Bruce Richardson
2025-11-06 15:51 ` Stephen Hemminger
2025-11-06 14:09 ` [RFC PATCH 10/19] telemetry: make socket handler typedef private Bruce Richardson
2025-11-07 2:43 ` fengchengwen
2025-11-06 14:09 ` [RFC PATCH 11/19] bbdev: fix variable shadowing Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 12/19] bus/pci: remove shadowed variables Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 13/19] net/intel: rename function param to avoid shadow warnings Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 14/19] net/e1000: fix build with shadow warnings enabled Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 15/19] net/i40e: " Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 16/19] net/ice: " Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 17/19] net/cpfl: " Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 18/19] net/ixgbe: " Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 19/19] app/test-pmd: " Bruce Richardson
2025-11-07 15:49 ` [RFC PATCH v2 00/33] build DPDK with -Wshadow Bruce Richardson
2025-11-07 15:49 ` [RFC PATCH v2 01/33] eal: add more min/max helpers Bruce Richardson
2025-11-10 0:59 ` fengchengwen
2025-11-10 8:53 ` Morten Brørup
2025-11-10 8:58 ` Bruce Richardson
2025-11-07 15:49 ` [RFC PATCH v2 02/33] eal: fix variable shadowing Bruce Richardson
2025-11-10 0:59 ` fengchengwen
2025-11-07 15:49 ` [RFC PATCH v2 03/33] ethdev: fix variable shadowing issues Bruce Richardson
2025-11-09 14:36 ` Andrew Rybchenko
2025-11-10 1:12 ` fengchengwen
2025-11-07 15:50 ` [RFC PATCH v2 04/33] eventdev: " Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 05/33] net: remove shadowed variable Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 06/33] pipeline: fix variable shadowing Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 07/33] table: fix issues with " Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 08/33] power: rename variable to eliminate shadowing Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 09/33] pcapng: rename variable to fix shadowing Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 10/33] telemetry: make socket handler typedef private Bruce Richardson
2025-11-10 1:15 ` fengchengwen
2025-11-07 15:50 ` [RFC PATCH v2 11/33] bbdev: fix variable shadowing Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 12/33] bus/pci: remove shadowed variables Bruce Richardson
2025-11-10 1:15 ` fengchengwen
2025-11-07 15:50 ` [RFC PATCH v2 13/33] net/intel: rename function param to avoid shadow warnings Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 14/33] net/e1000: fix build with shadow warnings enabled Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 15/33] net/i40e: " Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 16/33] net/ice: " Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 17/33] net/cpfl: " Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 18/33] net/ixgbe: " Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 19/33] app/test-pmd: " Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 20/33] app/graph: " Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 21/33] app/pdump: fix warning about shadowed variable Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 22/33] app/test-bbdev: use RTE_MAX3 to remove variable shadowing Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 23/33] app/test-compress-perf: fix " Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 24/33] app/test-crypto-perf: fix shadowed variable Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 25/33] app/test-dma-perf: renamed " Bruce Richardson
2025-11-10 1:13 ` fengchengwen
2025-11-07 15:50 ` [RFC PATCH v2 26/33] app/test-eventdev: fix build with shadow warnings enabled Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 27/33] app/test-flow-perf: remove unneeded variable Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 28/33] app/test-security-perf: fix build with shadow warnings Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 29/33] app/test-pipeline: remove unnecessary variable Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 30/33] drivers: disable variable shadowing warnings for drivers Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 31/33] app/test: disable shadowing warnings for unit tests Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 32/33] examples: ignore variable shadowing warnings Bruce Richardson
2025-11-10 1:14 ` fengchengwen
2025-11-07 15:50 ` [RFC PATCH v2 33/33] build: enable shadowed variable warnings Bruce Richardson
2025-11-10 1:17 ` fengchengwen
2025-11-07 16:02 ` [RFC PATCH v2 00/33] build DPDK with -Wshadow Stephen Hemminger
2025-11-07 16:13 ` Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 00/31] build DPDK with Wshadow flag Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 01/31] eal: add more min/max helpers Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 02/31] eal: fix variable shadowing Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 03/31] ethdev: fix variable shadowing issues Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 04/31] eventdev: " Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 05/31] net: remove shadowed variable Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 06/31] pipeline: fix variable shadowing Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 07/31] table: fix issues with " Bruce Richardson
2025-12-01 11:44 ` Bruce Richardson [this message]
2025-12-01 11:44 ` [PATCH v3 09/31] pcapng: rename variable to fix shadowing Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 10/31] bbdev: fix variable shadowing Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 11/31] bus/pci: remove shadowed variables Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 12/31] net/intel: rename function param to avoid shadow warnings Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 13/31] net/e1000: fix build with shadow warnings enabled Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 14/31] net/i40e: " Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 15/31] net/ice: " Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 16/31] net/cpfl: " Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 17/31] net/ixgbe: " Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 18/31] app/testpmd: " Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 19/31] app/graph: " Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 20/31] app/pdump: fix warning about shadowed variable Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 21/31] app/test-bbdev: remove shadow warning from next max calls Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 22/31] app/test-compress-perf: rename local vars to fix shadowing Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 23/31] app/test-crypto-perf: " Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 24/31] app/test-eventdev: fix build with shadow warnings enabled Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 25/31] app/test-flow-perf: remove unneeded variable Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 26/31] app/test-security-perf: fix build with shadow warnings Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 27/31] app/test-pipeline: remove unnecessary variable Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 28/31] drivers: disable variable shadowing warnings for drivers Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 29/31] app/test: disable shadowing warnings for unit tests Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 30/31] examples: ignore variable shadowing warnings Bruce Richardson
2025-12-01 11:44 ` [PATCH v3 31/31] build: enable shadowed variable warnings Bruce Richardson
2025-12-01 11:49 ` [PATCH v3 00/31] build DPDK with Wshadow flag Bruce Richardson
2025-12-01 15:58 ` Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251201114448.1441377-9-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).