From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH] app/test: remove use of coremasks
Date: Mon, 1 Dec 2025 18:10:24 +0000 [thread overview]
Message-ID: <20251201181024.1583767-1-bruce.richardson@intel.com> (raw)
A number of test cases spawned off secondary processes and used the
"-c", or coremask, EAL option to do so. This option is deprecated, so
replace it with "-l" in tests.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
app/test/test_mp_secondary.c | 13 ++++++-------
app/test/test_pdump.c | 7 +++----
app/test/test_timer_secondary.c | 6 +++---
3 files changed, 12 insertions(+), 14 deletions(-)
diff --git a/app/test/test_mp_secondary.c b/app/test/test_mp_secondary.c
index f3694530a8..2593454b2c 100644
--- a/app/test/test_mp_secondary.c
+++ b/app/test/test_mp_secondary.c
@@ -66,7 +66,7 @@ static int
run_secondary_instances(void)
{
int ret = 0;
- char coremask[10];
+ char core_str[10];
#ifdef RTE_EXEC_ENV_LINUX
char tmp[PATH_MAX] = {0};
@@ -81,29 +81,28 @@ run_secondary_instances(void)
/* good case, using secondary */
const char *argv1[] = {
- prgname, "-c", coremask, "--proc-type=secondary",
+ prgname, "-l", core_str, "--proc-type=secondary",
prefix
};
/* good case, using auto */
const char *argv2[] = {
- prgname, "-c", coremask, "--proc-type=auto",
+ prgname, "-l", core_str, "--proc-type=auto",
prefix
};
/* bad case, using invalid type */
const char *argv3[] = {
- prgname, "-c", coremask, "--proc-type=ERROR",
+ prgname, "-l", core_str, "--proc-type=ERROR",
prefix
};
#ifdef RTE_EXEC_ENV_LINUX
/* bad case, using invalid file prefix */
const char *argv4[] = {
- prgname, "-c", coremask, "--proc-type=secondary",
+ prgname, "-l", core_str, "--proc-type=secondary",
"--file-prefix=ERROR"
};
#endif
- snprintf(coremask, sizeof(coremask), "%x", \
- (1 << rte_get_main_lcore()));
+ snprintf(core_str, sizeof(core_str), "%u", rte_get_main_lcore());
ret |= launch_proc(argv1);
printf("### Testing rte_mp_disable() reject:\n");
diff --git a/app/test/test_pdump.c b/app/test/test_pdump.c
index 9f7769707e..1d3fe6e2d5 100644
--- a/app/test/test_pdump.c
+++ b/app/test/test_pdump.c
@@ -173,7 +173,7 @@ int
run_pdump_server_tests(void)
{
int ret = 0;
- char coremask[10];
+ char core_str[10];
#ifdef RTE_EXEC_ENV_LINUX
char tmp[PATH_MAX] = { 0 };
@@ -187,12 +187,11 @@ run_pdump_server_tests(void)
/* good case, using secondary */
const char *const argv1[] = {
- prgname, "-c", coremask, "--proc-type=secondary",
+ prgname, "-l", core_str, "--proc-type=secondary",
prefix
};
- snprintf(coremask, sizeof(coremask), "%x",
- (1 << rte_get_main_lcore()));
+ snprintf(core_str, sizeof(core_str), "%u", rte_get_main_lcore());
ret = test_pdump_init();
ret |= launch_p(argv1);
diff --git a/app/test/test_timer_secondary.c b/app/test/test_timer_secondary.c
index 4e220559b4..60ce8c7507 100644
--- a/app/test/test_timer_secondary.c
+++ b/app/test/test_timer_secondary.c
@@ -50,7 +50,7 @@ struct test_info {
static int
timer_secondary_spawn_wait(unsigned int lcore)
{
- char coremask[10];
+ char core_str[10];
#ifdef RTE_EXEC_ENV_LINUXAPP
char tmp[PATH_MAX] = {0};
char prefix[PATH_MAX] = {0};
@@ -63,12 +63,12 @@ timer_secondary_spawn_wait(unsigned int lcore)
#endif
char const *argv[] = {
prgname,
- "-c", coremask,
+ "-l", core_str,
"--proc-type=secondary",
prefix
};
- snprintf(coremask, sizeof(coremask), "%x", (1 << lcore));
+ snprintf(core_str, sizeof(core_str), "%u", lcore);
return launch_proc(argv);
}
--
2.51.0
next reply other threads:[~2025-12-01 18:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 18:10 Bruce Richardson [this message]
2025-12-01 18:37 ` Stephen Hemminger
2025-12-02 1:07 ` fengchengwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251201181024.1583767-1-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).