DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>, stable@dpdk.org
Subject: [PATCH v2 04/10] app/test: fix timer loop hang on secondary process failure
Date: Thu,  4 Dec 2025 18:20:41 +0000	[thread overview]
Message-ID: <20251204182047.3154429-5-bruce.richardson@intel.com> (raw)
In-Reply-To: <20251204182047.3154429-1-bruce.richardson@intel.com>

When the secondary process run from timer_secontary_autotest fails, the
timer loop is never stopped so the whole process hangs until timeout.
Fix this by setting the stop flag before checking for success or failure
of the secondary process.

Fixes: 50247fe03fe0 ("test/timer: exercise new APIs in secondary process")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 app/test/test_timer_secondary.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/app/test/test_timer_secondary.c b/app/test/test_timer_secondary.c
index ee2675a821..8580880a56 100644
--- a/app/test/test_timer_secondary.c
+++ b/app/test/test_timer_secondary.c
@@ -160,11 +160,12 @@ test_timer_secondary(void)
 		TEST_ASSERT_SUCCESS(ret, "Failed to launch timer manage loop");
 
 		ret = timer_secondary_spawn_wait(*sec_lcorep);
-		TEST_ASSERT_SUCCESS(ret, "Secondary process execution failed");
+		/* must set exit flag even on error case, so check ret later */
 
 		rte_delay_ms(500);
-
 		test_info->exit_flag = 1;
+
+		TEST_ASSERT_SUCCESS(ret, "Secondary process execution failed");
 		rte_eal_wait_lcore(*mgr_lcorep);
 
 #ifdef RTE_LIBRTE_TIMER_DEBUG
-- 
2.51.0


  parent reply	other threads:[~2025-12-04 18:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-02 15:49 [PATCH 0/2] improve fast-tests suite Bruce Richardson
2025-12-02 15:49 ` [PATCH 1/2] app/test: add some unattached tests to fast-test suite Bruce Richardson
2025-12-02 15:49 ` [PATCH 2/2] app/test: make parameters clearer when adding fast tests Bruce Richardson
2025-12-02 16:53   ` Marat Khalili
2025-12-02 18:16     ` Bruce Richardson
2025-12-04 18:20 ` [PATCH v2 00/10] Assign all unit tests to suites Bruce Richardson
2025-12-04 18:20   ` [PATCH v2 01/10] app/test: make parameters clearer when adding fast tests Bruce Richardson
2025-12-05 10:10     ` Marat Khalili
2025-12-05 10:17       ` Bruce Richardson
2025-12-04 18:20   ` [PATCH v2 02/10] app/test: fix undefined behaviour in red autotest Bruce Richardson
2025-12-05 10:25     ` Marat Khalili
2025-12-04 18:20   ` [PATCH v2 03/10] app/test: reduce duration of secondary timer test Bruce Richardson
2025-12-04 18:20   ` Bruce Richardson [this message]
2025-12-04 18:20   ` [PATCH v2 05/10] eal: add internal APIs to query loaded driver paths Bruce Richardson
2025-12-04 18:20   ` [PATCH v2 06/10] app/test: pass loaded driver info to secondary procs Bruce Richardson
2025-12-04 18:20   ` [PATCH v2 07/10] app/test: skip power capabilities test if unsupported Bruce Richardson
2025-12-04 18:20   ` [PATCH v2 08/10] app/test: add some unattached tests to fast-test suite Bruce Richardson
2025-12-05 12:37     ` David Marchand
2025-12-05 12:43       ` Bruce Richardson
2025-12-05 12:50         ` David Marchand
2025-12-05 12:53           ` Bruce Richardson
2025-12-05 13:08             ` David Marchand
2025-12-04 18:20   ` [PATCH v2 09/10] app/test: add tests to driver test suite Bruce Richardson
2025-12-04 18:20   ` [PATCH v2 10/10] buildtools/get-test-suites: suppress empty output Bruce Richardson
2025-12-05 10:29     ` Marat Khalili

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251204182047.3154429-5-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).