From: Stephen Hemminger <stephen@networkplumber.org>
To: Kevin Traynor <ktraynor@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: Minutes of Technical Board Meeting, 2024-November-26
Date: Thu, 11 Dec 2025 10:21:32 +0900 [thread overview]
Message-ID: <20251211102132.14addc9b@stephen-xps.local> (raw)
In-Reply-To: <d4dccf88-6813-4bbc-b75e-a8ea4240ce1b@redhat.com>
On Wed, 10 Dec 2025 15:01:50 +0000
Kevin Traynor <ktraynor@redhat.com> wrote:
> # Discussion of VLAN offload in PMD
>
> - Discussion over patch for nbl driver that hard codes a return 0 forJ
> vlan_offload_set callback
> - https://inbox.dpdk.org/dev/20251124153545.7123c338@phoenix.local/
> - vlan offload is done in software
> - Issue is that existing OOT driver does this, so it would break apps vs
> in-tree driver if it returned ENOSUP
> - For current release, leave code as is
> - For future release, consider to do some validation at ethdev level
Just to follow up, the underlying problem here was me misreading the code.
The driver is doing VLAN offload in software which is fine (it is what virtio does).
It does raise the issue of maybe this should be done in ethdev layer so
all drivers that don't do HW offload could just be done in software by ethdev.
That would make the mbuf consistent across all drivers.
prev parent reply other threads:[~2025-12-11 1:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 15:01 Kevin Traynor
2025-12-11 1:21 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251211102132.14addc9b@stephen-xps.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).