From: Ciara Loftus <ciara.loftus@intel.com>
To: dev@dpdk.org
Cc: Ciara Loftus <ciara.loftus@intel.com>
Subject: [PATCH v2 1/3] net/intel: prevent selection of a null Tx burst function
Date: Tue, 16 Dec 2025 10:35:02 +0000 [thread overview]
Message-ID: <20251216103504.2624535-2-ciara.loftus@intel.com> (raw)
In-Reply-To: <20251216103504.2624535-1-ciara.loftus@intel.com>
Depending on the underlying architecture and CPU flags available, a
different set of Tx paths may be defined by a driver using the common
path selection infrastructure. However the Tx path selection function
iterates through the entire array of potential Tx paths, regardless of
whether they are available for selection by that platform. This could
result in a null Tx burst function being selected. Fix this by
discarding paths with a null Tx burst function from selection.
Fixes: 336374d8454c ("net/intel: introduce infrastructure for Tx path selection")
Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
drivers/net/intel/common/tx.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/intel/common/tx.h b/drivers/net/intel/common/tx.h
index 24fcfbe225..b259d98904 100644
--- a/drivers/net/intel/common/tx.h
+++ b/drivers/net/intel/common/tx.h
@@ -307,6 +307,10 @@ ci_tx_path_select(const struct ci_tx_path_features *req_features,
for (unsigned int i = 0; i < num_paths; i++) {
const struct ci_tx_path_features *path_features = &infos[i].features;
+ /* Do not select a path with a NULL pkt_burst function. */
+ if (infos[i].pkt_burst == NULL)
+ continue;
+
/* Do not select a disabled tx path. */
if (path_features->disabled)
continue;
--
2.43.0
next prev parent reply other threads:[~2025-12-16 10:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 14:05 [PATCH 0/8] Fixes for Intel common rx/tx path selection Ciara Loftus
2025-12-15 14:05 ` [PATCH 1/8] net/i40e: ensure all Tx paths are selectable Ciara Loftus
2025-12-15 14:05 ` [PATCH 2/8] net/iavf: " Ciara Loftus
2025-12-15 14:05 ` [PATCH 3/8] net/ice: " Ciara Loftus
2025-12-15 14:05 ` [PATCH 4/8] net/idpf: " Ciara Loftus
2025-12-15 14:05 ` [PATCH 5/8] net/i40e: ensure all Rx " Ciara Loftus
2025-12-15 14:05 ` [PATCH 6/8] net/iavf: " Ciara Loftus
2025-12-15 14:05 ` [PATCH 7/8] net/ice: " Ciara Loftus
2025-12-15 14:05 ` [PATCH 8/8] net/idpf: " Ciara Loftus
2025-12-15 14:58 ` [PATCH 0/8] Fixes for Intel common rx/tx path selection Bruce Richardson
2025-12-16 9:06 ` Loftus, Ciara
2025-12-16 10:35 ` [PATCH v2 0/3] " Ciara Loftus
2025-12-16 10:35 ` Ciara Loftus [this message]
2025-12-16 12:05 ` [PATCH v2 1/3] net/intel: prevent selection of a null Tx burst function Bruce Richardson
2025-12-16 10:35 ` [PATCH v2 2/3] net/intel: prevent selection of a null Rx " Ciara Loftus
2025-12-16 12:06 ` Bruce Richardson
2025-12-16 10:35 ` [PATCH v2 3/3] net/intel: bring common Rx path selection in line with Tx Ciara Loftus
2025-12-16 12:06 ` Bruce Richardson
2025-12-16 12:28 ` [PATCH v2 0/3] Fixes for Intel common rx/tx path selection Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251216103504.2624535-2-ciara.loftus@intel.com \
--to=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).