DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH v2 0/2] net/i40e: Fix aarch32 build and vector flag setting
@ 2025-12-18 15:42 Ciara Loftus
  2025-12-18 15:42 ` [PATCH v2 1/2] net/i40e: fix 32-bit Arm build Ciara Loftus
  2025-12-18 15:42 ` [PATCH v2 2/2] net/i40e: unset vector flag when scalar path is chosen Ciara Loftus
  0 siblings, 2 replies; 3+ messages in thread
From: Ciara Loftus @ 2025-12-18 15:42 UTC (permalink / raw)
  To: dev; +Cc: Ciara Loftus

Fix two issues present on the i40e driver that were introduced by the tx path selection series:
1. Fix a build failure on 32-bit arm caused by an unused function.
2. Ensure that the vector flag is unset when the scalar path is chosen.

If possible both can be squashed into the commit they fix on next-net-intel.

Ciara Loftus (2):
  net/i40e: fix 32-bit Arm build
  net/i40e: unset vector flag when scalar path is chosen

 drivers/net/intel/i40e/i40e_rxtx.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2 1/2] net/i40e: fix 32-bit Arm build
  2025-12-18 15:42 [PATCH v2 0/2] net/i40e: Fix aarch32 build and vector flag setting Ciara Loftus
@ 2025-12-18 15:42 ` Ciara Loftus
  2025-12-18 15:42 ` [PATCH v2 2/2] net/i40e: unset vector flag when scalar path is chosen Ciara Loftus
  1 sibling, 0 replies; 3+ messages in thread
From: Ciara Loftus @ 2025-12-18 15:42 UTC (permalink / raw)
  To: dev; +Cc: Ciara Loftus

i40e_xmit_pkts_vec can be built for both aarch32 and aarch64.

Fixes: 1ff08bb7ad90 ("net/i40e: use common Tx path selection infrastructure")

Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
 drivers/net/intel/i40e/i40e_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/intel/i40e/i40e_rxtx.c b/drivers/net/intel/i40e/i40e_rxtx.c
index 2db58c6b24..cde60cc7bd 100644
--- a/drivers/net/intel/i40e/i40e_rxtx.c
+++ b/drivers/net/intel/i40e/i40e_rxtx.c
@@ -1598,7 +1598,7 @@ static const struct ci_tx_path_info i40e_tx_path_infos[] = {
 		.pkt_prep = i40e_simple_prep_pkts,
 	},
 #endif
-#elif defined(RTE_ARCH_ARM64)
+#elif defined(RTE_ARCH_ARM)
 	[I40E_TX_NEON] = {
 		.pkt_burst = i40e_xmit_pkts_vec,
 		.info = "Vector Neon",
-- 
2.43.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2 2/2] net/i40e: unset vector flag when scalar path is chosen
  2025-12-18 15:42 [PATCH v2 0/2] net/i40e: Fix aarch32 build and vector flag setting Ciara Loftus
  2025-12-18 15:42 ` [PATCH v2 1/2] net/i40e: fix 32-bit Arm build Ciara Loftus
@ 2025-12-18 15:42 ` Ciara Loftus
  1 sibling, 0 replies; 3+ messages in thread
From: Ciara Loftus @ 2025-12-18 15:42 UTC (permalink / raw)
  To: dev; +Cc: Ciara Loftus

The tx_vec_allowed flag should be set to false if a scalar Tx path is
chosen.

Fixes: 1ff08bb7ad90 ("net/i40e: use common Tx path selection infrastructure")

Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
 drivers/net/intel/i40e/i40e_rxtx.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/intel/i40e/i40e_rxtx.c b/drivers/net/intel/i40e/i40e_rxtx.c
index cde60cc7bd..290fec2b0a 100644
--- a/drivers/net/intel/i40e/i40e_rxtx.c
+++ b/drivers/net/intel/i40e/i40e_rxtx.c
@@ -3631,6 +3631,10 @@ i40e_set_tx_function(struct rte_eth_dev *dev)
 			ad->tx_func_type == I40E_TX_ALTIVEC ||
 			ad->tx_func_type == I40E_TX_AVX2)
 		dev->recycle_tx_mbufs_reuse = i40e_recycle_tx_mbufs_reuse_vec;
+
+	ad->tx_vec_allowed =
+		(i40e_tx_path_infos[ad->tx_func_type].features.simd_width >= RTE_VECT_SIMD_128);
+
 }
 
 int
-- 
2.43.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-12-18 15:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-18 15:42 [PATCH v2 0/2] net/i40e: Fix aarch32 build and vector flag setting Ciara Loftus
2025-12-18 15:42 ` [PATCH v2 1/2] net/i40e: fix 32-bit Arm build Ciara Loftus
2025-12-18 15:42 ` [PATCH v2 2/2] net/i40e: unset vector flag when scalar path is chosen Ciara Loftus

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).