From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90D5E47091; Fri, 19 Dec 2025 18:29:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB4E940DDD; Fri, 19 Dec 2025 18:26:47 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mails.dpdk.org (Postfix) with ESMTP id B17C740DD3 for ; Fri, 19 Dec 2025 18:26:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1766165206; x=1797701206; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=MUQBqW6HSRMbMMDm9U913N0M1BpcgDsBzzgExM9B1f8=; b=lVnxdwYk5pKEmCR8tp+owYue5P6x77UiSA5AoSdQBDYnwrGUCwtRHC5U rzw+ryiEu2k4Sl0MIpnSdVuULGwGjrpHt6/maxfMxINGR+nNed32t/ztg UuQtBKCUx3p3vhS+V/7W1IRabDQDijvTLAcdxYeZb8nc+J9JcpAj7AolB 8MWLZqaM9MOUU7D9OMYXm/H+7aLn18g4P3tFMF1JTAwCfnDeycM2YntHp CKO5ipRHz0hLT7voa/KJNiWgRVxup56Pamhw8kzwm5DB/KboDmvQYRjRF 1/80NFoZNpIRCa2bHtm6ShfQJEj1uzXGUno7Wc7eD7Z/GPb+VUJwVSl5Z A==; X-CSE-ConnectionGUID: Ehv7yw3jRYO7BQzkncfLnA== X-CSE-MsgGUID: oY2QAA7ZRMaaikutA/FfBA== X-IronPort-AV: E=McAfee;i="6800,10657,11647"; a="71759530" X-IronPort-AV: E=Sophos;i="6.21,161,1763452800"; d="scan'208";a="71759530" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2025 09:26:46 -0800 X-CSE-ConnectionGUID: HBrHkwtlTo+SijPSVbRPXQ== X-CSE-MsgGUID: LtnwD1ugRwSy2V6Mr0yMFw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,161,1763452800"; d="scan'208";a="198170540" Received: from silpixa00401385.ir.intel.com ([10.20.224.226]) by orviesa010.jf.intel.com with ESMTP; 19 Dec 2025 09:26:44 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , Vladimir Medvedkin , Anatoly Burakov , Jingjing Wu , Praveen Shetty Subject: [RFC PATCH 27/27] net/intel: remove index for tracking end of packet Date: Fri, 19 Dec 2025 17:25:44 +0000 Message-ID: <20251219172548.2660777-28-bruce.richardson@intel.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251219172548.2660777-1-bruce.richardson@intel.com> References: <20251219172548.2660777-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The last_id value in each tx_sw_queue entry was no longer used in the datapath, remove it and its initialization. For the function releasing packets back, rather than relying on "last_id" to identify end of packet, instead check for the next pointer being NULL. Signed-off-by: Bruce Richardson --- drivers/net/intel/common/tx.h | 1 - drivers/net/intel/i40e/i40e_rxtx.c | 8 +++----- drivers/net/intel/iavf/iavf_rxtx.c | 9 ++++----- drivers/net/intel/ice/ice_dcf_ethdev.c | 1 - drivers/net/intel/ice/ice_rxtx.c | 9 ++++----- drivers/net/intel/idpf/idpf_common_rxtx.c | 2 -- drivers/net/intel/ixgbe/ixgbe_rxtx.c | 9 ++++----- 7 files changed, 15 insertions(+), 24 deletions(-) diff --git a/drivers/net/intel/common/tx.h b/drivers/net/intel/common/tx.h index 3976766f06..2d3626cbda 100644 --- a/drivers/net/intel/common/tx.h +++ b/drivers/net/intel/common/tx.h @@ -104,7 +104,6 @@ struct ci_tx_queue; struct ci_tx_entry { struct rte_mbuf *mbuf; /* mbuf associated with TX desc, if any. */ uint16_t next_id; /* Index of next descriptor in ring. */ - uint16_t last_id; /* Index of last scattered descriptor. */ }; /** diff --git a/drivers/net/intel/i40e/i40e_rxtx.c b/drivers/net/intel/i40e/i40e_rxtx.c index e1226d649b..9aa31d6168 100644 --- a/drivers/net/intel/i40e/i40e_rxtx.c +++ b/drivers/net/intel/i40e/i40e_rxtx.c @@ -2523,14 +2523,13 @@ i40e_tx_done_cleanup_full(struct ci_tx_queue *txq, pkt_cnt < free_cnt && tx_id != tx_last; i++) { if (swr_ring[tx_id].mbuf != NULL) { - rte_pktmbuf_free_seg(swr_ring[tx_id].mbuf); - swr_ring[tx_id].mbuf = NULL; - /* * last segment in the packet, * increment packet count */ - pkt_cnt += (swr_ring[tx_id].last_id == tx_id); + pkt_cnt += (swr_ring[tx_id].mbuf->next == NULL) ? 1 : 0; + rte_pktmbuf_free_seg(swr_ring[tx_id].mbuf); + swr_ring[tx_id].mbuf = NULL; } tx_id = swr_ring[tx_id].next_id; @@ -2623,7 +2622,6 @@ i40e_reset_tx_queue(struct ci_tx_queue *txq) txd->cmd_type_offset_bsz = rte_cpu_to_le_64(CI_TX_DESC_DTYPE_DESC_DONE); txe[i].mbuf = NULL; - txe[i].last_id = i; txe[prev].next_id = i; prev = i; } diff --git a/drivers/net/intel/iavf/iavf_rxtx.c b/drivers/net/intel/iavf/iavf_rxtx.c index 9cac6e8841..558ae2598f 100644 --- a/drivers/net/intel/iavf/iavf_rxtx.c +++ b/drivers/net/intel/iavf/iavf_rxtx.c @@ -292,7 +292,6 @@ reset_tx_queue(struct ci_tx_queue *txq) txq->ci_tx_ring[i].cmd_type_offset_bsz = rte_cpu_to_le_64(CI_TX_DESC_DTYPE_DESC_DONE); txe[i].mbuf = NULL; - txe[i].last_id = i; txe[prev].next_id = i; prev = i; } @@ -4002,14 +4001,14 @@ iavf_tx_done_cleanup_full(struct ci_tx_queue *txq, while (pkt_cnt < free_cnt) { do { if (swr_ring[tx_id].mbuf != NULL) { - rte_pktmbuf_free_seg(swr_ring[tx_id].mbuf); - swr_ring[tx_id].mbuf = NULL; - /* * last segment in the packet, * increment packet count */ - pkt_cnt += (swr_ring[tx_id].last_id == tx_id); + pkt_cnt += (swr_ring[tx_id].mbuf->next == NULL) ? 1 : 0; + rte_pktmbuf_free_seg(swr_ring[tx_id].mbuf); + swr_ring[tx_id].mbuf = NULL; + } tx_id = swr_ring[tx_id].next_id; diff --git a/drivers/net/intel/ice/ice_dcf_ethdev.c b/drivers/net/intel/ice/ice_dcf_ethdev.c index 02a23629d6..abd7875e7b 100644 --- a/drivers/net/intel/ice/ice_dcf_ethdev.c +++ b/drivers/net/intel/ice/ice_dcf_ethdev.c @@ -408,7 +408,6 @@ reset_tx_queue(struct ci_tx_queue *txq) txq->ci_tx_ring[i].cmd_type_offset_bsz = rte_cpu_to_le_64(CI_TX_DESC_DTYPE_DESC_DONE); txe[i].mbuf = NULL; - txe[i].last_id = i; txe[prev].next_id = i; prev = i; } diff --git a/drivers/net/intel/ice/ice_rxtx.c b/drivers/net/intel/ice/ice_rxtx.c index 092981f452..d11d9054f2 100644 --- a/drivers/net/intel/ice/ice_rxtx.c +++ b/drivers/net/intel/ice/ice_rxtx.c @@ -1118,7 +1118,6 @@ ice_reset_tx_queue(struct ci_tx_queue *txq) txd->cmd_type_offset_bsz = rte_cpu_to_le_64(CI_TX_DESC_DTYPE_DESC_DONE); txe[i].mbuf = NULL; - txe[i].last_id = i; txe[prev].next_id = i; prev = i; } @@ -3190,14 +3189,14 @@ ice_tx_done_cleanup_full(struct ci_tx_queue *txq, pkt_cnt < free_cnt && tx_id != tx_last; i++) { if (swr_ring[tx_id].mbuf != NULL) { - rte_pktmbuf_free_seg(swr_ring[tx_id].mbuf); - swr_ring[tx_id].mbuf = NULL; - /* * last segment in the packet, * increment packet count */ - pkt_cnt += (swr_ring[tx_id].last_id == tx_id); + pkt_cnt += swr_ring[tx_id].mbuf->next == NULL ? 1 : 0; + rte_pktmbuf_free_seg(swr_ring[tx_id].mbuf); + swr_ring[tx_id].mbuf = NULL; + } tx_id = swr_ring[tx_id].next_id; diff --git a/drivers/net/intel/idpf/idpf_common_rxtx.c b/drivers/net/intel/idpf/idpf_common_rxtx.c index b36e29c8d2..781310e564 100644 --- a/drivers/net/intel/idpf/idpf_common_rxtx.c +++ b/drivers/net/intel/idpf/idpf_common_rxtx.c @@ -218,7 +218,6 @@ idpf_qc_split_tx_descq_reset(struct ci_tx_queue *txq) prev = (uint16_t)(txq->sw_nb_desc - 1); for (i = 0; i < txq->sw_nb_desc; i++) { txe[i].mbuf = NULL; - txe[i].last_id = i; txe[prev].next_id = i; prev = i; } @@ -277,7 +276,6 @@ idpf_qc_single_tx_queue_reset(struct ci_tx_queue *txq) txq->ci_tx_ring[i].cmd_type_offset_bsz = rte_cpu_to_le_64(CI_TX_DESC_DTYPE_DESC_DONE); txe[i].mbuf = NULL; - txe[i].last_id = i; txe[prev].next_id = i; prev = i; } diff --git a/drivers/net/intel/ixgbe/ixgbe_rxtx.c b/drivers/net/intel/ixgbe/ixgbe_rxtx.c index 6b8ff20f61..5f4bee4f2f 100644 --- a/drivers/net/intel/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/intel/ixgbe/ixgbe_rxtx.c @@ -2407,14 +2407,14 @@ ixgbe_tx_done_cleanup_full(struct ci_tx_queue *txq, uint32_t free_cnt) pkt_cnt < free_cnt && tx_id != tx_last; i++) { if (swr_ring[tx_id].mbuf != NULL) { - rte_pktmbuf_free_seg(swr_ring[tx_id].mbuf); - swr_ring[tx_id].mbuf = NULL; - /* * last segment in the packet, * increment packet count */ - pkt_cnt += (swr_ring[tx_id].last_id == tx_id); + pkt_cnt += swr_ring[tx_id].mbuf->next == NULL ? 1 : 0; + rte_pktmbuf_free_seg(swr_ring[tx_id].mbuf); + swr_ring[tx_id].mbuf = NULL; + } tx_id = swr_ring[tx_id].next_id; @@ -2535,7 +2535,6 @@ ixgbe_reset_tx_queue(struct ci_tx_queue *txq) txd->wb.status = rte_cpu_to_le_32(IXGBE_TXD_STAT_DD); txe[i].mbuf = NULL; - txe[i].last_id = i; txe[prev].next_id = i; prev = i; } -- 2.51.0