* [PATCH v1] net/zxdh: add pcie bar channel check
@ 2025-12-09 2:16 Tianhao Zhang
2025-12-22 10:25 ` [PATCH v1 0/2] fix bug Tianhao Zhang
0 siblings, 1 reply; 6+ messages in thread
From: Tianhao Zhang @ 2025-12-09 2:16 UTC (permalink / raw)
To: stephen, wang.junlong1, yang.yonggang; +Cc: dev, Tianhao Zhang
[-- Attachment #1.1.1: Type: text/plain, Size: 1895 bytes --]
Add pcie bar channel check after getting dtb space left.
Signed-off-by: Tianhao Zhang <zhang.tianhao2@zte.com.cn>
---
drivers/net/zxdh/zxdh_np.c | 7 +++++++
drivers/net/zxdh/zxdh_np.h | 2 ++
2 files changed, 9 insertions(+)
diff --git a/drivers/net/zxdh/zxdh_np.c b/drivers/net/zxdh/zxdh_np.c
index 024da113e2..4e2637e1b6 100644
--- a/drivers/net/zxdh/zxdh_np.c
+++ b/drivers/net/zxdh/zxdh_np.c
@@ -3698,6 +3698,13 @@ zxdh_np_dtb_queue_unused_item_num_get(uint32_t dev_id,
rc = zxdh_np_reg_read(dev_id, ZXDH_DTB_INFO_QUEUE_BUF_SPACE,
0, queue_id, p_item_num);
ZXDH_COMM_CHECK_DEV_RC(dev_id, rc, "dpp_reg_read");
+
+ if((*p_item_num & ZXDH_DTB_SPACE_LEFT_MASK) == ZXDH_DTB_SPACE_LEFT_MASK)
+ {
+ PMD_DRV_LOG(ERR, "pcie bar abnormal, get dtb space left false.");
+ return ZXDH_RC_DTB_BAR_ABNORMAL;
+ }
+
return rc;
}
diff --git a/drivers/net/zxdh/zxdh_np.h b/drivers/net/zxdh/zxdh_np.h
index b0823192e7..5b9aec9c8f 100644
--- a/drivers/net/zxdh/zxdh_np.h
+++ b/drivers/net/zxdh/zxdh_np.h
@@ -94,6 +94,7 @@
#define ZXDH_DTB_TAB_ACK_SUCCESS_MASK (0xff)
#define ZXDH_DTB_TAB_ACK_FAILED_MASK (0x1)
#define ZXDH_DTB_TAB_ACK_CHECK_VALUE (0x12345678)
+#define ZXDH_DTB_SPACE_LEFT_MASK (0x3F)
#define ZXDH_DTB_TAB_ACK_VLD_SHIFT (104)
#define ZXDH_DTB_TAB_ACK_STATUS_SHIFT (96)
@@ -321,6 +322,7 @@
#define ZXDH_RC_DTB_DUMP_SIZE_SMALL (ZXDH_RC_DTB_BASE | 0x16)
#define ZXDH_RC_DTB_SEARCH_VPORT_QUEUE_ZERO (ZXDH_RC_DTB_BASE | 0x17)
#define ZXDH_RC_DTB_QUEUE_NOT_ENABLE (ZXDH_RC_DTB_BASE | 0x18)
+#define ZXDH_RC_DTB_BAR_ABNORMAL (ZXDH_RC_DTB_BASE | 0x19)
#define ZXDH_RC_CTRLCH_BASE (0xf00)
#define ZXDH_RC_CTRLCH_MSG_LEN_ZERO (ZXDH_RC_CTRLCH_BASE | 0x0)
--
2.27.0
[-- Attachment #1.1.2: Type: text/html , Size: 3784 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1 0/2] fix bug
2025-12-09 2:16 [PATCH v1] net/zxdh: add pcie bar channel check Tianhao Zhang
@ 2025-12-22 10:25 ` Tianhao Zhang
2025-12-22 10:25 ` [PATCH v1 1/2] net/zxdh: add pcie bar channel check Tianhao Zhang
2025-12-22 10:25 ` [PATCH v1 2/2] net/zxdh: delete np soft resource uninstallation Tianhao Zhang
0 siblings, 2 replies; 6+ messages in thread
From: Tianhao Zhang @ 2025-12-22 10:25 UTC (permalink / raw)
To: stephen, wang.junlong1, yang.yonggang; +Cc: dev, Tianhao Zhang
[-- Attachment #1.1.1: Type: text/plain, Size: 405 bytes --]
V1:
- Add pcie bar channel check after getting dtb space left.
- Delete np soft resource uninstallation from NP online uninit process.
Tianhao Zhang (2):
net/zxdh: add pcie bar channel check
net/zxdh: delete np soft resource uninstallation
drivers/net/zxdh/zxdh_np.c | 11 +++++++----
drivers/net/zxdh/zxdh_np.h | 2 ++
2 files changed, 9 insertions(+), 4 deletions(-)
--
2.27.0
[-- Attachment #1.1.2: Type: text/html , Size: 752 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1 1/2] net/zxdh: add pcie bar channel check
2025-12-22 10:25 ` [PATCH v1 0/2] fix bug Tianhao Zhang
@ 2025-12-22 10:25 ` Tianhao Zhang
2025-12-22 18:37 ` Stephen Hemminger
2025-12-22 10:25 ` [PATCH v1 2/2] net/zxdh: delete np soft resource uninstallation Tianhao Zhang
1 sibling, 1 reply; 6+ messages in thread
From: Tianhao Zhang @ 2025-12-22 10:25 UTC (permalink / raw)
To: stephen, wang.junlong1, yang.yonggang; +Cc: dev, Tianhao Zhang
[-- Attachment #1.1.1: Type: text/plain, Size: 1895 bytes --]
Add pcie bar channel check after getting dtb space left.
Signed-off-by: Tianhao Zhang <zhang.tianhao2@zte.com.cn>
---
drivers/net/zxdh/zxdh_np.c | 7 +++++++
drivers/net/zxdh/zxdh_np.h | 2 ++
2 files changed, 9 insertions(+)
diff --git a/drivers/net/zxdh/zxdh_np.c b/drivers/net/zxdh/zxdh_np.c
index 024da113e2..4e2637e1b6 100644
--- a/drivers/net/zxdh/zxdh_np.c
+++ b/drivers/net/zxdh/zxdh_np.c
@@ -3698,6 +3698,13 @@ zxdh_np_dtb_queue_unused_item_num_get(uint32_t dev_id,
rc = zxdh_np_reg_read(dev_id, ZXDH_DTB_INFO_QUEUE_BUF_SPACE,
0, queue_id, p_item_num);
ZXDH_COMM_CHECK_DEV_RC(dev_id, rc, "dpp_reg_read");
+
+ if((*p_item_num & ZXDH_DTB_SPACE_LEFT_MASK) == ZXDH_DTB_SPACE_LEFT_MASK)
+ {
+ PMD_DRV_LOG(ERR, "pcie bar abnormal, get dtb space left false.");
+ return ZXDH_RC_DTB_BAR_ABNORMAL;
+ }
+
return rc;
}
diff --git a/drivers/net/zxdh/zxdh_np.h b/drivers/net/zxdh/zxdh_np.h
index b0823192e7..5b9aec9c8f 100644
--- a/drivers/net/zxdh/zxdh_np.h
+++ b/drivers/net/zxdh/zxdh_np.h
@@ -94,6 +94,7 @@
#define ZXDH_DTB_TAB_ACK_SUCCESS_MASK (0xff)
#define ZXDH_DTB_TAB_ACK_FAILED_MASK (0x1)
#define ZXDH_DTB_TAB_ACK_CHECK_VALUE (0x12345678)
+#define ZXDH_DTB_SPACE_LEFT_MASK (0x3F)
#define ZXDH_DTB_TAB_ACK_VLD_SHIFT (104)
#define ZXDH_DTB_TAB_ACK_STATUS_SHIFT (96)
@@ -321,6 +322,7 @@
#define ZXDH_RC_DTB_DUMP_SIZE_SMALL (ZXDH_RC_DTB_BASE | 0x16)
#define ZXDH_RC_DTB_SEARCH_VPORT_QUEUE_ZERO (ZXDH_RC_DTB_BASE | 0x17)
#define ZXDH_RC_DTB_QUEUE_NOT_ENABLE (ZXDH_RC_DTB_BASE | 0x18)
+#define ZXDH_RC_DTB_BAR_ABNORMAL (ZXDH_RC_DTB_BASE | 0x19)
#define ZXDH_RC_CTRLCH_BASE (0xf00)
#define ZXDH_RC_CTRLCH_MSG_LEN_ZERO (ZXDH_RC_CTRLCH_BASE | 0x0)
--
2.27.0
[-- Attachment #1.1.2: Type: text/html , Size: 3784 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1 2/2] net/zxdh: delete np soft resource uninstallation
2025-12-22 10:25 ` [PATCH v1 0/2] fix bug Tianhao Zhang
2025-12-22 10:25 ` [PATCH v1 1/2] net/zxdh: add pcie bar channel check Tianhao Zhang
@ 2025-12-22 10:25 ` Tianhao Zhang
2025-12-22 18:38 ` Stephen Hemminger
1 sibling, 1 reply; 6+ messages in thread
From: Tianhao Zhang @ 2025-12-22 10:25 UTC (permalink / raw)
To: stephen, wang.junlong1, yang.yonggang; +Cc: dev, Tianhao Zhang
[-- Attachment #1.1.1: Type: text/plain, Size: 702 bytes --]
Delete np soft resource uninstallation from NP online uninit process.
Signed-off-by: Tianhao Zhang <zhang.tianhao2@zte.com.cn>
---
drivers/net/zxdh/zxdh_np.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/zxdh/zxdh_np.c b/drivers/net/zxdh/zxdh_np.c
index 4e2637e1b6..3bb765e05d 100644
--- a/drivers/net/zxdh/zxdh_np.c
+++ b/drivers/net/zxdh/zxdh_np.c
@@ -4243,10 +4243,6 @@ zxdh_np_online_uninit(uint32_t dev_id,
if (rc != 0)
PMD_DRV_LOG(ERR, "dtb release port name %s queue id %u", port_name, queue_id);
- rc = zxdh_np_soft_res_uninstall(dev_id);
- if (rc != 0)
- PMD_DRV_LOG(ERR, "zxdh_np_soft_res_uninstall failed");
-
return 0;
}
--
2.27.0
[-- Attachment #1.1.2: Type: text/html , Size: 1321 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/2] net/zxdh: add pcie bar channel check
2025-12-22 10:25 ` [PATCH v1 1/2] net/zxdh: add pcie bar channel check Tianhao Zhang
@ 2025-12-22 18:37 ` Stephen Hemminger
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Hemminger @ 2025-12-22 18:37 UTC (permalink / raw)
To: Tianhao Zhang; +Cc: wang.junlong1, yang.yonggang, dev
On Mon, 22 Dec 2025 18:25:34 +0800
Tianhao Zhang <zhang.tianhao2@zte.com.cn> wrote:
> Add pcie bar channel check after getting dtb space left.
>
> Signed-off-by: Tianhao Zhang <zhang.tianhao2@zte.com.cn>
> ---
> drivers/net/zxdh/zxdh_np.c | 7 +++++++
> drivers/net/zxdh/zxdh_np.h | 2 ++
> 2 files changed, 9 insertions(+)
>
> diff --git a/drivers/net/zxdh/zxdh_np.c b/drivers/net/zxdh/zxdh_np.c
> index 024da113e2..4e2637e1b6 100644
> --- a/drivers/net/zxdh/zxdh_np.c
> +++ b/drivers/net/zxdh/zxdh_np.c
> @@ -3698,6 +3698,13 @@ zxdh_np_dtb_queue_unused_item_num_get(uint32_t dev_id,
> rc = zxdh_np_reg_read(dev_id, ZXDH_DTB_INFO_QUEUE_BUF_SPACE,
> 0, queue_id, p_item_num);
> ZXDH_COMM_CHECK_DEV_RC(dev_id, rc, "dpp_reg_read");
> +
> + if((*p_item_num & ZXDH_DTB_SPACE_LEFT_MASK) == ZXDH_DTB_SPACE_LEFT_MASK)
> + {
> + PMD_DRV_LOG(ERR, "pcie bar abnormal, get dtb space left false.");
> + return ZXDH_RC_DTB_BAR_ABNORMAL;
> + }
> +
> return rc;
> }
>
The DPDK style is like the Linux kernel coding style, the bracket should be on the if() line.
The indentation is also off.
It is also not clear what "space left" means, could you provide a clearer message.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 2/2] net/zxdh: delete np soft resource uninstallation
2025-12-22 10:25 ` [PATCH v1 2/2] net/zxdh: delete np soft resource uninstallation Tianhao Zhang
@ 2025-12-22 18:38 ` Stephen Hemminger
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Hemminger @ 2025-12-22 18:38 UTC (permalink / raw)
To: Tianhao Zhang; +Cc: wang.junlong1, yang.yonggang, dev
On Mon, 22 Dec 2025 18:25:35 +0800
Tianhao Zhang <zhang.tianhao2@zte.com.cn> wrote:
> Delete np soft resource uninstallation from NP online uninit process.
>
> Signed-off-by: Tianhao Zhang <zhang.tianhao2@zte.com.cn>
> ---
> drivers/net/zxdh/zxdh_np.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/zxdh/zxdh_np.c b/drivers/net/zxdh/zxdh_np.c
> index 4e2637e1b6..3bb765e05d 100644
> --- a/drivers/net/zxdh/zxdh_np.c
> +++ b/drivers/net/zxdh/zxdh_np.c
> @@ -4243,10 +4243,6 @@ zxdh_np_online_uninit(uint32_t dev_id,
> if (rc != 0)
> PMD_DRV_LOG(ERR, "dtb release port name %s queue id %u", port_name, queue_id);
>
> - rc = zxdh_np_soft_res_uninstall(dev_id);
> - if (rc != 0)
> - PMD_DRV_LOG(ERR, "zxdh_np_soft_res_uninstall failed");
> -
> return 0;
> }
>
OK, but would like a better explanation. I assume it something like "soft reset is not necessary on device cleanup"
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-12-22 18:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-09 2:16 [PATCH v1] net/zxdh: add pcie bar channel check Tianhao Zhang
2025-12-22 10:25 ` [PATCH v1 0/2] fix bug Tianhao Zhang
2025-12-22 10:25 ` [PATCH v1 1/2] net/zxdh: add pcie bar channel check Tianhao Zhang
2025-12-22 18:37 ` Stephen Hemminger
2025-12-22 10:25 ` [PATCH v1 2/2] net/zxdh: delete np soft resource uninstallation Tianhao Zhang
2025-12-22 18:38 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).