From: Stephen Hemminger <stephen@networkplumber.org>
To: Tianhao Zhang <zhang.tianhao2@zte.com.cn>
Cc: wang.junlong1@zte.com.cn, yang.yonggang@zte.com.cn, dev@dpdk.org
Subject: Re: [PATCH v1 2/2] net/zxdh: delete np soft resource uninstallation
Date: Mon, 22 Dec 2025 10:38:43 -0800 [thread overview]
Message-ID: <20251222103843.6ca407e8@phoenix.local> (raw)
In-Reply-To: <20251222102535.401064-3-zhang.tianhao2@zte.com.cn>
On Mon, 22 Dec 2025 18:25:35 +0800
Tianhao Zhang <zhang.tianhao2@zte.com.cn> wrote:
> Delete np soft resource uninstallation from NP online uninit process.
>
> Signed-off-by: Tianhao Zhang <zhang.tianhao2@zte.com.cn>
> ---
> drivers/net/zxdh/zxdh_np.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/zxdh/zxdh_np.c b/drivers/net/zxdh/zxdh_np.c
> index 4e2637e1b6..3bb765e05d 100644
> --- a/drivers/net/zxdh/zxdh_np.c
> +++ b/drivers/net/zxdh/zxdh_np.c
> @@ -4243,10 +4243,6 @@ zxdh_np_online_uninit(uint32_t dev_id,
> if (rc != 0)
> PMD_DRV_LOG(ERR, "dtb release port name %s queue id %u", port_name, queue_id);
>
> - rc = zxdh_np_soft_res_uninstall(dev_id);
> - if (rc != 0)
> - PMD_DRV_LOG(ERR, "zxdh_np_soft_res_uninstall failed");
> -
> return 0;
> }
>
OK, but would like a better explanation. I assume it something like "soft reset is not necessary on device cleanup"
prev parent reply other threads:[~2025-12-22 18:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 2:16 [PATCH v1] net/zxdh: add pcie bar channel check Tianhao Zhang
2025-12-22 10:25 ` [PATCH v1 0/2] fix bug Tianhao Zhang
2025-12-22 10:25 ` [PATCH v1 1/2] net/zxdh: add pcie bar channel check Tianhao Zhang
2025-12-22 18:37 ` Stephen Hemminger
2025-12-22 10:25 ` [PATCH v1 2/2] net/zxdh: delete np soft resource uninstallation Tianhao Zhang
2025-12-22 18:38 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251222103843.6ca407e8@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=wang.junlong1@zte.com.cn \
--cc=yang.yonggang@zte.com.cn \
--cc=zhang.tianhao2@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).