From: Stephen Hemminger <stephen@networkplumber.org>
To: Soumyadeep Hore <soumyadeep.hore@intel.com>
Cc: thomas@monjalon.net, ajit.khaparde@broadcom.com,
bruce.richardson@intel.com, jerinj@marvell.com,
rasland@nvidia.com, dev@dpdk.org, aman.deep.singh@intel.com
Subject: Re: [RFC PATCH v2] ethdev: update read time API in PMD to enable crosstimestamp
Date: Wed, 24 Dec 2025 09:18:07 -0800 [thread overview]
Message-ID: <20251224091807.2f57cd1a@phoenix.local> (raw)
In-Reply-To: <20251224073317.68784-1-soumyadeep.hore@intel.com>
On Wed, 24 Dec 2025 07:33:17 +0000
Soumyadeep Hore <soumyadeep.hore@intel.com> wrote:
> diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h
> index 1255cd6f2c..000598b380 100644
> --- a/lib/ethdev/ethdev_driver.h
> +++ b/lib/ethdev/ethdev_driver.h
> @@ -798,7 +798,7 @@ typedef int (*eth_timesync_adjust_freq)(struct rte_eth_dev *dev, int64_t);
>
> /** @internal Function used to get time from the device clock. */
> typedef int (*eth_timesync_read_time)(struct rte_eth_dev *dev,
> - struct timespec *timestamp);
> + struct timespec *timestamp, uint8_t is_cross_ts_en)
Could be bool? Maybe a better variable name?
You should also have an example of where this will be called with true value.
prev parent reply other threads:[~2025-12-24 17:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <https://patches.dpdk.org/project/dpdk/patch/20251224064010.66586-1-soumyadeep.hore@intel.com/>
2025-12-24 7:33 ` Soumyadeep Hore
2025-12-24 17:18 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251224091807.2f57cd1a@phoenix.local \
--to=stephen@networkplumber.org \
--cc=ajit.khaparde@broadcom.com \
--cc=aman.deep.singh@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=rasland@nvidia.com \
--cc=soumyadeep.hore@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).