From: Stephen Hemminger <stephen@networkplumber.org>
To: Sunyang Wu <sunyang.wu@jaguarmicro.com>
Cc: dev@dpdk.org, wisamm@nvidia.com
Subject: Re: [PATCH] doc: update flow-perf.rst --query-rate option description
Date: Fri, 26 Dec 2025 12:07:44 -0800 [thread overview]
Message-ID: <20251226120744.2351fb83@phoenix.local> (raw)
In-Reply-To: <20251226015057.49408-1-sunyang.wu@jaguarmicro.com>
On Fri, 26 Dec 2025 09:50:57 +0800
Sunyang Wu <sunyang.wu@jaguarmicro.com> wrote:
> Update the --query-rate option description in flow-perf.rst
>
> Signed-off-by: Sunyang Wu <sunyang.wu@jaguarmicro.com>
> ---
> doc/guides/tools/flow-perf.rst | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/doc/guides/tools/flow-perf.rst b/doc/guides/tools/flow-perf.rst
> index 5d7ae86cb0..a289ba482b 100644
> --- a/doc/guides/tools/flow-perf.rst
> +++ b/doc/guides/tools/flow-perf.rst
> @@ -89,21 +89,6 @@ The command line options are:
>
> * ``--query-rate``
> Enable query rate calculations.
> - The application measures the rate of flow rule query operations.
> - After inserting the specified number of flow rules, the application
> - queries each rule sequentially and measures the total time taken.
> - The query rate is calculated as the number of query operations divided
> - by the total time.
> -
> - Example usage with query rate calculation:
> -
> - .. code-block:: console
> -
> - sudo ./dpdk-test-flow_perf -a 08:00.0 -- --ingress --ether --ipv4 --queue --rules-count=100000 --query-rate
> -
> - The query rate measurement follows the same window-based approach as
> - insertion and deletion rate measurements, using the window size
> - configured via --rules-batch.
>
> * ``--dump-socket-mem``
> Dump the memory stats for each socket before the insertion and after.
The description in the guide is awkward to read and unclear.
But dropping the complete description is not the best way to resolve it.
I would recommend rewriting (maybe using AI) and make it clea what the
test measures and what the expected result is.
prev parent reply other threads:[~2025-12-26 20:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-26 1:50 Sunyang Wu
2025-12-26 20:07 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251226120744.2351fb83@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=sunyang.wu@jaguarmicro.com \
--cc=wisamm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).