From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH 3/4] telemetry: replace perror with log
Date: Sun, 28 Dec 2025 12:10:52 -0800 [thread overview]
Message-ID: <20251228201649.555898-4-stephen@networkplumber.org> (raw)
In-Reply-To: <20251228201649.555898-1-stephen@networkplumber.org>
Use logging instead of print to stderr.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/telemetry/telemetry.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c
index cf4324421d..b109d076d4 100644
--- a/lib/telemetry/telemetry.c
+++ b/lib/telemetry/telemetry.c
@@ -365,7 +365,7 @@ output_json(const char *cmd, const struct rte_tel_data *d, int s)
used += prefix_used;
used += strlcat(out_buf + used, "}", sizeof(out_buf) - used);
if (write(s, out_buf, used) < 0)
- perror("Error writing to socket");
+ TMTY_LOG_LINE(ERR, "Error writing to socket: %s", strerror(errno));
}
static void
@@ -384,7 +384,7 @@ perform_command(const struct cmd_callback *cb, const char *cmd, const char *para
int used = snprintf(out_buf, sizeof(out_buf), "{\"%.*s\":null}",
MAX_CMD_LEN, cmd ? cmd : "none");
if (write(s, out_buf, used) < 0)
- perror("Error writing to socket");
+ TMTY_LOG_LINE(ERR, "Error writing to socket: %s", strerror(errno));
return;
}
output_json(cmd, &data, s);
--
2.51.0
next prev parent reply other threads:[~2025-12-28 20:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-28 20:10 [PATCH 0/4] Avoid using perror Stephen Hemminger
2025-12-28 20:10 ` [PATCH 1/4] checkpatches: warn if perror is used Stephen Hemminger
2025-12-28 20:10 ` [PATCH 2/4] bus/dpaa: replace perror with log Stephen Hemminger
2025-12-28 20:10 ` Stephen Hemminger [this message]
2025-12-28 20:10 ` [PATCH 4/4] common/dpaax: replace use of " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251228201649.555898-4-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).