From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id BEF1C1B848; Wed, 31 Jan 2018 22:10:12 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1D1BF20D39; Wed, 31 Jan 2018 16:10:12 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 31 Jan 2018 16:10:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=0+G5LqFyQ63cT1XdKnE7aRqgvY bwugJXmkBDaavcv48=; b=YNB4T7AmDQhhQK35YC7ioz9JB9BnhCele65Mty+Gjd Kt853zN+s95zjnuzlhR1PPCBUWAEyb7gG81T2zeIE2XGS51KXyhmEQJwR6N3k67L HDm10jYzulB7Zls6JOGOkbwxcCb+v2bKz/6gWaUpw7XiaJdQwvPnDutXp+oJlNZu o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=0+G5Lq FyQ63cT1XdKnE7aRqgvYbwugJXmkBDaavcv48=; b=cIGSwbVJRUfh3KPhIxGXXV sNPRF5n/VJx6/a7Ecz8pAa25iQuSowjK+ThQU1v/wRoM+LoIocKz99TvYFAczZ79 AvRuuBjQTzWxl1RWSWdGwEBQxPkR9sjSCxC7Vp72l3icLcioZEwvHUOfbomQ+NYs fvVobL7Zc/YrTBGnrfbzp/NHBHT6vrCFOHKiihsFFeNZIj8KA9kZILZqlds9+YiM jGX6GoTf9Ei2eNIjwHak4KHVNUPa/VhPBkSXlkNEdVirqECws4l3H1QozvReBlri 02LOdTkw69Vtz/OPyQ2rFtt6Hy9Y0+Xf3BhXyAudtsEfCeFAEdx8kmbvfHSTuGbQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C8A1724837; Wed, 31 Jan 2018 16:10:11 -0500 (EST) From: Thomas Monjalon To: Moti Haimovsky Cc: dev@dpdk.org, wenzhuo.lu@intel.com, techboard@dpdk.org Date: Wed, 31 Jan 2018 22:09:24 +0100 Message-ID: <2025687.oP9oAAUX4U@xps> In-Reply-To: <1517419923-31711-1-git-send-email-motih@mellanox.com> References: <1517417958-30594-1-git-send-email-motih@mellanox.com> <1517419923-31711-1-git-send-email-motih@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7] app/testpmd: removed preconf Rx VLAN offloads X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jan 2018 21:10:12 -0000 31/01/2018 18:32, Moti Haimovsky: > Removed the hardcoded preconfigured Rx VLAN offload configuration > from testpmd and changed the Rx offload command line parameters from > disable to enable. > It has been decided by the Technical Board that testers who wish to > use these offloads will now have to explicitly write them in the > command-line when running testpmd. > Motivation: > Some PMDs such at the mlx4 may not implement all the offloads. > After the offload API rework assuming no offload is enabled by default, > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") > commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") trying > to enable a not supported offload is clearly an error which will cause > configuration failing. > > Considering that testpmd is an application to test the PMD, it should > not fail on a configuration which was not explicitly requested. > The behavior of this test application is then turned to an opt-in > model. > > Signed-off-by: Moti Haimovsky Acked-by: Thomas Monjalon Applied with added explanations about the Technical Board agreement. Thanks